MIME-Version: 1.0
References: <19484-a3cb82c8cde3c8fa@postgresql.org>
 <CAJTYsWXY9C3B-7NZw72OKen2L2rZt=c-t6=kjTJzgj=ZaNPe8g@mail.gmail.com>
 <DIPI7GSQFV1C.20OALZACS6KLI@gmail.com>
 <CA+FpmFc10Dtnr9dr=xqK2cNYQ4-1VuOyvOT7-eqXPmiQJoyPew@mail.gmail.com>
 <DJ4M4TOUHLM0.B38DAVN79FPH@gmail.com>
 <CAJTYsWWUfgCZau2fvrZVruXmC+dyOx45L=TyaGzXdywsywDyHQ@mail.gmail.com>
 <DJ5BM93JVJ7C.MQC43GITCBOY@gmail.com>
 <CA+HiwqHVMY1a5E+6Ei369+RqQ8qKSSgon_C=3yBk-TPJDwZ2nQ@mail.gmail.com>
 <CA+HiwqHjUO0uXFZ2dECJiNime6B1FDL5+mJ=XN+1XgzkY=m9DA@mail.gmail.com>
 <CAPmGK16GNiwcnAxM3XU=ZTOP_8oiv7_FOUwo5hZp8b+qfv2L7g@mail.gmail.com>
 <CA+HiwqEVwEPSE4yMvuwVT5bb+ziMHLfqd_HuiQPAFAixNHbhrQ@mail.gmail.com>
 <CA+HiwqHO0Bbi6cyk4F+UGvZEV3NEo7o0YT3-Js7K7hvasoWBVw@mail.gmail.com>
 <CAPmGK16fALJqbyR1Oir7-TsN8k_yAR-JcOg5nWOUmDmivTmDtA@mail.gmail.com>
 <CAPmGK14Qh_Wb4GNPNkZ1o9=vTcMKShzPNSWa=wNf9vJpg8qT+Q@mail.gmail.com>
In-Reply-To: 
 <CAPmGK14Qh_Wb4GNPNkZ1o9=vTcMKShzPNSWa=wNf9vJpg8qT+Q@mail.gmail.com>
From: Amit Langote <amitlangote09@gmail.com>
Date: Thu, 18 Jun 2026 19:57:07 +0900
Message-ID: 
 <CA+HiwqHRDsYDqJ-7f5P_QpJo=U1BYzMnfDnNOr6Vx3Rw36O0iQ@mail.gmail.com>
Subject: Re: BUG #19484: Segmentation fault triggered by FDW
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Matheus Alcantara <matheusssilv97@gmail.com>,
 Ayush Tiwari <ayushtiwari.slg01@gmail.com>,
	Rafia Sabih <rafia.pghackers@gmail.com>, 798604270@qq.com,
	pgsql-bugs@lists.postgresql.org, Amit Langote <amitlan@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000003ae9150654850a11"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BHiwqHRDsYDqJ-7f5P_QpJo%3DU1BYzMnfDnNOr6Vx3Rw36O0iQ%40mail.gmail.com>
Precedence: bulk

--0000000000003ae9150654850a11
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 18, 2026 at 19:55 Etsuro Fujita <etsuro.fujita@gmail.com> wrote=
:

> Sorry, I accidentally sent this before I finished writing.
>
> On Thu, Jun 18, 2026 at 7:50=E2=80=AFPM Etsuro Fujita <etsuro.fujita@gmai=
l.com>
> wrote:
> >
> > Amit-san,
> >
> > On Thu, Jun 18, 2026 at 6:16=E2=80=AFPM Amit Langote <amitlangote09@gma=
il.com>
> wrote:
> > > A small clarification on this one: the patch makes no changes to
> > > postgres_fdw code, only adds a regression test. The bug, which I
> > > introduced, is in how nodeModifyTable.c supplies fdw_private from the
> > > pruned/validated fdwPrivLists in ModifyTableState rather than the
> > > original list in ModifyTable, so the postgres_fdw side itself is
> > > unchanged. The substantive change is the executor re-indexing.
> >
> > Thanks for the clarification!
> >
> > > Still holding off on committing per our exchange, but no rush given
> > > you may want to prioritize the v19 open items. Happy to go ahead
> > > whenever, or wait for your comments.
>
> Actually, I've just started reviewing the patch.  I'll let you know
> the results (if any) by tomorrow.  Thanks for the consideration as
> well.


Ah, thanks for the heads up.

- Amit

>

--0000000000003ae9150654850a11
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">On Thu, Jun 18, 2026 at 19:55 Etsuro Fujita &lt;<a href=
=3D"mailto:etsuro.fujita@gmail.com">etsuro.fujita@gmail.com</a>&gt; wrote:<=
br></div><div dir=3D"auto"><div class=3D"gmail_quote gmail_quote_container"=
><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border=
-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:=
rgb(204,204,204)" dir=3D"auto">Sorry, I accidentally sent this before I fin=
ished writing.<br>
<br>
On Thu, Jun 18, 2026 at 7:50=E2=80=AFPM Etsuro Fujita &lt;<a href=3D"mailto=
:etsuro.fujita@gmail.com" target=3D"_blank">etsuro.fujita@gmail.com</a>&gt;=
 wrote:<br>
&gt;<br>
&gt; Amit-san,<br>
&gt;<br>
&gt; On Thu, Jun 18, 2026 at 6:16=E2=80=AFPM Amit Langote &lt;<a href=3D"ma=
ilto:amitlangote09@gmail.com" target=3D"_blank">amitlangote09@gmail.com</a>=
&gt; wrote:<br>
&gt; &gt; A small clarification on this one: the patch makes no changes to<=
br>
&gt; &gt; postgres_fdw code, only adds a regression test. The bug, which I<=
br>
&gt; &gt; introduced, is in how nodeModifyTable.c supplies fdw_private from=
 the<br>
&gt; &gt; pruned/validated fdwPrivLists in ModifyTableState rather than the=
<br>
&gt; &gt; original list in ModifyTable, so the postgres_fdw side itself is<=
br>
&gt; &gt; unchanged. The substantive change is the executor re-indexing.<br=
>
&gt;<br>
&gt; Thanks for the clarification!<br>
&gt;<br>
&gt; &gt; Still holding off on committing per our exchange, but no rush giv=
en<br>
&gt; &gt; you may want to prioritize the v19 open items. Happy to go ahead<=
br>
&gt; &gt; whenever, or wait for your comments.<br>
<br>
Actually, I&#39;ve just started reviewing the patch.=C2=A0 I&#39;ll let you=
 know<br>
the results (if any) by tomorrow.=C2=A0 Thanks for the consideration as<br>
well.</blockquote><div dir=3D"auto"><br></div><div dir=3D"auto">Ah, thanks =
for the heads up.</div><div dir=3D"auto"><br></div><div dir=3D"auto">- Amit=
</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;b=
order-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-c=
olor:rgb(204,204,204)" dir=3D"auto"></blockquote></div></div>

--0000000000003ae9150654850a11--