MIME-Version: 1.0
References: <19484-a3cb82c8cde3c8fa@postgresql.org>
 <CAJTYsWXY9C3B-7NZw72OKen2L2rZt=c-t6=kjTJzgj=ZaNPe8g@mail.gmail.com>
 <DIPI7GSQFV1C.20OALZACS6KLI@gmail.com>
 <CA+FpmFc10Dtnr9dr=xqK2cNYQ4-1VuOyvOT7-eqXPmiQJoyPew@mail.gmail.com>
 <DJ4M4TOUHLM0.B38DAVN79FPH@gmail.com>
 <CAJTYsWWUfgCZau2fvrZVruXmC+dyOx45L=TyaGzXdywsywDyHQ@mail.gmail.com>
 <DJ5BM93JVJ7C.MQC43GITCBOY@gmail.com>
In-Reply-To: <DJ5BM93JVJ7C.MQC43GITCBOY@gmail.com>
From: Amit Langote <amitlangote09@gmail.com>
Date: Wed, 10 Jun 2026 22:09:12 +0900
Message-ID: 
 <CA+HiwqHVMY1a5E+6Ei369+RqQ8qKSSgon_C=3yBk-TPJDwZ2nQ@mail.gmail.com>
Subject: Re: BUG #19484: Segmentation fault triggered by FDW
To: Matheus Alcantara <matheusssilv97@gmail.com>
Cc: Ayush Tiwari <ayushtiwari.slg01@gmail.com>,
 Rafia Sabih <rafia.pghackers@gmail.com>,
	798604270@qq.com, pgsql-bugs@lists.postgresql.org,
	Etsuro Fujita <etsuro.fujita@gmail.com>,
 Amit Langote <amitlan@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BHiwqHVMY1a5E%2B6Ei369%2BRqQ8qKSSgon_C%3D3yBk-TPJDwZ2nQ%40mail.gmail.com>
Precedence: bulk

Hi Matheus,

On Wed, Jun 10, 2026 at 8:09=E2=80=AFPM Matheus Alcantara
<matheusssilv97@gmail.com> wrote:
>
> On Wed Jun 10, 2026 at 2:15 AM -03, Ayush Tiwari wrote:
> >> One minor naming observation: the new fdwPrivLists field in
> >> ModifyTableState doesn't follow the mt_ prefix convention used by the
> >> other re-indexed lists (mt_updateColnosLists, mt_mergeActionLists,
> >> mt_mergeJoinConditions). Should we rename it to mt_fdwPrivLists for
> >> consistency?
> >>
> >
> > I think yes, it makes sense to rename it.
> >
>
> Attached v2 renamed, thanks.
>
> (Also CC Amit on this since he committed cbc127917e0 which I believe
> that is when the issue started)

Thanks for adding me.  I'll take a look at this early next week.

--=20
Thanks, Amit Langote