public inbox for [email protected]  

help / color / mirror / Atom feed

From: Robert Haas <[email protected]>
To: Fujii Masao <[email protected]>
Cc: TAKATSUKA Haruka <[email protected]>
Cc: [email protected]
Subject: Re: BUG #18876: HINT messages for mxid wrap-around say "drop stale slots", but that may not be appropriate
Date: Mon, 6 Jul 2026 13:22:48 -0400
Message-ID: <CA+TgmoY=5XoygpFxzO3DLjde9VS_jLYDEC=x7ZShd=LKkDysjw@mail.gmail.com> (raw)
In-Reply-To: <CAHGQGwG+a=VADnPvxk-uMs0-XstgihC+rZzW1UJV6qECVZf+NQ@mail.gmail.com>
References: <[email protected]>
	<CAHGQGwFKngUKWOM=N3sAOGCL95TjQf2jM8E3put7=cmGKHHg0A@mail.gmail.com>
	<[email protected]>
	<CAHGQGwGhDDF-KD72mHKR_Dvh6gfTV3i0q3+hY69MTXOxdOCo0g@mail.gmail.com>
	<CAHGQGwG+a=VADnPvxk-uMs0-XstgihC+rZzW1UJV6qECVZf+NQ@mail.gmail.com>

On Thu, Jul 2, 2026 at 10:26 PM Fujii Masao <[email protected]> wrote:
> I've pushed the patch. Thanks!

Hi,

I'm a bit concerned about this patch, specifically this part:

+      <simpara>Unlike transaction ID wraparound, replication slots do not
+       directly hold back multixact cleanup. Dropping stale replication
+       slots is therefore not usually relevant to resolving multixact ID
+       wraparound problems.</simpara>

The problem with the word "usually" here is that it leaves room for
replication slots to be relevant in some corner case that isn't
described, while asserting without explanation that they most often
won't matter. I feel like that leaves users and DBAs in a very awkward
position. The way it seems to me, either holding back the XID
threshold can indirectly hold back the MXID threshold, or it can't. If
it can, then the documentation before this patch was correct, and this
shouldn't have been committed, and if it can't, then we don't need the
word "usually" here.

Now maybe that's a bit too simplistic. I'd be OK with a statement
involving "usually" if it went on to explain convincingly why it
doesn't normally happen and why it sometimes can under extraordinary
circumstances. But without that, I feel this is making things less
clear rather than more clear.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: BUG #18876: HINT messages for mxid wrap-around say "drop stale slots", but that may not be appropriate
  In-Reply-To: <CA+TgmoY=5XoygpFxzO3DLjde9VS_jLYDEC=x7ZShd=LKkDysjw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox