From: Chengpeng Yan <chengpeng_yan@outlook.com>
To: David Rowley <dgrowleyml@gmail.com>
CC: John Naylor <johncnaylorls@gmail.com>, Richard Guo
	<guofenglinux@gmail.com>, "imchifan@163.com" <imchifan@163.com>,
	"pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #19533: Wrong results from WindowAgg run-condition pushdown
 on count() with EXCLUDE CURRENT ROW
Thread-Topic: BUG #19533: Wrong results from WindowAgg run-condition pushdown
 on count() with EXCLUDE CURRENT ROW
Thread-Index: 
 AQHdBjQ36OrnPlHeFUa7BV8yKQiSCrZSnoYAgAIUgwCAANtUAIAFoBMAgABckQCAAPf4gIACRwEAgAAkboCAATZDAIAAEpwA
Date: Mon, 6 Jul 2026 08:31:42 +0000
Message-ID: <CA22A3A0-3ADC-413B-8A91-683E20497E2E@outlook.com>
References: <19533-413a1014e5d0e766@postgresql.org>
 <EC273387-5C73-4C9C-BF30-8BA260A90FFB@outlook.com>
 <CAMbWs4-6umOecRifmC88RW0SHWDAvb4c3-VD8XQ3NJufsUyUOQ@mail.gmail.com>
 <CAApHDvqHXZpF9pPStLqPp5O=G2gVpPD959bMTRRkLjdy4Tvx7g@mail.gmail.com>
 <CAApHDvoJ07GM6V2QWyJAgsJcM-dcFS+nwPq4Um=-NsXv5PmoCw@mail.gmail.com>
 <CANWCAZbiYQ+=CHAaftwp2x83Gy6tJCB8GUe15yO5DW-cpp0Mxg@mail.gmail.com>
 <CAApHDvrN-HL=dSBez=pme5RQKCiH7SrsMEFV-eQRJN3Vs94ZEQ@mail.gmail.com>
 <CANWCAZap+k7-E2f-XoC36Hk4izZjbN8w2c9OuomummGfZ5d20w@mail.gmail.com>
 <D1C82EBB-54F6-420E-9006-3A737B0E70A6@outlook.com>
 <CAApHDvpKHEZXVDsaAyJ9pAkX3KH34jC83spXPjJPyrtrsKk_HA@mail.gmail.com>
In-Reply-To: 
 <CAApHDvpKHEZXVDsaAyJ9pAkX3KH34jC83spXPjJPyrtrsKk_HA@mail.gmail.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: TYYPR01MB14116:EE_|OSZPR01MB6696:EE_
x-ms-office365-filtering-correlation-id: 38f9e8d0-30cd-4f68-197f-08dedb3901ec
x-microsoft-antispam: 
 BCL:0;ARA:14566002|8062599012|19110799012|8060799015|12121999013|31061999003|51005399006|25010399006|24121999003|22091999003|24021099003|15080799012|40105399003|102099032|440099028|3412199025;
x-microsoft-antispam-message-info: 
 =?us-ascii?Q?LyyQMsLjqFrPV3pZj1p5tFzIzdRz5ZgyFlPfaB2aVBVM80LlBtSHY8N3ymUt?=
 =?us-ascii?Q?D0GCGQXgitahB5ji0zG177w8Yo1Wmvfrtl32UuvcfoetK/gvJM+2W+FWx/5G?=
 =?us-ascii?Q?D6ctTzMzPw191J7jEAaVz0aV683ZJyrW+/hAcTPr19uoff78Robepw+Xch5E?=
 =?us-ascii?Q?ArU+Z5M1FQM8IBhtVNenSSaPyipOePPhYFfTQ8IjKn8wn97UQsof9nV32zpO?=
 =?us-ascii?Q?LG40NSrAvicsIIlAwDlx2WUxWf4SCkWpEvUh+8Xr4+f7wc8a4hnB6OnucA9B?=
 =?us-ascii?Q?2T8fkRO2LaQDjrz4M9wvTdjLSTJbcGoUt0h8evGbSJnfHh/oRZqyVPWnTN0V?=
 =?us-ascii?Q?sP6gTyo9knjPcZAMBNTTbjtOPLGB+6BckLKPCWadLGZEEnIjGKtiak/BXkWt?=
 =?us-ascii?Q?rd05DmF4gPfz0PdYDVEs+UDyMPKbGUqDQnr84VjcGW3wwNHSXywfeqAziZrC?=
 =?us-ascii?Q?bPfmcfEqa4gOiK5N7zXxHuf7DkxNwrJkhIrVGoHfMDlLX19rOGDjypitDZRR?=
 =?us-ascii?Q?uMTfTI618fReVOGT0Hc0drS/Qpw/bMhJ3mEuuOO4n+0W0ZVPTEFVzemmBYEZ?=
 =?us-ascii?Q?adezglb0AraiAHXnk/RCmwJq+wDNmI8Ysb4qelAD//jA116gLKQMX5FsHtya?=
 =?us-ascii?Q?+S16h2WmLE9DMGCPf5k5g8YdHqp7lIGe3Ai3uZ16bsPH3CmSi3CSULX26yjn?=
 =?us-ascii?Q?4u+vvs0OnBYKi8SWyoa/t237jOmWn8QxGZnuSgdg+VvT4u4xa0/Nzrckt2j2?=
 =?us-ascii?Q?wmeKwZNbcdW2jqvPep3/kP7lBfDv2CE9CyQwL/QCETs7CdWDI0+RQv5Jz1+V?=
 =?us-ascii?Q?oX5UA1SC8RYm0PBn4oYhPza3+rDYwwsl7gyLCMKZPwqu1V6NwIalK6f11dD0?=
 =?us-ascii?Q?WSzGNp21X+Ii/CIt9aBL/R6gZCUBlv3MX0iMHhy37ZMBap7nuGVjNKlDQLoz?=
 =?us-ascii?Q?yG7HZN4B04N731lIkFhf9Lqix+wB3ZbfQi+Ci7GaI6ljMPudOO3fa1oZ1mbY?=
 =?us-ascii?Q?rIpfY6cXrfVGMZNofNSyMinMwg=3D=3D?=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?O9mF+9dHdFRUuh+m3HN9uZDBIehNMapjeTBgg71/V9/RzNxMFq3vSi9IFRK/?=
 =?us-ascii?Q?vo/b8dB3u9r/zaIE5F1VWLsYmbWfOS7QNEU47OI9LdOnmHuvvLJ/mWDrj1Ka?=
 =?us-ascii?Q?cLcd2ZW4LGEgi2MgVxgGKSqMwssTo2ARTaJBI5FVpP1jV3SHIaFL4aW0chj0?=
 =?us-ascii?Q?TE4UtpsXcFwvhaQY2gWDSwJ1wrxAvMtmPVYZB1ENfJRlhDZfE2QIPqzkxeq4?=
 =?us-ascii?Q?UgOmJkPkbk1gNAuwgbgq6EFEgj6VE/BxwLDs5I6rX/lvJvfRkuUS9X1YoaEP?=
 =?us-ascii?Q?wUkynJ3jBnvcUR0CiAeKMfh9R2VQH2/pQ8R5Ob/sJPp5yFvIkTPNRXsa10RZ?=
 =?us-ascii?Q?/mPPdlcE849biXm7gC20NmowCgbMVKVEiqyjUb4f/WU+onT0+6UH+l4dhFwN?=
 =?us-ascii?Q?YsaxgUiyh39I71aE+blcrm6T8h76ak6DFpfmsUtV1twWXcPq19+N8AXwUQbU?=
 =?us-ascii?Q?0dRgIVNUJk3PQYK8lh7F1/MymiblmBAWYQq6vn1UkSZrJ/J4q4BcUoPfiyMw?=
 =?us-ascii?Q?syVvcgz4oWAduj8deHLhzsJw7MGuSbDCDWC0CDc+QWE4dAPRbeNjJNhZSHux?=
 =?us-ascii?Q?hhjZ3exCbiSjtfpsWdNs+IVBGzsxHtntnA1nth77X4e8HzXw0wUkR9y6/nMT?=
 =?us-ascii?Q?1IeYTC88nt1Wq96tRA2WD9hudCwsWd/yp3D2pT29H3Vuzo/WdQy4qqlxbV64?=
 =?us-ascii?Q?LGyYhsGME5nOs/hAd3lXbBWMRPOdB/kxr3uPgVos/O5ewspzarFoVa2f1V4Z?=
 =?us-ascii?Q?SjbG1JpUfXNQ4srA1hoyJLiWWH/RCHsUcr4lrViF5N1+cbCPRYh5pWWgjDf+?=
 =?us-ascii?Q?c92cOcJ0t34I58MMoMReHvYzSQ7Ph3RyYxWnz+IxN8YxQx5zL7sRl7pCLuxu?=
 =?us-ascii?Q?H7+bSotixin3IAyIZ+a1vaZBpoRO2kij+zakbJ8Ygxf6jlL4/ITxFXzdqmYR?=
 =?us-ascii?Q?LIiuVb61QYte50BfXPQ2vRLjOO/H/yLaVKF1tBUqr/SJh5vvL7b6O9nH5feX?=
 =?us-ascii?Q?037dHYOB9CX+oi0PU38yzLItjhwcz3S07mWPBHL3JxA3SEGm7yjWdH8lBxBx?=
 =?us-ascii?Q?9ErkyfzzcuJrS2VDsSjeh20tFj9eJ7z3equ0lDYCI+KuqhK5fY72JJ4n2R7R?=
 =?us-ascii?Q?0cYv/EoTgFNT5g+4wV3uUUyw52tRe7K0cZPV4sQtCOJqHWO75+mldUoBELOG?=
 =?us-ascii?Q?7bgrGaKFFO5szLyPNavz1uZiXtG0vbmZ10pQmsEmCuDB5e9FguGG9dAmrOCS?=
 =?us-ascii?Q?5vF8zVn9fiE0H4DsZUDMp48E+n2XaFGKL8mzY/I9LOOyOMplfC9xm1UBpctc?=
 =?us-ascii?Q?OF/5mh8eNaqzJtVLWv7gKUjgaC3w1sLbxsLfo3GVzvfInZeYCuxQSnWdAFqd?=
 =?us-ascii?Q?4r30quZa7ZiMc6flzX2AMm9ScWqFjeGHHnBwyti0Tu41kUL0uQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <94653C5CBD75C64981B7065955B299FA@jpnprd01.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYYPR01MB14116.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 
 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 38f9e8d0-30cd-4f68-197f-08dedb3901ec
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2026 08:31:42.4971
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 
 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSZPR01MB6696
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/CA22A3A0-3ADC-413B-8A91-683E20497E2E%40outlook.com>
Precedence: bulk

Hi David,

> On Jul 6, 2026, at 15:24, David Rowley <dgrowleyml@gmail.com> wrote:`
>=20
> Given how complex Claude's logic became to get all those cases
> correct, I now think the above is the best option. I've attached a
> patch for that.

Thanks for updating the patch.  I looked through the code and it looks
good to me.

One minor comment: this test comment seems to be a typo:

-- As above, but check we detect it's monotonically increasing

It looks like the following test is checking that we do not treat the
frame as monotonically increasing.

Other than that, LGTM.

--
Best regards,
Chengpeng Yan