public inbox for [email protected]
help / color / mirror / Atom feedFrom: David Rowley <[email protected]>
To: John Naylor <[email protected]>
Cc: Chengpeng Yan <[email protected]>
Cc: Richard Guo <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: BUG #19533: Wrong results from WindowAgg run-condition pushdown on count() with EXCLUDE CURRENT ROW
Date: Tue, 7 Jul 2026 17:35:13 +1200
Message-ID: <CAApHDvod3V=TKBB=Z3M-bPquzyznR1SYra77NWCTZLUUERm28g@mail.gmail.com> (raw)
In-Reply-To: <CANWCAZYT8pusrf554FpM6NgjS3uWjEkaip9oXSRVc2iu2CEqgw@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<CAMbWs4-6umOecRifmC88RW0SHWDAvb4c3-VD8XQ3NJufsUyUOQ@mail.gmail.com>
<CAApHDvqHXZpF9pPStLqPp5O=G2gVpPD959bMTRRkLjdy4Tvx7g@mail.gmail.com>
<CAApHDvoJ07GM6V2QWyJAgsJcM-dcFS+nwPq4Um=-NsXv5PmoCw@mail.gmail.com>
<CANWCAZbiYQ+=CHAaftwp2x83Gy6tJCB8GUe15yO5DW-cpp0Mxg@mail.gmail.com>
<CAApHDvrN-HL=dSBez=pme5RQKCiH7SrsMEFV-eQRJN3Vs94ZEQ@mail.gmail.com>
<CANWCAZap+k7-E2f-XoC36Hk4izZjbN8w2c9OuomummGfZ5d20w@mail.gmail.com>
<[email protected]>
<CAApHDvpKHEZXVDsaAyJ9pAkX3KH34jC83spXPjJPyrtrsKk_HA@mail.gmail.com>
<CANWCAZYT8pusrf554FpM6NgjS3uWjEkaip9oXSRVc2iu2CEqgw@mail.gmail.com>
On Tue, 7 Jul 2026 at 17:11, John Naylor <[email protected]> wrote:
> - /* No ORDER BY clause then all rows are peers */
> ...
> + /* No ORDER BY clause and RANGE mode means all rows are peers. */
>
> Was the old comment wrong? Or are all rows still peers, but that's not
> sufficient to show monotonicity?
The test needed to be updated because detecting monotonically
increasing and decreasing in ROWS mode wasn't correct. The comment got
updated along with the test.
David
view thread (15+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: BUG #19533: Wrong results from WindowAgg run-condition pushdown on count() with EXCLUDE CURRENT ROW
In-Reply-To: <CAApHDvod3V=TKBB=Z3M-bPquzyznR1SYra77NWCTZLUUERm28g@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox