MIME-Version: 1.0
References: <CAH+MXdxJusXfQoyzF3x8U=nh+QxmfiqGxZ1kPYXTfd8Srx5ZHg@mail.gmail.com>
In-Reply-To: <CAH+MXdxJusXfQoyzF3x8U=nh+QxmfiqGxZ1kPYXTfd8Srx5ZHg@mail.gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
Date: Wed, 1 Apr 2026 01:44:41 +1300
Message-ID: <CAApHDvpCn2t07ag0Bh+P66pGMJj=u97ROBetTHyj71byMvcYAg@mail.gmail.com>
Subject: Re: Surprising behavior with pushing predicates down into a view
To: Justin Christensen <justin.christensen89@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAApHDvpCn2t07ag0Bh%2BP66pGMJj%3Du97ROBetTHyj71byMvcYAg%40mail.gmail.com>
Precedence: bulk

On Tue, 31 Mar 2026 at 22:45, Justin Christensen
<justin.christensen89@gmail.com> wrote:
> When I query this view using a simple constant ticker like 'AAPL' the que=
ry plan shows that it correctly filters the set of tickers before applying =
the return calculations, joining, and then calculating beta. I've included =
the EXPLAIN output after the query in this gist.
>
> https://gist.github.com/JustinChristensen/1cad256ea61ad30aa39d42aebc4557b=
9#file-literal-filter-sql
>
> When I query this view using a subquery to find the tickers to filter on =
it instead tries to execute the view and calculate the beta for all of the =
tickers in the table before filtering:

In short, this isn't a bug.

When planning subqueries, which is effectively how a VIEW will be
planned unless it passed is_simple_subquery()'s tests, we only
consider pushing down "base" quals into that subquery. When you do
ticker =3D 'AAPL', that's a base qual, and that can be pushed down
because ticker is in the WINDOW's PARTITION BY clause, but ticker IN
(SELECT ticker FROM metrics ORDER BY random() LIMIT 50) is converted
into a SEMI join much earlier in planning, so that isn't a base qual
anymore. Even if we didn't do that tranformation in
convert_ANY_sublink_to_join(), we'd still fail to push down the base
qual into the subquery as qual_is_pushdown_safe() doesn't accept base
quals with subplans.

You might be better off changing the view to a table returning
function which accepts a ticker parameter and calling that function
once for each ticker you need.

David