MIME-Version: 1.0
References: <19438-9d37b179c56d43aa@postgresql.org> <1106026.1774573371@sss.pgh.pa.us>
 <1338824.1774633289@sss.pgh.pa.us> <CAApHDvox3Ro8mZJxignuyB-dGXJ9=wQNEkOFni9025GP=rOKkg@mail.gmail.com>
 <1830345.1774798374@sss.pgh.pa.us> <CAApHDvrdPriH6MO=YGEh9=KVDnDtqZyW4VuRXkmBS8WnRFessA@mail.gmail.com>
 <1881853.1774828272@sss.pgh.pa.us>
In-Reply-To: <1881853.1774828272@sss.pgh.pa.us>
From: David Rowley <dgrowleyml@gmail.com>
Date: Mon, 30 Mar 2026 13:15:56 +1300
Message-ID: <CAApHDvpZOCWwSNuBZ4Xg-EcbQ9Bxbk+58AsuE1FCbV5=wyXiqw@mail.gmail.com>
Subject: Re: BUG #19438: segfault with temp_file_limit inside cursor
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: kuzmin.db4@gmail.com, pgsql-bugs@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAApHDvpZOCWwSNuBZ4Xg-EcbQ9Bxbk%2B58AsuE1FCbV5%3DwyXiqw%40mail.gmail.com>
Precedence: bulk

On Mon, 30 Mar 2026 at 12:51, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> David Rowley <dgrowleyml@gmail.com> writes:
> > I don't know if that means
> > it's worth deviating from the similar WARNINGs you've added and making
> > that one an ERROR. There's certainly no guarantee with the other
> > context that we'll not crash sometime very soon after issuing the
> > warning anyway, so maybe it's fine.
>
> Seems like a reasonable answer.  What do you think of making the
> double-free cases ERRORs across the board?  If we don't error out,
> there will likely be cascading problems in all the mcxt types not
> just this one.

I think it's a good idea. It might slightly increase the chances that
we get a report about an issue. I suppose the logic in deciding which
elevel to make it could be applied about equally to the sentinel byte
check as well. Maybe that should also be an error for the same reason.

David