MIME-Version: 1.0
References: <19438-9d37b179c56d43aa@postgresql.org> <1106026.1774573371@sss.pgh.pa.us>
 <1338824.1774633289@sss.pgh.pa.us> <CAApHDvox3Ro8mZJxignuyB-dGXJ9=wQNEkOFni9025GP=rOKkg@mail.gmail.com>
 <1830345.1774798374@sss.pgh.pa.us> <1835962.1774801538@sss.pgh.pa.us>
In-Reply-To: <1835962.1774801538@sss.pgh.pa.us>
From: David Rowley <dgrowleyml@gmail.com>
Date: Mon, 30 Mar 2026 12:33:57 +1300
Message-ID: <CAApHDvreSetP_7y8bPbNxEYtWuyVrwUpgePa7=w8W1WfyjcEyQ@mail.gmail.com>
Subject: Re: BUG #19438: segfault with temp_file_limit inside cursor
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: kuzmin.db4@gmail.com, pgsql-bugs@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAApHDvreSetP_7y8bPbNxEYtWuyVrwUpgePa7%3Dw8W1WfyjcEyQ%40mail.gmail.com>
Precedence: bulk

On Mon, 30 Mar 2026 at 05:25, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I started to wonder if an explicit test in AlignedAllocFree
> could be useful anyway to make such problems a bit less obscure.
> However, when I tried
>
>         p = palloc_aligned(...);
>         pfree(p);
>         pfree(p);
>
> I got
>
> ERROR:  pfree called with invalid pointer 0x1f286b0 (header 0x7f7f7f7f7f7f7f7f)
>
> That is, we'll never get to AlignedAllocFree because the underlying
> context would have wipe_mem'd the aligned chunk's header during the
> first pfree.  The only case in which such a test could be helpful is
> in a build with MEMORY_CONTEXT_CHECKING but not CLOBBER_FREED_MEMORY.
> While I suppose some people might build that way, it's got to be such
> a tiny minority as to not be worth worrying about.

I think you might have trouble trying to get the MemoryContext.name
for the elog warning anyway. That's only accessible from the unaligned
allocation and whatever method that context type uses to backlink the
owning context from the chunk pointer. Given that, it very much seems
not worthwhile as I imagine that means adding some callback function
to MemoryContextMethods!

David