MIME-Version: 1.0
References: <18158-88f667028dbc7e7b@postgresql.org>
 <58b5d6bf-7dca-41e5-8000-e12981205ada@gmail.com>
 <CABPTF7XdDoLAoLKo7pOHmSqHniHf46Pw8Z=iqNx2uYi4J5ixBA@mail.gmail.com>
 <agQgZKF6q3rYRX7O@paquier.xyz>
 <CABPTF7VgzdBP_ZPKf2eZ79ry0fVKzcgCkB5gy60HGXCy0EQb0w@mail.gmail.com>
 <aiIxB2oawj8pZeON@paquier.xyz>
 <5edd4f4a-0d79-465d-a250-8b4735f780ca@gmail.com>
 <aiNmOOpe3VNReAh3@paquier.xyz>
 <CABPTF7XWsFgfAqqTv2epcMQs+vT6EMg_j43F8CSJ7Cjsv8QLJQ@mail.gmail.com>
 <aiZXx0Nh-P3pVQjo@paquier.xyz>
In-Reply-To: <aiZXx0Nh-P3pVQjo@paquier.xyz>
From: Xuneng Zhou <xunengzhou@gmail.com>
Date: Mon, 8 Jun 2026 16:43:31 +0800
Message-ID: 
 <CABPTF7Vg1CTf49c4gvYu-6-0h7LNSqgWe5_+63FcmTgeqseK1w@mail.gmail.com>
Subject: Re: BUG #18158: Assert in pgstat_report_stat() fails when a backend
 shutting down with stats pending
To: Michael Paquier <michael@paquier.xyz>
Cc: Alexander Lakhin <exclusion@gmail.com>, pgsql-bugs@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CABPTF7Vg1CTf49c4gvYu-6-0h7LNSqgWe5_%2B63FcmTgeqseK1w%40mail.gmail.com>
Precedence: bulk

On Mon, Jun 8, 2026 at 1:49=E2=80=AFPM Michael Paquier <michael@paquier.xyz=
> wrote:
>
> On Sat, Jun 06, 2026 at 08:45:26PM +0800, Xuneng Zhou wrote:
> > Sorry for being late. One nit for the patch -- would it be better to
> > use AmWalSenderProcess() for identification to save the include?
> > +#include "replication/walsender.h"
>
> In the startup sequence, MyBackendType is updated to B_WAL_SENDER a
> couple of lines after am_walsender.  One or the other don't really
> matter; they're both right.

Yeah, both of them work well.  To use AmWalSenderProcess(), we would
need to include src/include/miscadmin.h, whereas using am_walsender
requires including =E2=80=9Creplication/walsender.h=E2=80=9D. I=E2=80=99m j=
ust wondering
whether using AmWalSenderProcess() would result in less coupling
between pgstat and replication.


--
Regards,
Xuneng Zhou
HighGo Software Co., Ltd.