public inbox for [email protected]  

help / color / mirror / Atom feed

From: Xuneng Zhou <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Alexander Lakhin <[email protected]>
Cc: [email protected]
Subject: Re: BUG #18158: Assert in pgstat_report_stat() fails when a backend shutting down with stats pending
Date: Thu, 14 May 2026 15:19:34 +0800
Message-ID: <CABPTF7VgzdBP_ZPKf2eZ79ry0fVKzcgCkB5gy60HGXCy0EQb0w@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<CABPTF7XdDoLAoLKo7pOHmSqHniHf46Pw8Z=iqNx2uYi4J5ixBA@mail.gmail.com>
	<[email protected]>

On Wed, May 13, 2026 at 2:55 PM Michael Paquier <[email protected]> wrote:
>
> On Wed, May 13, 2026 at 08:46:25AM +0800, Xuneng Zhou wrote:
> > Thanks for reporting this. It appears like backpatching an equivalent
> > of 87a6690cc69 to REL_17/REL_16 would resolve this issue.
>
> FWIW, I fear such a change in the stable branches based on its
> invasiveness, particularly because the area of the code dealing with
> shutdown sequences has been reworked a lot lately as far as I recall.
>
> I am seriously wondering if we should just let it go and remove the
> assertion on v15~v17.  It's not perfect, of course, but I value much
> more this assertion in terms of any future work that can be done with
> pgstats, not in terms of what we could detect for bug fixes.

I agree that applying the change wholesale could be too invasive. If
we decide not to address the ordering issue, removing this assertion
seems reasonable, since the non-assert path does not actually provide
the required guarantee.

-- 
Regards,
Xuneng Zhou
HighGo Software Co., Ltd.

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: BUG #18158: Assert in pgstat_report_stat() fails when a backend shutting down with stats pending
  In-Reply-To: <CABPTF7VgzdBP_ZPKf2eZ79ry0fVKzcgCkB5gy60HGXCy0EQb0w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox