MIME-Version: 1.0
References: <19006-80fcaaf69000377e@postgresql.org> <CABPTF7VaW0Hw2-KXoiYFTH40LeUgr06gE5q09sq9LXQPH-vjPA@mail.gmail.com>
 <CA+hUKGK5x5Yekufz7a+Jr1neahwE9cLZn9xt3gSzSZgE=Spjpw@mail.gmail.com> <CA+hUKGJyqwQs_kQFB1J=bx4pHMrMcPF8_PgNKyeNFEo+yNvyiQ@mail.gmail.com>
In-Reply-To: <CA+hUKGJyqwQs_kQFB1J=bx4pHMrMcPF8_PgNKyeNFEo+yNvyiQ@mail.gmail.com>
From: Xuneng Zhou <xunengzhou@gmail.com>
Date: Thu, 7 Aug 2025 23:09:34 +0800
Message-ID: <CABPTF7WmR2E+1hAS1ZagBi4c23q6jdRJ8wh1q7XK2Cb2JZYVdw@mail.gmail.com>
Subject: Re: BUG #19006: Assert(BufferIsPinned) in BufferGetBlockNumber() is
 triggered for forwarded buffer
To: Thomas Munro <thomas.munro@gmail.com>
Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org, 
	Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CABPTF7WmR2E%2B1hAS1ZagBi4c23q6jdRJ8wh1q7XK2Cb2JZYVdw%40mail.gmail.com>
Precedence: bulk

Hi,

On Tue, Aug 5, 2025 at 12:29=E2=80=AFPM Thomas Munro <thomas.munro@gmail.co=
m> wrote:
>
> Here's my proposed fix.  Great reproducer, Alexander, thanks!

I tested the fix, it works well now. I tried to review the code logic
but found it hard to figure out this line on my own due to the
unfamiliarity with this module currently:

stream->buffers[stream->queue_size + stream->oldest_buffer_index] =3D

                InvalidBuffer;

Could you please elaborate on it a little bit more? Thanks.

Best,
Xuneng