MIME-Version: 1.0
References: <7bdbe559-d61a-4ae4-a6e1-48abdf3024cc@postgrespro.ru>
 <0FDE2089-D306-4CBB-AD1F-EC4B419E3B33@yandex-team.ru> <e6d20179-ddbd-3376-a7f5-4831df7d6b60@gmail.com>
 <49BBA065-4C9A-4E50-9048-B457907FF219@yandex-team.ru> <76bc0dc9-4e43-4cd8-8eec-249b254ed1c9@postgrespro.ru>
In-Reply-To: <76bc0dc9-4e43-4cd8-8eec-249b254ed1c9@postgrespro.ru>
From: jian he <jian.universality@gmail.com>
Date: Tue, 23 Jan 2024 08:00:00 +0800
Message-ID: <CACJufxFZcOTrq-NpFs7wErSh2KX4KePD7MuiF6d_h4nD=OJJKA@mail.gmail.com>
Subject: Re: [BUG] false positive in bt_index_check in case of short 4B
 varlena datum
To: Michael Zhilin <m.zhilin@postgrespro.ru>
Cc: "Andrey M. Borodin" <x4mmm@yandex-team.ru>, Alexander Lakhin <exclusion@gmail.com>, pgsql-bugs@postgresql.org, 
	y sokolov <y.sokolov@postgrespro.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CACJufxFZcOTrq-NpFs7wErSh2KX4KePD7MuiF6d_h4nD%3DOJJKA%40mail.gmail.com>
Precedence: bulk

On Wed, Jan 10, 2024 at 1:59=E2=80=AFAM Michael Zhilin <m.zhilin@postgrespr=
o.ru> wrote:
>
> Hi,
>
> Thank you, Andrey, for review and advice!
>
> Here is rebased version (v2) of patch supposed to make CF bot happy.

Hi

+--
+-- BUG: must support different header size of short varlena datum
+--
+
+CREATE TABLE varlena_bug (v text);
+ALTER TABLE varlena_bug ALTER column v SET storage plain;
+INSERT INTO varlena_bug VALUES ('x');
+\set filename :abs_builddir '/results/varlena_bug.dmp'
+COPY varlena_bug TO :'filename';
+COPY varlena_bug FROM :'filename';
+CREATE INDEX varlena_bug_idx on varlena_bug(v);
+SELECT bt_index_check('varlena_bug_idx', true);

you can simply replace
+\set filename :abs_builddir '/results/varlena_bug.dmp'
+COPY varlena_bug TO :'filename';
+COPY varlena_bug FROM :'filename';

with

COPY varlena_bug from stdin;
x
\.


In the comments, adding the postgres link
(https://postgr.es/m/7bdbe559-d61a-4ae4-a6e1-48abdf3024cc@postgrespro.ru)
would be great.