MIME-Version: 1.0
References: <aTDWg-ezihyoelN3@paquier.xyz> <CACTYHzimf5+6gp6HzCerZpWh4o2_TW6-S3k3+2YK5mnoQa-+tg@mail.gmail.com>
 <aTIqMdS7QPdkcT29@paquier.xyz> <CACTYHzihgbTyYNQsEGcYmfkPd79r+_Jiz+PhN1xW+3NoJGEhyQ@mail.gmail.com>
 <aTeioHWzG2Wrwfcf@paquier.xyz> <4423e01f-1e52-4f47-a6ca-05cc8081c888@eisentraut.org>
 <aTfA-NG02qbk_uFD@paquier.xyz> <CACTYHzgb=1UXNoW08AjBBUB10dZPoAg4pptFm3K63V5xs=j=Jw@mail.gmail.com>
 <CAN55FZ03oW7zGiCgLfeiRxDQ5NLbyrppP1=mFpQ7QoDkbs84JA@mail.gmail.com>
 <aTisqa86tuhsr8uP@paquier.xyz> <aTkBr1-x_vGRkbFj@paquier.xyz> <CAN55FZ22rrN6gCn7urtmTR=_5z7ArZLUJu-TsMChdXwmRTaquA@mail.gmail.com>
In-Reply-To: <CAN55FZ22rrN6gCn7urtmTR=_5z7ArZLUJu-TsMChdXwmRTaquA@mail.gmail.com>
From: VASUKI M <vasukim1992002@gmail.com>
Date: Wed, 18 Feb 2026 09:49:47 +0530
Message-ID: <CACTYHzg=W-D06q2c8jdNi7r9EA+urDVi0zoGTyrY3Q3eA_9P-A@mail.gmail.com>
Subject: Re: BUG #19095: Test if function exit() is used fail when linked static
To: Nazir Bilal Yavuz <byavuz81@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Peter Eisentraut <peter@eisentraut.org>, 
	Daniel Gustafsson <daniel@yesql.se>, Tom Lane <tgl@sss.pgh.pa.us>, BharatDB <bharatdbpg@gmail.com>, 
	torsten.rupp@gmx.net, pgsql-bugs@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000000bb2c0064b117ff9"
Archived-At: <https://www.postgresql.org/message-id/CACTYHzg%3DW-D06q2c8jdNi7r9EA%2BurDVi0zoGTyrY3Q3eA_9P-A%40mail.gmail.com>
Precedence: bulk

--0000000000000bb2c0064b117ff9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Nazir,

Thank you for pointing this out, and thanks to Andres for the clarification
in the referenced thread.

You are absolutely right =E2=80=94 with a stamp file, we need to ensure tha=
t its
timestamp is updated unconditionally so that it remains newer than the
inputs. Keeping the existence check (if (! -f ...)) would indeed leave the
stamp file older than the rebuilt library, which can trigger unnecessary
rebuilds in Makefile-based builds.

Although Ninja avoids repeated rebuilds due to its internal tracking, Make
relies purely on timestamps, so the safer and correct behavior is to always
recreate (touch) the stamp file.

The updated implementation without the existence check is therefore the
correct approach.

Regards,
Vasuki M
C-DAC,chennai

--0000000000000bb2c0064b117ff9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Nazir,<br><br>Thank you for pointing this out, and than=
ks to Andres for the clarification in the referenced thread.<br><br>You are=
 absolutely right =E2=80=94 with a stamp file, we need to ensure that its t=
imestamp is updated unconditionally so that it remains newer than the input=
s. Keeping the existence check (if (! -f ...)) would indeed leave the stamp=
 file older than the rebuilt library, which can trigger unnecessary rebuild=
s in Makefile-based builds.<br><br>Although Ninja avoids repeated rebuilds =
due to its internal tracking, Make relies purely on timestamps, so the safe=
r and correct behavior is to always recreate (touch) the stamp file.<br><br=
>The updated implementation without the existence check is therefore the co=
rrect approach.<br><br>Regards,<br>Vasuki M<br>C-DAC,chennai</div>

--0000000000000bb2c0064b117ff9--