MIME-Version: 1.0
References: <aSZ3RUjc7BVE6-9j@paquier.xyz> <CACTYHzjbVeKV289+TB1mg+tVmpnOJWrtezTvRjUwYoc875p1XA@mail.gmail.com>
 <CACTYHzjjssid_jtZiLh8BTYHAvnxbSLXceyGtxM3NB6Kfv510g@mail.gmail.com>
 <22D3D4EC-BCC3-4E52-B5A9-E1C6E363517B@yesql.se> <aTDWg-ezihyoelN3@paquier.xyz>
 <CACTYHzimf5+6gp6HzCerZpWh4o2_TW6-S3k3+2YK5mnoQa-+tg@mail.gmail.com>
 <aTIqMdS7QPdkcT29@paquier.xyz> <CACTYHzihgbTyYNQsEGcYmfkPd79r+_Jiz+PhN1xW+3NoJGEhyQ@mail.gmail.com>
 <aTeioHWzG2Wrwfcf@paquier.xyz> <4423e01f-1e52-4f47-a6ca-05cc8081c888@eisentraut.org>
 <aTfA-NG02qbk_uFD@paquier.xyz>
In-Reply-To: <aTfA-NG02qbk_uFD@paquier.xyz>
From: VASUKI M <vasukim1992002@gmail.com>
Date: Tue, 9 Dec 2025 15:53:23 +0530
Message-ID: <CACTYHzgb=1UXNoW08AjBBUB10dZPoAg4pptFm3K63V5xs=j=Jw@mail.gmail.com>
Subject: Re: BUG #19095: Test if function exit() is used fail when linked static
To: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter@eisentraut.org>, Daniel Gustafsson <daniel@yesql.se>, Tom Lane <tgl@sss.pgh.pa.us>, 
	BharatDB <bharatdbpg@gmail.com>, torsten.rupp@gmx.net, 
	pgsql-bugs@lists.postgresql.org, byavuz81@gmail.com
Content-Type: multipart/alternative; boundary="0000000000005b17570645824c3c"
Archived-At: <https://www.postgresql.org/message-id/CACTYHzgb%3D1UXNoW08AjBBUB10dZPoAg4pptFm3K63V5xs%3Dj%3DJw%40mail.gmail.com>
Precedence: bulk

--0000000000005b17570645824c3c
Content-Type: text/plain; charset="UTF-8"

Thanks Michael and Peter for the detailed reviews and for taking the time
to refine and commit the updated version.

Thanks for pointing out that pgperltidy may behave differently across
environments.

On Tue, 9 Dec 2025 at 11:56, Michael Paquier <michael@paquier.xyz> wrote:

> The attached takes care of the issue here.  Adding that to pgxs_bins
> may look adapted at first glance, but I don't quite see the point in
> exposing this information to PGXS, so pgxs_empty is a better fit?
>
> Thanks for the clarification.Given that PGXS extensions don't appear to
require NM ,IMO adding it to pgxs_empty makes sense to me.It resolves the
Meson warning without exposing unnecessary variables to PGXS users.

Regards,
Vasuki M

--0000000000005b17570645824c3c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><p>Thanks Michael and Peter for the detai=
led reviews and for taking the time to refine and commit the updated versio=
n.</p><p>
</p><p></p><p></p><p>Thanks for pointing out that pgperltidy may behave dif=
ferently across environments.<br></p><p>On Tue, 9 Dec 2025 at 11:56, Michae=
l Paquier &lt;<a href=3D"mailto:michael@paquier.xyz">michael@paquier.xyz</a=
>&gt; wrote:</p></div><div class=3D"gmail_quote gmail_quote_container"><blo=
ckquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left=
:1px solid rgb(204,204,204);padding-left:1ex">
The attached takes care of the issue here.=C2=A0 Adding that to pgxs_bins<b=
r>
may look adapted at first glance, but I don&#39;t quite see the point in<br=
>
exposing this information to PGXS, so pgxs_empty is a better fit?<br><br></=
blockquote><div>Thanks for the clarification.Given that PGXS extensions don=
&#39;t appear to require NM ,IMO adding it to pgxs_empty makes sense=C2=A0t=
o me.It resolves the Meson warning without exposing unnecessary variables t=
o PGXS users.<br><br></div>Regards,<br><div>Vasuki M</div></div></div>

--0000000000005b17570645824c3c--