MIME-Version: 1.0
References: <CAN55FZ2em+Wf6kWQ27bwQrLTTWJF7TcSDDKnjxGy+fxMVaGbvg@mail.gmail.com>
 <aSTRj99MkyI5zr0y@paquier.xyz> <CACTYHzhCNsee-4xv-HDhw8zmMWByB7YHLuUHh-bsztgZ94ewpw@mail.gmail.com>
 <483765ED-0490-4972-9769-4943716BE204@yesql.se> <aSZ3RUjc7BVE6-9j@paquier.xyz>
 <CACTYHzjbVeKV289+TB1mg+tVmpnOJWrtezTvRjUwYoc875p1XA@mail.gmail.com>
 <CACTYHzjjssid_jtZiLh8BTYHAvnxbSLXceyGtxM3NB6Kfv510g@mail.gmail.com>
 <22D3D4EC-BCC3-4E52-B5A9-E1C6E363517B@yesql.se> <aTDWg-ezihyoelN3@paquier.xyz>
 <CACTYHzimf5+6gp6HzCerZpWh4o2_TW6-S3k3+2YK5mnoQa-+tg@mail.gmail.com> <aTIqMdS7QPdkcT29@paquier.xyz>
In-Reply-To: <aTIqMdS7QPdkcT29@paquier.xyz>
From: VASUKI M <vasukim1992002@gmail.com>
Date: Mon, 8 Dec 2025 10:11:08 +0530
Message-ID: <CACTYHzihgbTyYNQsEGcYmfkPd79r+_Jiz+PhN1xW+3NoJGEhyQ@mail.gmail.com>
Subject: Re: BUG #19095: Test if function exit() is used fail when linked static
To: Michael Paquier <michael@paquier.xyz>
Cc: Daniel Gustafsson <daniel@yesql.se>, Tom Lane <tgl@sss.pgh.pa.us>, BharatDB <bharatdbpg@gmail.com>, 
	torsten.rupp@gmx.net, pgsql-bugs@lists.postgresql.org, byavuz81@gmail.com
Content-Type: multipart/alternative; boundary="0000000000006f9175064569665f"
Archived-At: <https://www.postgresql.org/message-id/CACTYHzihgbTyYNQsEGcYmfkPd79r%2B_Jiz%2BPhN1xW%2B3NoJGEhyQ%40mail.gmail.com>
Precedence: bulk

--0000000000006f9175064569665f
Content-Type: text/plain; charset="UTF-8"

Hi Michael,

Thanks for checking the v6 patch.

Regarding the whitespace comment - I had already ran the pgperltidy on the
perl
script libpq-check.pl before  sending the patch,and I also verified the tab
indentation
with cat -T  to ensure the tabs were being used.FS,The current version of
the scripts in
v6 should already follow the standard pgindent/pgperltidy formatting

If there is still any specific section that appears mis-indented on your
side,
please let me know and I will adjust it.

cdac@cdac-Aspire-Lite-AL15-41:~/pg-libpq$ src/tools/pgindent/pgperltidy
src/interfaces/libpq/libpq-check.pl

cdac@cdac-Aspire-Lite-AL15-41:~/pg-libpq$

cdac@cdac-Aspire-Lite-AL15-41:~/pg-libpq$ cat -T src/interfaces/libpq/
libpq-check.pl
#!/usr/bin/perl
#
# src/interfaces/libpq/libpq-check.pl
#
# Copyright (c) 2025, PostgreSQL Global Development Group
#
# Check that the state of a libpq library.  Currently, this script checks
# that exit() is not called, because client libraries must not terminate
# the host application.
#
# This script is called by both Makefile and Meson.

use strict;
use warnings FATAL => 'all';

use Getopt::Long;
use Config;

my $nm_path;
my $input_file;
my $stamp_file;
my @problematic_lines;

Getopt::Long::GetOptions(
^I'nm:s' => \$nm_path,
^I'input_file:s' => \$input_file,
^I'stamp_file:s' => \$stamp_file) or die "$0: wrong arguments\n";

die "$0: --input_file must be specified\n" unless defined $input_file;
die "$0: --nm must be specified\n" unless defined $nm_path and -x $nm_path;

sub create_stamp_file
{
^Iif (!(-f $stamp_file))
^I{
^I^Iopen my $fh, '>', $stamp_file
^I^I  or die "can't open $stamp_file: $!";
^I^Iclose $fh;
^I}
}

# ---- Skip on Windows and Solaris ----
if (   $Config{osname} =~ /MSWin32|cygwin|msys/i
^I|| $Config{osname} =~ /solaris/i)
{
^Iexit 0;
}

# Run nm to scan for symbols.  If nm fails at runtime, skip the check.
open my $fh, '-|', "$nm_path -A -u $input_file 2>/dev/null"
  or exit 0;

while (<$fh>)
{

^I# Set of symbols allowed:
^I#     __cxa_atexit     - injected by some libcs (e.g., OpenBSD)
^I#     __tsan_func_exit - ThreadSanitizer instrumentation
^I#     pthread_exit     - legitimate thread cleanup

^Inext if /__cxa_atexit/;
^Inext if /__tsan_func_exit/;
^Inext if /pthread_exit/;

^I# Anything containing "exit" is suspicious.
^I# (Ideally we should reject abort() too, but there are various scenarios
^I# where build toolchains insert abort() calls, e.g. to implement
assert().)
^Iif (/exit/)
^I{
^I^Ipush @problematic_lines, $_;
^I}
}
close $fh;

if (@problematic_lines)
{
^Iprint "libpq must not be calling any function which invokes exit\n";
^Iprint "Problematic symbol references:\n";
^Iprint @problematic_lines;

^Iexit 1;
}

# Create stamp file, if required
if (defined($stamp_file))
{
^Icreate_stamp_file();
}

exit 0;
cdac@cdac-Aspire-Lite-AL15-41:~/pg-libpq$

Regards,

Vasuki

--0000000000006f9175064569665f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Michael,<br><br>Thanks for checking the v6 patch.<div><=
br><div>Regarding the whitespace comment - I had already ran the pgperltidy=
=C2=A0on the perl</div><div>script <a href=3D"http://libpq-check.pl">libpq-=
check.pl</a> before=C2=A0 sending the patch,and I also verified the tab ind=
entation=C2=A0</div><div>with cat -T=C2=A0 to ensure the tabs were being us=
ed.FS,The current version of the scripts in=C2=A0</div><div>v6 should alrea=
dy follow the standard pgindent/pgperltidy=C2=A0formatting<br><div><div><br=
>If there is still any specific section that appears mis-indented on your s=
ide,<br>please let me know and I will adjust it.<br><br>cdac@cdac-Aspire-Li=
te-AL15-41:~/pg-libpq$ src/tools/pgindent/pgperltidy src/interfaces/libpq/<=
a href=3D"http://libpq-check.pl">libpq-check.pl</a><br><br>cdac@cdac-Aspire=
-Lite-AL15-41:~/pg-libpq$<br><br>cdac@cdac-Aspire-Lite-AL15-41:~/pg-libpq$ =
cat -T src/interfaces/libpq/<a href=3D"http://libpq-check.pl">libpq-check.p=
l</a><br>#!/usr/bin/perl<br>#<br># src/interfaces/libpq/<a href=3D"http://l=
ibpq-check.pl">libpq-check.pl</a><br>#<br># Copyright (c) 2025, PostgreSQL =
Global Development Group<br>#<br># Check that the state of a libpq library.=
=C2=A0 Currently, this script checks<br># that exit() is not called, becaus=
e client libraries must not terminate<br># the host application.<br>#<br># =
This script is called by both Makefile and Meson.<br><br>use strict;<br>use=
 warnings FATAL =3D&gt; &#39;all&#39;;<br><br>use Getopt::Long;<br>use Conf=
ig;<br><br>my $nm_path;<br>my $input_file;<br>my $stamp_file;<br>my @proble=
matic_lines;<br><br>Getopt::Long::GetOptions(<br>^I&#39;nm:s&#39; =3D&gt; \=
$nm_path,<br>^I&#39;input_file:s&#39; =3D&gt; \$input_file,<br>^I&#39;stamp=
_file:s&#39; =3D&gt; \$stamp_file) or die &quot;$0: wrong arguments\n&quot;=
;<br><br>die &quot;$0: --input_file must be specified\n&quot; unless define=
d $input_file;<br>die &quot;$0: --nm must be specified\n&quot; unless defin=
ed $nm_path and -x $nm_path;<br><br>sub create_stamp_file<br>{<br>^Iif (!(-=
f $stamp_file))<br>^I{<br>^I^Iopen my $fh, &#39;&gt;&#39;, $stamp_file<br>^=
I^I =C2=A0or die &quot;can&#39;t open $stamp_file: $!&quot;;<br>^I^Iclose $=
fh;<br>^I}<br>}<br><br># ---- Skip on Windows and Solaris ----<br>if ( =C2=
=A0 $Config{osname} =3D~ /MSWin32|cygwin|msys/i<br>^I|| $Config{osname} =3D=
~ /solaris/i)<br>{<br>^Iexit 0;<br>}<br><br># Run nm to scan for symbols.=
=C2=A0 If nm fails at runtime, skip the check.<br>open my $fh, &#39;-|&#39;=
, &quot;$nm_path -A -u $input_file 2&gt;/dev/null&quot;<br>=C2=A0 or exit 0=
;<br><br>while (&lt;$fh&gt;)<br>{<br><br>^I# Set of symbols allowed:<br>^I#=
 =C2=A0 =C2=A0 __cxa_atexit =C2=A0 =C2=A0 - injected by some libcs (e.g., O=
penBSD)<br>^I# =C2=A0 =C2=A0 __tsan_func_exit - ThreadSanitizer instrumenta=
tion<br>^I# =C2=A0 =C2=A0 pthread_exit =C2=A0 =C2=A0 - legitimate thread cl=
eanup<br><br>^Inext if /__cxa_atexit/;<br>^Inext if /__tsan_func_exit/;<br>=
^Inext if /pthread_exit/;<br><br>^I# Anything containing &quot;exit&quot; i=
s suspicious.<br>^I# (Ideally we should reject abort() too, but there are v=
arious scenarios<br>^I# where build toolchains insert abort() calls, e.g. t=
o implement assert().)<br>^Iif (/exit/)<br>^I{<br>^I^Ipush @problematic_lin=
es, $_;<br>^I}<br>}<br>close $fh;<br><br>if (@problematic_lines)<br>{<br>^I=
print &quot;libpq must not be calling any function which invokes exit\n&quo=
t;;<br>^Iprint &quot;Problematic symbol references:\n&quot;;<br>^Iprint @pr=
oblematic_lines;<br><br>^Iexit 1;<br>}<br><br># Create stamp file, if requi=
red<br>if (defined($stamp_file))<br>{<br>^Icreate_stamp_file();<br>}<br><br=
>exit 0;<br>cdac@cdac-Aspire-Lite-AL15-41:~/pg-libpq$<br><br>Regards,<br><b=
r>Vasuki<br><br></div></div></div></div></div>

--0000000000006f9175064569665f--