MIME-Version: 1.0
References: <b97f1850-fc7b-43c4-9b04-4e97bb9e7dc0@gmail.com>
 <CAD21AoBVEcC5stzLr80RgaWuBh0EoyRQys_aeOz0ceogMVREcQ@mail.gmail.com> <cb7a4bad-007a-4bbe-8e4b-8ce8109c6e93@gmail.com>
In-Reply-To: <cb7a4bad-007a-4bbe-8e4b-8ce8109c6e93@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Thu, 16 Apr 2026 01:11:47 -0700
Message-ID: <CAD21AoC86nuoxy4r6G3_Ysb2y3K+0sybznRkjVq=Yc4URZUN4g@mail.gmail.com>
Subject: Re: TRAP: failed Assert("offsets[i] > offsets[i - 1]"), File: "tidstore.c"
To: Andrei Lepikhov <lepihov@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAD21AoC86nuoxy4r6G3_Ysb2y3K%2B0sybznRkjVq%3DYc4URZUN4g%40mail.gmail.com>
Precedence: bulk

On Thu, Apr 16, 2026 at 12:13=E2=80=AFAM Andrei Lepikhov <lepihov@gmail.com=
> wrote:
>
> On 15/04/2026 22:50, Masahiko Sawada wrote:
> > On Wed, Apr 15, 2026 at 5:48=E2=80=AFAM Andrei Lepikhov <lepihov@gmail.=
com> wrote:
> > Could you provide the reproducer of the assertion failure? IIRC there
> > have not been such reports on the community so far and the test should
> > be included in the patch anyway.
> Sure! See in attachment.

Thank you for updating the patch.

IIUC the assertion failure could happen only where we do random TIDs
test like below because it's not guaranteed that the offset numbers in
the array after applying DISTICT are sorted.

-- Random TIDs test. The offset numbers are randomized and must be --
unique and ordered. INSERT INTO hideblocks (blockno) SELECT
do_set_block_offsets(blkno, array_agg(DISTINCT greatest((random() *
:maxoffset)::int, 1))::int2[]) FROM generate_series(1, 100)
num_offsets, generate_series(1000, 1100, 1) blkno GROUP BY blkno;

While I agree that we need to sort the offset numbers, I think it
would be better to make sure the offset numbers in the array to be
sorted in a test_tidstore.sql file where required, instead of doing so
for all cases.

Regards,

--=20
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com