MIME-Version: 1.0
References: <fddd1cd6-dc16-40a2-9eb5-d7fef2101488@technowledgy.de>
 <2852940.1710599083@sss.pgh.pa.us>
 <443da167-ee01-47d2-9c83-105694b4cbd5@technowledgy.de>
 <CA+hUKGJhp0opkCybdOrbQSMyHX8cRuLh2ygkqtivizCqK6kfOA@mail.gmail.com>
 <CA+hUKGL=CE7Gg5p7ijbtEWhnPR-Ua4gemhuz-kQpSy3dD1+SYQ@mail.gmail.com>
 <ef1b47df-0808-4bd7-b08c-5153d5d75f4c@technowledgy.de>
 <68C88EE3-CDCB-4993-9173-3A773F491F3A@thebuild.com>
 <855a1b16-0dc0-42b2-8f90-79eb49cf2893@technowledgy.de>
 <F5A214FF-1BED-4935-B4FF-4679CCF463D6@thebuild.com>
In-Reply-To: <F5A214FF-1BED-4935-B4FF-4679CCF463D6@thebuild.com>
From: Andrew Dunstan <andrew@dunslane.net>
Date: Sun, 17 Mar 2024 16:33:40 -0400
Message-ID: 
 <CAD5tBcLWM+QT0+VKWUHiBX2Ey5eCc8jVL5APb1U5iaePV_eAvg@mail.gmail.com>
Subject: Re: Regression tests fail with musl libc because libpq.so can't be
 loaded
To: Christophe Pettus <xof@thebuild.com>
Cc: Wolfgang Walther <walther@technowledgy.de>,
 Thomas Munro <thomas.munro@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>,
 PostgreSQL Bugs <pgsql-bugs@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000af4aa20613e12855"
Archived-At: 
 <https://www.postgresql.org/message-id/CAD5tBcLWM%2BQT0%2BVKWUHiBX2Ey5eCc8jVL5APb1U5iaePV_eAvg%40mail.gmail.com>
Precedence: bulk

--000000000000af4aa20613e12855
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 17, 2024 at 11:45=E2=80=AFAM Christophe Pettus <xof@thebuild.co=
m> wrote:

>
>
> > On Mar 17, 2024, at 06:11, Wolfgang Walther <walther@technowledgy.de>
> wrote:
> > The missing macro is on purpose and unlikely to change:
> https://openwall.com/lists/musl/2013/03/29/13
>
> Indeed.
>

That seems a little shortsighted. If other libc implementations find it
appropriate to have similar macros why should they be different?


> > I also found this thread, which discusses exactly our case:
> https://www.openwall.com/lists/musl/2022/08/17/1
>
> While getting proper setproctitle functionality on musl would be great, m=
y
> goal was more modest: Have it correctly set PS_USE_NONE when compiling
> against musl.
>

One simple thing might be for us to enclose the block in ps_status.c at
lines 49-59 in #ifndef PS_USE_NONE/#endif. Then you could compile with
-DPS_USE_NONE in your CPPFLAGS.

cheers

andrew

--000000000000af4aa20613e12855
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Sun, Mar 17, 2024 at 11:45=E2=80=
=AFAM Christophe Pettus &lt;<a href=3D"mailto:xof@thebuild.com">xof@thebuil=
d.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:=
1ex"><br>
<br>
&gt; On Mar 17, 2024, at 06:11, Wolfgang Walther &lt;<a href=3D"mailto:walt=
her@technowledgy.de" target=3D"_blank">walther@technowledgy.de</a>&gt; wrot=
e:<br>
&gt; The missing macro is on purpose and unlikely to change: <a href=3D"htt=
ps://openwall.com/lists/musl/2013/03/29/13" rel=3D"noreferrer" target=3D"_b=
lank">https://openwall.com/lists/musl/2013/03/29/13</a><br>
<br>
Indeed.<br></blockquote><div><br></div><div>That seems a little shortsighte=
d. If other libc implementations find it appropriate to have similar macros=
 why should they be different?=C2=A0 <br></div><div><br></div><blockquote c=
lass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px soli=
d rgb(204,204,204);padding-left:1ex">
<br>
&gt; I also found this thread, which discusses exactly our case: <a href=3D=
"https://www.openwall.com/lists/musl/2022/08/17/1" rel=3D"noreferrer" targe=
t=3D"_blank">https://www.openwall.com/lists/musl/2022/08/17/1</a><br>
<br>
While getting proper setproctitle functionality on musl would be great, my =
goal was more modest: Have it correctly set PS_USE_NONE when compiling agai=
nst musl.<br></blockquote><div><br></div><div>One simple thing might be for=
 us to enclose the block in ps_status.c at lines 49-59 in #ifndef PS_USE_NO=
NE/#endif. Then you could compile with -DPS_USE_NONE in your CPPFLAGS. <br>=
</div><div><br></div><div>cheers</div><div><br></div><div>andrew<br></div><=
/div></div>

--000000000000af4aa20613e12855--