public inbox for [email protected]
help / color / mirror / Atom feedFrom: Srinath Reddy Sadipiralla <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: yanliang lei <[email protected]>
Cc: [email protected]
Subject: Re: Re: Re: BUG #19351: in pg18.1,when not null exists in the table , and add constraint problem.
Date: Sun, 14 Dec 2025 22:30:16 +0530
Message-ID: <CAFC+b6o75trAiX95J3GnX-UaAD+MiPvRdGDYy7P=npDQr5sUbw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
Hi Álvaro,
On Sat, Dec 13, 2025 at 6:14 PM Álvaro Herrera <[email protected]> wrote:
>
> Yeah, that's fair -- we discussed this kind of behavior during
> development and I was unsure about being strict about it, so avoided it.
>
>
+1 , thanks for the patch.
This is mostly straightforward to fix, as attached (though the error
> message needs work),
I have reviewed the patch except the below things and
LGTM until now.
> but I hit a snag with multiple inheritance -- if
> you apply this patch, you'll see failures in the pg_dump and pg_upgrade
> tests. I don't have any ideas to fix this right now, but I'll keep
> thinking about it.
>
I need to look further into these parts,and will update once
I have something solid.
--
Thanks,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Re: Re: BUG #19351: in pg18.1,when not null exists in the table , and add constraint problem.
In-Reply-To: <CAFC+b6o75trAiX95J3GnX-UaAD+MiPvRdGDYy7P=npDQr5sUbw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox