MIME-Version: 1.0
References: <add10bd7-d351-4630-858b-b9b77144f0a9@app.fastmail.com>
 <ah2296X21zeqsylc@alvherre.pgsql>
 <CAFC+b6rpgFUUiU5z_YbF3GJStNqO2Pf7eW96txw=JtEe=_WPzw@mail.gmail.com>
 <33766.1780471821@localhost>
In-Reply-To: <33766.1780471821@localhost>
From: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Date: Wed, 3 Jun 2026 15:55:18 +0530
Message-ID: 
 <CAFC+b6qY8Jr1OkRqRX0KOy6-yauGwKTrw-OhQooYgzpyCwhgTA@mail.gmail.com>
Subject: Re: BUG #19500: pgrepack logical decoding plugin can crash assert
 builds via SQL decoding API
To: Antonin Houska <ah@cybertec.at>
Cc: alvherre@kurilemu.de, n.kalinin@postgrespro.ru,
	pgsql-bugs@lists.postgresql.org, b@ida.kurilemu.internal
Content-Type: multipart/mixed; boundary="000000000000cf5181065356d869"
Archived-At: 
 <https://www.postgresql.org/message-id/CAFC%2Bb6qY8Jr1OkRqRX0KOy6-yauGwKTrw-OhQooYgzpyCwhgTA%40mail.gmail.com>
Precedence: bulk

--000000000000cf5181065356d869
Content-Type: multipart/alternative; boundary="000000000000cf5181065356d867"

--000000000000cf5181065356d867
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 3, 2026 at 1:00=E2=80=AFPM Antonin Houska <ah@cybertec.at> wrot=
e:

> Srinath Reddy Sadipiralla <srinath2133@gmail.com> wrote:
>
> > Could we reject the pgrepack plugin at slot creation instead, in
> > pg_create_logical_replication_slot() and the CREATE_REPLICATION_SLOT
> > command, so misuse gets a clear "reserved for REPACK (CONCURRENTLY)"
> > error up front, before any decoding? REPACK creates its slot directly v=
ia
> > ReplicationSlotCreate(), so it's unaffected, and the begin-callback che=
ck
> > with magic guard can stay as the internal safety net.
> > Happy to be told this isn't worth special-casing :)
>
> Another possible approach: restrict the use of the plugin to the REPACK
> decoding worker.
>

cool ... that's cleaner, incorporated these changes and added test
,errcode.


--=20
Thanks :)
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/

--000000000000cf5181065356d867
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Jun 3, =
2026 at 1:00=E2=80=AFPM Antonin Houska &lt;<a href=3D"mailto:ah@cybertec.at=
">ah@cybertec.at</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" =
style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pa=
dding-left:1ex">Srinath Reddy Sadipiralla &lt;<a href=3D"mailto:srinath2133=
@gmail.com" target=3D"_blank">srinath2133@gmail.com</a>&gt; wrote:<br>
<br>
&gt; Could we reject the pgrepack plugin at slot creation instead, in<br>
&gt; pg_create_logical_replication_slot() and the CREATE_REPLICATION_SLOT<b=
r>
&gt; command, so misuse gets a clear &quot;reserved for REPACK (CONCURRENTL=
Y)&quot;<br>
&gt; error up front, before any decoding? REPACK creates its slot directly =
via<br>
&gt; ReplicationSlotCreate(), so it&#39;s unaffected, and the begin-callbac=
k check<br>
&gt; with magic guard can stay as the internal safety net.<br>
&gt; Happy to be told this isn&#39;t worth special-casing :)<br>
<br>
Another possible approach: restrict the use of the plugin to the REPACK<br>
decoding worker.<br></blockquote><div><br>cool ... that&#39;s cleaner, inco=
rporated these changes and added test<br>,errcode.</div></div><div><br clea=
r=3D"all"></div><div><br></div><span class=3D"gmail_signature_prefix">-- </=
span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><span =
style=3D"color:rgb(34,34,34)">Thanks :)</span><br style=3D"color:rgb(34,34,=
34)"><span style=3D"color:rgb(34,34,34)">Srinath Reddy Sadipiralla</span><b=
r style=3D"color:rgb(34,34,34)"><span style=3D"color:rgb(34,34,34)">EDB:=C2=
=A0</span><a href=3D"https://www.enterprisedb.com/" style=3D"color:rgb(17,8=
5,204)" target=3D"_blank">https://www.enterprisedb.com/</a></div></div></di=
v>

--000000000000cf5181065356d867--

--000000000000cf5181065356d869
Content-Type: application/octet-stream;
	name="v2-0002-Reject-the-pgrepack-output-plugin-outside-REPACK-CON.patch"
Content-Disposition: attachment;
	filename="v2-0002-Reject-the-pgrepack-output-plugin-outside-REPACK-CON.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mpxx6pd30>
X-Attachment-Id: f_mpxx6pd30

RnJvbSA5ZmZmM2RlODVkMGM3YzY3ZjI5ZmNlMjhmOWQzNjZkYjVhM2NmNDZhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTcmluYXRoIFJlZGR5IFNhZGlwaXJhbGxhIDxzcmluYXRoMjEz
M0BnbWFpbC5jb20+CkRhdGU6IFdlZCwgMyBKdW4gMjAyNiAxNTo0NTo0NyArMDUzMApTdWJqZWN0
OiBbUEFUQ0ggMS8xXSBSZWplY3QgdGhlIHBncmVwYWNrIG91dHB1dCBwbHVnaW4gb3V0c2lkZSBS
RVBBQ0sKIChDT05DVVJSRU5UTFkpCgpUaGUgcGdyZXBhY2sgb3V0cHV0IHBsdWdpbiBpcyBhbiBp
bnRlcm5hbCBjb21wb25lbnQgb2YgUkVQQUNLCihDT05DVVJSRU5UTFkpIGFuZCBpcyBub3QgbWVh
bnQgdG8gYmUgZHJpdmVuIHRocm91Z2ggdGhlIGdlbmVyaWMgbG9naWNhbApkZWNvZGluZyBpbnRl
cmZhY2UuCi0tLQogY29udHJpYi90ZXN0X2RlY29kaW5nL2V4cGVjdGVkL3JlcGFjay5vdXQgfCAg
NCArKysrCiBjb250cmliL3Rlc3RfZGVjb2Rpbmcvc3FsL3JlcGFjay5zcWwgICAgICB8ICA0ICsr
KysKIHNyYy9iYWNrZW5kL2NvbW1hbmRzL3JlcGFja193b3JrZXIuYyAgICAgIHwgIDQgKy0tLQog
c3JjL2JhY2tlbmQvcmVwbGljYXRpb24vbG9naWNhbC9sb2dpY2FsLmMgfCAxMiArKysrKysrKysr
KysKIHNyYy9pbmNsdWRlL2NvbW1hbmRzL3JlcGFjay5oICAgICAgICAgICAgIHwgIDIgKysKIDUg
ZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1n
aXQgYS9jb250cmliL3Rlc3RfZGVjb2RpbmcvZXhwZWN0ZWQvcmVwYWNrLm91dCBiL2NvbnRyaWIv
dGVzdF9kZWNvZGluZy9leHBlY3RlZC9yZXBhY2sub3V0CmluZGV4IDYyMDRlNjIwYjQzLi5jOWE3
YmNjN2RkYyAxMDA2NDQKLS0tIGEvY29udHJpYi90ZXN0X2RlY29kaW5nL2V4cGVjdGVkL3JlcGFj
ay5vdXQKKysrIGIvY29udHJpYi90ZXN0X2RlY29kaW5nL2V4cGVjdGVkL3JlcGFjay5vdXQKQEAg
LTk5LDUgKzk5LDkgQEAgUkVQQUNLIChDT05DVVJSRU5UTFkpIHJlcGFja19jb25jX3JlcGxpZGVu
dDsKIEVSUk9SOiAgY2Fubm90IGV4ZWN1dGUgUkVQQUNLIChDT05DVVJSRU5UTFkpIG9uIHJlbGF0
aW9uICJyZXBhY2tfY29uY19yZXBsaWRlbnQiCiBERVRBSUw6ICBSRVBBQ0sgKENPTkNVUlJFTlRM
WSkgZG9lcyBub3Qgc3VwcG9ydCBkZWZlcnJhYmxlIHByaW1hcnkga2V5cy4KIEhJTlQ6ICBVc2Ug
QUxURVIgVEFCTEUgLi4uIFJFUExJQ0EgSURFTlRJVFkgVVNJTkcgSU5ERVggdG8gZGVzaWduYXRl
IGFub3RoZXIgaW5kZXggYXMgcmVwbGljYSBpZGVudGl0eS4KKy0tIFRoZSAicGdyZXBhY2siIG91
dHB1dCBwbHVnaW4gaXMgaW50ZXJuYWwgdG8gUkVQQUNLIChDT05DVVJSRU5UTFkpOyBpdCBjYW5u
b3QKKy0tIGJlIHNlbGVjdGVkIHRocm91Z2ggdGhlIGdlbmVyaWMgbG9naWNhbCBkZWNvZGluZyBp
bnRlcmZhY2UgKGJ1ZyAjMTk1MDApLgorU0VMRUNUIHBnX2NyZWF0ZV9sb2dpY2FsX3JlcGxpY2F0
aW9uX3Nsb3QoJ3JlcGFja19taXN1c2Vfc2xvdCcsICdwZ3JlcGFjaycpOworRVJST1I6ICBUaGUg
InBncmVwYWNrIiBkZWNvZGVyIHBsdWdpbiBtYXkgb25seSBiZSBjYWxsZWQgYnkgUkVQQUNLIChD
T05DVVJSRU5UTFkpLgogLS0gY2xlYW4gdXAKIERST1AgVEFCTEUgcmVwYWNrX2NvbmNfcmVwbGlk
ZW50LCBjbHN0cnBhcnQ7CmRpZmYgLS1naXQgYS9jb250cmliL3Rlc3RfZGVjb2Rpbmcvc3FsL3Jl
cGFjay5zcWwgYi9jb250cmliL3Rlc3RfZGVjb2Rpbmcvc3FsL3JlcGFjay5zcWwKaW5kZXggY2Vh
M2JkMzM2ODkuLmE3Y2I2MTVlNTVkIDEwMDY0NAotLS0gYS9jb250cmliL3Rlc3RfZGVjb2Rpbmcv
c3FsL3JlcGFjay5zcWwKKysrIGIvY29udHJpYi90ZXN0X2RlY29kaW5nL3NxbC9yZXBhY2suc3Fs
CkBAIC03Myw1ICs3Myw5IEBAIFJFUEFDSyAoQ09OQ1VSUkVOVExZKSByZXBhY2tfY29uY19yZXBs
aWRlbnQ7CiBBTFRFUiBUQUJMRSByZXBhY2tfY29uY19yZXBsaWRlbnQgQUREIFBSSU1BUlkgS0VZ
IChpKSBERUZFUlJBQkxFOwogUkVQQUNLIChDT05DVVJSRU5UTFkpIHJlcGFja19jb25jX3JlcGxp
ZGVudDsKIAorLS0gVGhlICJwZ3JlcGFjayIgb3V0cHV0IHBsdWdpbiBpcyBpbnRlcm5hbCB0byBS
RVBBQ0sgKENPTkNVUlJFTlRMWSk7IGl0IGNhbm5vdAorLS0gYmUgc2VsZWN0ZWQgdGhyb3VnaCB0
aGUgZ2VuZXJpYyBsb2dpY2FsIGRlY29kaW5nIGludGVyZmFjZSAoYnVnICMxOTUwMCkuCitTRUxF
Q1QgcGdfY3JlYXRlX2xvZ2ljYWxfcmVwbGljYXRpb25fc2xvdCgncmVwYWNrX21pc3VzZV9zbG90
JywgJ3BncmVwYWNrJyk7CisKIC0tIGNsZWFuIHVwCiBEUk9QIFRBQkxFIHJlcGFja19jb25jX3Jl
cGxpZGVudCwgY2xzdHJwYXJ0OwpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvY29tbWFuZHMvcmVw
YWNrX3dvcmtlci5jIGIvc3JjL2JhY2tlbmQvY29tbWFuZHMvcmVwYWNrX3dvcmtlci5jCmluZGV4
IGYzZDI3MjBiMjQ2Li45ZWEzNjNmNWVhNCAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvY29tbWFu
ZHMvcmVwYWNrX3dvcmtlci5jCisrKyBiL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3JlcGFja193b3Jr
ZXIuYwpAQCAtMjgsOCArMjgsNiBAQAogI2luY2x1ZGUgInRjb3AvdGNvcHByb3QuaCIKICNpbmNs
dWRlICJ1dGlscy9tZW11dGlscy5oIgogCi0jZGVmaW5lIFJFUExfUExVR0lOX05BTUUgICAicGdy
ZXBhY2siCi0KIHN0YXRpYyB2b2lkIFJlcGFja1dvcmtlclNodXRkb3duKGludCBjb2RlLCBEYXR1
bSBhcmcpOwogc3RhdGljIExvZ2ljYWxEZWNvZGluZ0NvbnRleHQgKnJlcGFja19zZXR1cF9sb2dp
Y2FsX2RlY29kaW5nKE9pZCByZWxpZCk7CiBzdGF0aWMgdm9pZCByZXBhY2tfY2xlYW51cF9sb2dp
Y2FsX2RlY29kaW5nKExvZ2ljYWxEZWNvZGluZ0NvbnRleHQgKmN0eCk7CkBAIC0yNDYsNyArMjQ0
LDcgQEAgcmVwYWNrX3NldHVwX2xvZ2ljYWxfZGVjb2RpbmcoT2lkIHJlbGlkKQogCSAqIE5laXRo
ZXIgcHJlcGFyZV93cml0ZSBub3IgZG9fd3JpdGUgY2FsbGJhY2sgbm9yIHVwZGF0ZV9wcm9ncmVz
cyBpcwogCSAqIHVzZWZ1bCBmb3IgdXMuCiAJICovCi0JY3R4ID0gQ3JlYXRlSW5pdERlY29kaW5n
Q29udGV4dChSRVBMX1BMVUdJTl9OQU1FLAorCWN0eCA9IENyZWF0ZUluaXREZWNvZGluZ0NvbnRl
eHQoUkVQQUNLX1BMVUdJTl9OQU1FLAogCQkJCQkJCQkJTklMLAogCQkJCQkJCQkJdHJ1ZSwKIAkJ
CQkJCQkJCXRydWUsCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9sb2dpY2Fs
L2xvZ2ljYWwuYyBiL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL2xvZ2ljYWwvbG9naWNhbC5jCmlu
ZGV4IDM1NDFmYzc5M2U0Li4yOGI5YzRlYTMwNyAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvcmVw
bGljYXRpb24vbG9naWNhbC9sb2dpY2FsLmMKKysrIGIvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24v
bG9naWNhbC9sb2dpY2FsLmMKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRlICJhY2Nlc3MveGFj
dC5oIgogI2luY2x1ZGUgImFjY2Vzcy94bG9nX2ludGVybmFsLmgiCiAjaW5jbHVkZSAiYWNjZXNz
L3hsb2d1dGlscy5oIgorI2luY2x1ZGUgImNvbW1hbmRzL3JlcGFjay5oIgogI2luY2x1ZGUgImZt
Z3IuaCIKICNpbmNsdWRlICJtaXNjYWRtaW4uaCIKICNpbmNsdWRlICJwZ3N0YXQuaCIKQEAgLTM1
MSw2ICszNTIsMTcgQEAgQ3JlYXRlSW5pdERlY29kaW5nQ29udGV4dChjb25zdCBjaGFyICpwbHVn
aW4sCiAJaWYgKHBsdWdpbiA9PSBOVUxMKQogCQllbG9nKEVSUk9SLCAiY2Fubm90IGluaXRpYWxp
emUgbG9naWNhbCBkZWNvZGluZyB3aXRob3V0IGEgc3BlY2lmaWVkIHBsdWdpbiIpOwogCisJLyoK
KwkgKiBQbHVnaW4gZm9yIFJFUEFDSyAoQ09OQ1VSUkVOVExZKSBpcyBub3QgZGVzaWduZWQgZm9y
IG90aGVyIHVzZXMsIHN1Y2gKKwkgKiBhcyB0aGUgU1FMIGludGVyZmFjZS4gVXNlIHRoZSBmYWN0
IHRoYXQgUkVQQUNLIHVzZXMgYmFja2dyb3VuZCB3b3JrZXIKKwkgKiBmb3IgdGhlIGRlY29kaW5n
LgorCSAqLworCWlmIChzdHJjbXAocGx1Z2luLCBSRVBBQ0tfUExVR0lOX05BTUUpID09IDAgJiYg
IUFtUmVwYWNrV29ya2VyKCkpCisJCWVyZXBvcnQoRVJST1IsCisJCQkJKGVycmNvZGUoRVJSQ09E
RV9GRUFUVVJFX05PVF9TVVBQT1JURUQpLAorCQkJCSBlcnJtc2coIlRoZSBcIiVzXCIgZGVjb2Rl
ciBwbHVnaW4gbWF5IG9ubHkgYmUgY2FsbGVkIGJ5ICVzLiIsCisJCQkJCQlSRVBBQ0tfUExVR0lO
X05BTUUsICJSRVBBQ0sgKENPTkNVUlJFTlRMWSkiKSkpOworCiAJLyogTWFrZSBzdXJlIHRoZSBw
YXNzZWQgc2xvdCBpcyBzdWl0YWJsZS4gVGhlc2UgYXJlIHVzZXIgZmFjaW5nIGVycm9ycy4gKi8K
IAlpZiAoU2xvdElzUGh5c2ljYWwoc2xvdCkpCiAJCWVyZXBvcnQoRVJST1IsCmRpZmYgLS1naXQg
YS9zcmMvaW5jbHVkZS9jb21tYW5kcy9yZXBhY2suaCBiL3NyYy9pbmNsdWRlL2NvbW1hbmRzL3Jl
cGFjay5oCmluZGV4IDQ1ZTU0NDBhMzExLi4xZDVlOWRiYmUwMSAxMDA2NDQKLS0tIGEvc3JjL2lu
Y2x1ZGUvY29tbWFuZHMvcmVwYWNrLmgKKysrIGIvc3JjL2luY2x1ZGUvY29tbWFuZHMvcmVwYWNr
LmgKQEAgLTM1LDYgKzM1LDggQEAgdHlwZWRlZiBzdHJ1Y3QgQ2x1c3RlclBhcmFtcwogCXVpbnQz
MgkJb3B0aW9uczsJCS8qIGJpdG1hc2sgb2YgQ0xVT1BUXyogKi8KIH0gQ2x1c3RlclBhcmFtczsK
IAorI2RlZmluZSBSRVBBQ0tfUExVR0lOX05BTUUgICAicGdyZXBhY2siCisKIGV4dGVybiBQR0RM
TElNUE9SVCB2b2xhdGlsZSBzaWdfYXRvbWljX3QgUmVwYWNrTWVzc2FnZVBlbmRpbmc7CiAKIAot
LSAKMi40My4wCgo=
--000000000000cf5181065356d869--