MIME-Version: 1.0
References: <202601301728.sfkizrto3t5i@alvherre.pgsql> <9b9341b0-942e-4d34-b94f-92bd918fad04@ya.ru>
 <1317421770387925@cea5cfd9-50d3-4d85-a924-a7cc75f8f215>
In-Reply-To: <1317421770387925@cea5cfd9-50d3-4d85-a924-a7cc75f8f215>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Tue, 10 Feb 2026 02:46:39 +0900
Message-ID: <CAHGQGwF3tFP=oQgYHoS3h9TMeFbZwXc6+xdPTW8CkMV2TkjTmg@mail.gmail.com>
Subject: Re: basic_archive lost archive_directory
To: Sergei Kornilov <sk@zsrv.org>
Cc: =?UTF-8?B?0J7Qu9C10LMg0KHQsNC80L7QudC70L7Qsg==?= <splarv@ya.ru>, 
	pgsql-bugs@lists.postgresql.org, =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAHGQGwF3tFP%3DoQgYHoS3h9TMeFbZwXc6%2BxdPTW8CkMV2TkjTmg%40mail.gmail.com>
Precedence: bulk

On Fri, Feb 6, 2026 at 11:25=E2=80=AFPM Sergei Kornilov <sk@zsrv.org> wrote=
:
>
> Hello
>
> How to reproduce:
>
> 1) configure
>
> archive_mode =3D on
> archive_library =3D 'basic_archive'
> basic_archive.archive_directory =3D '/some/path/'
>
> 2) start postgres and verify archive works
> 3) make this directory temporary inaccessible. NFS will give you many way=
s to achieve this, here just mv /some/ /some_moved/  is enough.
> 4) basic_archive will complain ERROR:  could not create file ... No such =
file or directory for new WAL archive attempts
> 5) restart archiver process with any reason: kill it or restart postgres
> 6) make archive_directory accessible again: archiver process will not che=
ck the directory's existence again and continue to complain about unconfigu=
red archive_directory

Yes, this issue can last until, for example, the configuration is reloaded =
and
archive_directory is set again. I agree this needs to be addressed.


> Maybe it makes sense to move the directory existence check from check_arc=
hive_directory (guc check callback) to basic_archive_configured? (attached)

Basically I like the idea of moving the checks for archive_directory from
check_archive_directory() to basic_archive_configured(). This would not onl=
y
address this issue, but also other problems caused by performing these chec=
ks
in the GUC check hook.

basic_archive is usually loaded only by the archiver via archive_library.
In that case, errors reported by check_archive_directory() are not logged
by default, since GUC check hook errors are normally emitted only by
the postmaster. As a result, misconfigurations (e.g., a non-existent
archive_directory) may go unnoticed, which is problematic for users.

Moving the checks currently done in check_archive_directory() to
basic_archive_configured() would resolve this, which is one reason
I like your proposal.

In your patch, only the existence check is moved to basic_archive_configure=
d().
Would it also make sense to move the filename length check there? If so,
we could potentially remove the check_archive_directory GUC check hook enti=
rely.

Regards,

--=20
Fujii Masao