MIME-Version: 1.0
References: <19484-a3cb82c8cde3c8fa@postgresql.org>
 <CAJTYsWXY9C3B-7NZw72OKen2L2rZt=c-t6=kjTJzgj=ZaNPe8g@mail.gmail.com>
 <DIPI7GSQFV1C.20OALZACS6KLI@gmail.com>
 <CA+FpmFc10Dtnr9dr=xqK2cNYQ4-1VuOyvOT7-eqXPmiQJoyPew@mail.gmail.com>
 <DJ4M4TOUHLM0.B38DAVN79FPH@gmail.com>
In-Reply-To: <DJ4M4TOUHLM0.B38DAVN79FPH@gmail.com>
From: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Date: Wed, 10 Jun 2026 10:45:27 +0530
Message-ID: 
 <CAJTYsWWUfgCZau2fvrZVruXmC+dyOx45L=TyaGzXdywsywDyHQ@mail.gmail.com>
Subject: Re: BUG #19484: Segmentation fault triggered by FDW
To: Matheus Alcantara <matheusssilv97@gmail.com>
Cc: Rafia Sabih <rafia.pghackers@gmail.com>, 798604270@qq.com,
	pgsql-bugs@lists.postgresql.org, Etsuro Fujita <etsuro.fujita@gmail.com>
Content-Type: multipart/alternative; boundary="0000000000007e3e3e0653df5529"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJTYsWWUfgCZau2fvrZVruXmC%2BdyOx45L%3DTyaGzXdywsywDyHQ%40mail.gmail.com>
Precedence: bulk

--0000000000007e3e3e0653df5529
Content-Type: text/plain; charset="UTF-8"

Hi,

On Tue, 9 Jun 2026 at 20:40, Matheus Alcantara <matheusssilv97@gmail.com>
wrote:

>
> I think both patches should be squashed into a single one since they fix
> the same underlying issue. I've done this locally and also ran pg_indent
> over the result. Attached is the combined patch.
>

Thanks for this!


> One minor naming observation: the new fdwPrivLists field in
> ModifyTableState doesn't follow the mt_ prefix convention used by the
> other re-indexed lists (mt_updateColnosLists, mt_mergeActionLists,
> mt_mergeJoinConditions). Should we rename it to mt_fdwPrivLists for
> consistency?
>

I think yes, it makes sense to rename it.

Regards,
Ayush

--0000000000007e3e3e0653df5529
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi,</div><br><div class=3D"gmail_quote gm=
ail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, 9 Jun 20=
26 at 20:40, Matheus Alcantara &lt;<a href=3D"mailto:matheusssilv97@gmail.c=
om">matheusssilv97@gmail.com</a>&gt; wrote:</div><blockquote class=3D"gmail=
_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204=
,204);padding-left:1ex">
<br>
I think both patches should be squashed into a single one since they fix<br=
>
the same underlying issue. I&#39;ve done this locally and also ran pg_inden=
t<br>
over the result. Attached is the combined patch.<br></blockquote><div><br><=
/div><div>Thanks for this!<br>=C2=A0</div><blockquote class=3D"gmail_quote"=
 style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);p=
adding-left:1ex">
One minor naming observation: the new fdwPrivLists field in<br>
ModifyTableState doesn&#39;t follow the mt_ prefix convention used by the<b=
r>
other re-indexed lists (mt_updateColnosLists, mt_mergeActionLists,<br>
mt_mergeJoinConditions). Should we rename it to mt_fdwPrivLists for<br>
consistency?<br></blockquote><div><br></div><div>I think yes, it makes sens=
e to rename it.<br><br>Regards,<br>Ayush</div></div></div>

--0000000000007e3e3e0653df5529--