public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ayush Tiwari <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: BUG #19476: Segmentation fault in contrib/spi
Date: Thu, 14 May 2026 22:42:07 +0530
Message-ID: <CAJTYsWWWeQvL0JaLYArnunhKfX6=g3q1Mjq_ViipW6G011dfpQ@mail.gmail.com> (raw)
In-Reply-To: <agX8Olw7JnK7o9se@nathan>
References: <[email protected]>
	<CAJTYsWVuNPbqS2p1gEitRLBHuytqM7OMawuzVH6g4uqGw4RBsQ@mail.gmail.com>
	<[email protected]>
	<CAJTYsWWh5qsJcLatT5HD9daTEbCnZUZoqaDPGiT=+EyHkEKJ2A@mail.gmail.com>
	<agXx84rrzKWY9aAE@nathan>
	<agX8Olw7JnK7o9se@nathan>

Hi,

On Thu, 14 May 2026 at 22:15, Nathan Bossart <[email protected]>
wrote:

> On Thu, May 14, 2026 at 11:01:55AM -0500, Nathan Bossart wrote:
> > Regarding 0001, note that the refint docs state the following:
> >
> >     Note that the primary/unique key columns should be marked NOT NULL
> and
> >     should have a unique index.
> >
> > So maybe we could alternatively teach check_foreign_key() to either ERROR
> > or do nothing instead.  On the other hand, given this case seemed to
> > accidentally work before the CVE fix, it's arguably worth fixing.
>
> Here is what I have staged for commit, which I intend to do shortly.
>
>
Thanks, this version looks good to me.  The compact form is fine, and I
agree with preserving the pre-CVE behavior for this misconfigured case
rather than turning it into an ERROR or no-op.

I also agree with your earlier point about the parameterized 0002: using
the triggered relation's key types for parameters is not generally right
for the referencing relation's SET targets.

I think the cached cascade UPDATE plan issue is worth pursuing,
I'll start a different hackers thread on that
probably using the "don't cache cascade UPDATE plans" approach you
suggested.

Regards,
Ayush

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: BUG #19476: Segmentation fault in contrib/spi
  In-Reply-To: <CAJTYsWWWeQvL0JaLYArnunhKfX6=g3q1Mjq_ViipW6G011dfpQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox