MIME-Version: 1.0
References: <19508-e5f188183279219b@postgresql.org>
 <CAHGQGwGaC8RNeVP3A4_R1OcHJ-DrXgr2HH2UEYrt-Ueu516Gng@mail.gmail.com>
 <CAJTYsWX6b0UxeZ9HGGnju-XpWRmLr_y8AVeyWqd3gL+a0NkGtw@mail.gmail.com>
 <CAHGQGwHnVc97gVZU22zwRQjbhAWQy0Jgm0yrAErgxROSbuAsXg@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwHnVc97gVZU22zwRQjbhAWQy0Jgm0yrAErgxROSbuAsXg@mail.gmail.com>
From: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Date: Fri, 5 Jun 2026 14:17:58 +0530
Message-ID: 
 <CAJTYsWWqUf2bEAwGfaJvLmokRXBn4yGKVD=jmysnQV9dmv1fwA@mail.gmail.com>
Subject: Re: BUG #19508: pg_buffercache_pages() crashes the backend with an
 incompatible caller-supplied record definition
To: Fujii Masao <masao.fujii@gmail.com>
Cc: =?UTF-8?B?0JrQsNC70LjQvdC40L0g0J3QuNC60LjRgtCw?=
 <n.kalinin@postgrespro.ru>,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000006fa8cc06537db87b"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJTYsWWqUf2bEAwGfaJvLmokRXBn4yGKVD%3DjmysnQV9dmv1fwA%40mail.gmail.com>
Precedence: bulk

--0000000000006fa8cc06537db87b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, 5 Jun, 2026, 13:28 Fujii Masao, <masao.fujii@gmail.com> wrote:

> On Fri, Jun 5, 2026 at 12:42=E2=80=AFPM Ayush Tiwari
> <ayushtiwari.slg01@gmail.com> wrote:
> > One small nit: build_buffercache_pages_tupledesc() names attribute 8
> > "usage_count", while the existing pg_buffercache view and the test use
> > "usagecount". This probably does not affect the tupledesc_match() check=
,
> > but I think it would be better to keep the existing spelling for
> > consistency.
>
> Agreed. I've fixed that and attached an updated version of the patch.
>

LGTM.

Regards,
Ayush

>

--0000000000006fa8cc06537db87b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div>Hi,<br><br><div class=3D"gmail_quote gmail_quote_con=
tainer"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, 5 Jun, 2026, 13:28 Fu=
jii Masao, &lt;<a href=3D"mailto:masao.fujii@gmail.com">masao.fujii@gmail.c=
om</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margi=
n:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Fri, Jun 5, 20=
26 at 12:42=E2=80=AFPM Ayush Tiwari<br>
&lt;<a href=3D"mailto:ayushtiwari.slg01@gmail.com" target=3D"_blank" rel=3D=
"noreferrer">ayushtiwari.slg01@gmail.com</a>&gt; wrote:<br>
&gt; One small nit: build_buffercache_pages_tupledesc() names attribute 8<b=
r>
&gt; &quot;usage_count&quot;, while the existing pg_buffercache view and th=
e test use<br>
&gt; &quot;usagecount&quot;. This probably does not affect the tupledesc_ma=
tch() check,<br>
&gt; but I think it would be better to keep the existing spelling for<br>
&gt; consistency.<br>
<br>
Agreed. I&#39;ve fixed that and attached an updated version of the patch.<b=
r></blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">LG=
TM.</div><div dir=3D"auto"><br></div><div dir=3D"auto">Regards,</div><div d=
ir=3D"auto">Ayush</div><div dir=3D"auto"><div class=3D"gmail_quote gmail_qu=
ote_container"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex=
;border-left:1px #ccc solid;padding-left:1ex"></blockquote></div></div></di=
v>

--0000000000006fa8cc06537db87b--