MIME-Version: 1.0
References: <CAJTYsWWNfF+hMpbsTDF8NMr+AuqoDfNxR=oHUZm7xqGP+dJ9rA@mail.gmail.com>
 <aenQ37wBgKqZb7a8@paquier.xyz> <FE1D12FF-7E5D-4ED0-A59F-BEA6DEF7EE2C@yesql.se>
 <1444609.1776958814@sss.pgh.pa.us> <CAJTYsWUJFHhqiGD+6vw6m0ELqjajoKev2UutFUMB2uQDjm6+TA@mail.gmail.com>
 <aeqZukF8X29eWtqy@paquier.xyz> <B96867CD-3533-40BA-AE09-43DB2CA5DC48@yesql.se>
 <CAJTYsWV1wEuv2ZbBHt4BQ2O4-Na6JdxSU3b--GFzs-j5cG_pVA@mail.gmail.com>
 <CAJTYsWVEk5vdy8of2DCWzDNJgHUNL0p0Dt6b1zkgmvmNo3ht6w@mail.gmail.com> <1B595919-2596-4CB3-BC39-DDCCB9876E56@yesql.se>
In-Reply-To: <1B595919-2596-4CB3-BC39-DDCCB9876E56@yesql.se>
From: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Date: Fri, 24 Apr 2026 18:20:45 +0530
Message-ID: <CAJTYsWXor+vwxEH4oxxjZcQi9bcxz=9OAFt7wQWRxpaA_HyGiQ@mail.gmail.com>
Subject: Re: to_date()/to_timestamp() silently accept month=0 and day=0
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>, 
	pgsql-bugs@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000005447670650343776"
Archived-At: <https://www.postgresql.org/message-id/CAJTYsWXor%2BvwxEH4oxxjZcQi9bcxz%3D9OAFt7wQWRxpaA_HyGiQ%40mail.gmail.com>
Precedence: bulk

--0000000000005447670650343776
Content-Type: text/plain; charset="UTF-8"

On Fri, 24 Apr 2026 at 18:14, Daniel Gustafsson <daniel@yesql.se> wrote:

> > On 24 Apr 2026, at 11:13, Ayush Tiwari <ayushtiwari.slg01@gmail.com>
> wrote:
>
> > Attached patch, please review.
>
> LGTM for the most part, I don't really think we need to use both to_date
> and
> to_timestamp though, we can save a few cycles there.  I rewrote the
> comments to
> match the rest of the file, and moved to where to where we test for year
> 0000
> since it seems like a better place.  Also took the liberty to use year 100
> in
> one of the testcase, while the year is superfluous for the test in
> question,
> year 100 was previously untested so this will increase test coverage for
> free.
>

Looks good to me. Thank you!

Regards,
Ayush

--0000000000005447670650343776
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, 24 Apr =
2026 at 18:14, Daniel Gustafsson &lt;<a href=3D"mailto:daniel@yesql.se">dan=
iel@yesql.se</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" styl=
e=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddin=
g-left:1ex">&gt; On 24 Apr 2026, at 11:13, Ayush Tiwari &lt;<a href=3D"mail=
to:ayushtiwari.slg01@gmail.com" target=3D"_blank">ayushtiwari.slg01@gmail.c=
om</a>&gt; wrote:<br>
<br>
&gt; Attached patch, please review.<br>
<br>
LGTM for the most part, I don&#39;t really think we need to use both to_dat=
e and<br>
to_timestamp though, we can save a few cycles there.=C2=A0 I rewrote the co=
mments to<br>
match the rest of the file, and moved to where to where we test for year 00=
00<br>
since it seems like a better place.=C2=A0 Also took the liberty to use year=
 100 in<br>
one of the testcase, while the year is superfluous for the test in question=
,<br>
year 100 was previously untested so this will increase test coverage for fr=
ee.<br></blockquote><div><br>Looks good to me. Thank you!<br><br>Regards,<b=
r>Ayush=C2=A0</div></div></div>

--0000000000005447670650343776--