public inbox for [email protected]help / color / mirror / Atom feed
Re: BUG #19434: adding WHERE to a publication can cause UPDATEs and DELETEs to fail on the source table 3+ messages / 2 participants [nested] [flat]
* Re: BUG #19434: adding WHERE to a publication can cause UPDATEs and DELETEs to fail on the source table @ 2026-03-23 16:47 Greg Sabino Mullane <[email protected]> 2026-03-23 19:49 ` Re: BUG #19434: adding WHERE to a publication can cause UPDATEs and DELETEs to fail on the source table Tim McLaughlin <[email protected]> 2026-04-05 12:41 ` Re: BUG #19434: adding WHERE to a publication can cause UPDATEs and DELETEs to fail on the source table Tim McLaughlin <[email protected]> 0 siblings, 2 replies; 3+ messages in thread From: Greg Sabino Mullane @ 2026-03-23 16:47 UTC (permalink / raw) To: [email protected]; [email protected] I don't think this is really a bug, more of a feature request / optimization. However, I do agree this is an important one. I don't see offhand why we can't append the where list to our existing list of important columns. There would be a few downsides, but none that would be worse than going full replica identity or creating a new index. I'll see about making a proof of concept patch and throwing it on -hackers. Will cc you on that. Cheers, Greg ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: BUG #19434: adding WHERE to a publication can cause UPDATEs and DELETEs to fail on the source table 2026-03-23 16:47 Re: BUG #19434: adding WHERE to a publication can cause UPDATEs and DELETEs to fail on the source table Greg Sabino Mullane <[email protected]> @ 2026-03-23 19:49 ` Tim McLaughlin <[email protected]> 1 sibling, 0 replies; 3+ messages in thread From: Tim McLaughlin @ 2026-03-23 19:49 UTC (permalink / raw) To: Greg Sabino Mullane <[email protected]>; +Cc: [email protected] Thanks for the feedback, Greg. Cheers, Tim +1-571-263-1023 On Mon, Mar 23, 2026 at 12:47 PM Greg Sabino Mullane <[email protected]> wrote: > I don't think this is really a bug, more of a feature request / > optimization. However, I do agree this is an important one. I don't see > offhand why we can't append the where list to our existing list of > important columns. There would be a few downsides, but none that would be > worse than going full replica identity or creating a new index. I'll see > about making a proof of concept patch and throwing it on -hackers. Will cc > you on that. > > Cheers, > Greg > > ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: BUG #19434: adding WHERE to a publication can cause UPDATEs and DELETEs to fail on the source table 2026-03-23 16:47 Re: BUG #19434: adding WHERE to a publication can cause UPDATEs and DELETEs to fail on the source table Greg Sabino Mullane <[email protected]> @ 2026-04-05 12:41 ` Tim McLaughlin <[email protected]> 1 sibling, 0 replies; 3+ messages in thread From: Tim McLaughlin @ 2026-04-05 12:41 UTC (permalink / raw) To: Greg Sabino Mullane <[email protected]>; +Cc: [email protected] Greg, I'm actually working on another project that uses CDC for fraud detection and it occurred to me that it would be really great if there was an explicit way to just add a column to the "important columns" in general when the table is added to a publication. I'm currently using a pg_logical_embed_message to do it, but it would be a lot cleaner if there was something like this: ALTER PUBLICATION mypublication ADD TABLE users (user_id, firstname) INCLUDE (account_id) WHERE (status = 'ACTIVE'); It would effectively then have account_id & status always included in the NEW column. Cheers, Tim On Mon, Mar 23, 2026 at 12:47 PM Greg Sabino Mullane <[email protected]> wrote: > I don't think this is really a bug, more of a feature request / > optimization. However, I do agree this is an important one. I don't see > offhand why we can't append the where list to our existing list of > important columns. There would be a few downsides, but none that would be > worse than going full replica identity or creating a new index. I'll see > about making a proof of concept patch and throwing it on -hackers. Will cc > you on that. > > Cheers, > Greg > > ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-04-05 12:41 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-03-23 16:47 Re: BUG #19434: adding WHERE to a publication can cause UPDATEs and DELETEs to fail on the source table Greg Sabino Mullane <[email protected]> 2026-03-23 19:49 ` Tim McLaughlin <[email protected]> 2026-04-05 12:41 ` Tim McLaughlin <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox