MIME-Version: 1.0
References: <19507-78eec77213b5284f@postgresql.org>
 <8690FCD2-B96C-4C0B-BFAC-94E9383A47AA@Outlook.com>
 <CAKQrOnr621sTrm4=uqRikq=ZB+-qEb4tq5opPQTiF8J+xr-cwg@mail.gmail.com>
 <2856BB12-6389-4F06-9B35-576B838B669E@Outlook.com>
In-Reply-To: <2856BB12-6389-4F06-9B35-576B838B669E@Outlook.com>
From: Marko Grujic <markoog@gmail.com>
Date: Fri, 5 Jun 2026 15:11:25 +0200
Message-ID: 
 <CAKQrOnp2H4FpzagV1CFyoWbja1jLcwCmuufipw6OiVsWgF+_Cg@mail.gmail.com>
Subject: Re: BUG #19507: Auto-named partition table constraint conflicts
To: Chengpeng Yan <chengpeng_yan@outlook.com>
Cc: "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000946f9e0653816684"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKQrOnp2H4FpzagV1CFyoWbja1jLcwCmuufipw6OiVsWgF%2B_Cg%40mail.gmail.com>
Precedence: bulk

--000000000000946f9e0653816684
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

No worries; yeah, a review would be greatly appreciated, thank you.

On Fri, Jun 5, 2026 at 3:09=E2=80=AFPM Chengpeng Yan <chengpeng_yan@outlook=
.com>
wrote:

>
> > On Jun 5, 2026, at 21:01, Marko Grujic <markoog@gmail.com> wrote:
> >
> > Hi Chengpeng,
> >
> > Thanks for the heads up.
> >
> > > My current plan is to preserve the
> > existing behavior for explicitly named constraints, but make
> > automatically generated names avoid conflicts that would be hit during
> > recursive propagation. In other words, when considering a generated
> > candidate name for the parent, the code should also consider whether
> > using that name throughout the relevant partition/inheritance tree woul=
d
> > run into a name conflict.
> >
> > Fyi, I also have a patch up already with that exact purpose:
> https://www.postgresql.org/message-id/CAOvwyF1JsmerqF6hA005rb6YLP%3DpQAPO=
JCAKnr398%3D0ReZG%3DAA%40mail.gmail.com
> >
> > Cheers,
> > Marko
>
>
> Sorry, I hadn't noticed that you had already posted a patch for this.
>
> Thanks for pointing it out. I'll take a look and try to review it when I
> get some time.
>
> --
> Best regards,
> Chengpeng Yan

--000000000000946f9e0653816684
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">No worries; yeah, a review would be greatly appreciated, t=
hank you.</div><br><div class=3D"gmail_quote gmail_quote_container"><div di=
r=3D"ltr" class=3D"gmail_attr">On Fri, Jun 5, 2026 at 3:09=E2=80=AFPM Cheng=
peng Yan &lt;<a href=3D"mailto:chengpeng_yan@outlook.com">chengpeng_yan@out=
look.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D=
"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-le=
ft:1ex"><br>
&gt; On Jun 5, 2026, at 21:01, Marko Grujic &lt;<a href=3D"mailto:markoog@g=
mail.com" target=3D"_blank">markoog@gmail.com</a>&gt; wrote:<br>
&gt; <br>
&gt; Hi Chengpeng,<br>
&gt; <br>
&gt; Thanks for the heads up.<br>
&gt; <br>
&gt; &gt; My current plan is to preserve the<br>
&gt; existing behavior for explicitly named constraints, but make<br>
&gt; automatically generated names avoid conflicts that would be hit during=
<br>
&gt; recursive propagation. In other words, when considering a generated<br=
>
&gt; candidate name for the parent, the code should also consider whether<b=
r>
&gt; using that name throughout the relevant partition/inheritance tree wou=
ld<br>
&gt; run into a name conflict.<br>
&gt; <br>
&gt; Fyi, I also have a patch up already with that exact purpose: <a href=
=3D"https://www.postgresql.org/message-id/CAOvwyF1JsmerqF6hA005rb6YLP%3DpQA=
POJCAKnr398%3D0ReZG%3DAA%40mail.gmail.com" rel=3D"noreferrer" target=3D"_bl=
ank">https://www.postgresql.org/message-id/CAOvwyF1JsmerqF6hA005rb6YLP%3DpQ=
APOJCAKnr398%3D0ReZG%3DAA%40mail.gmail.com</a><br>
&gt; <br>
&gt; Cheers,<br>
&gt; Marko<br>
<br>
<br>
Sorry, I hadn&#39;t noticed that you had already posted a patch for this.<b=
r>
<br>
Thanks for pointing it out. I&#39;ll take a look and try to review it when =
I<br>
get some time.<br>
<br>
--<br>
Best regards,<br>
Chengpeng Yan</blockquote></div>

--000000000000946f9e0653816684--