MIME-Version: 1.0
References: <16997-ff16127f6e0d1390@postgresql.org>
In-Reply-To: <16997-ff16127f6e0d1390@postgresql.org>
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: Fri, 7 May 2021 17:13:16 +0530
Message-ID: 
 <CALj2ACVfeikCKamTEGPrJSfYwQSYYmG0z5LSHK+B0QOP5Lefag@mail.gmail.com>
Subject: Re: BUG #16997: parameter server_encoding's category problem
To: pgsql-bugs@lists.postgresql.org
Cc: leiyanliang@highgo.com
Content-Type: multipart/mixed; boundary="000000000000b4141805c1bbef8c"
Archived-At: 
 <https://www.postgresql.org/message-id/CALj2ACVfeikCKamTEGPrJSfYwQSYYmG0z5LSHK%2BB0QOP5Lefag%40mail.gmail.com>
Precedence: bulk

--000000000000b4141805c1bbef8c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, May 7, 2021 at 3:11 PM PG Bug reporting form
<noreply@postgresql.org> wrote:
>
> The following bug has been logged on the website:
>
> Bug reference:      16997
> Logged by:          yanliang lei
> Email address:      leiyanliang@highgo.com
> PostgreSQL version: 13.1
> Operating system:   CentOS7.6
> Description:
>
> In the following sql statement=EF=BC=8C parameter server_encoding's categ=
ory is
> =E2=80=9CClient Connection Defaults / Locale and Formatting=E2=80=9D=EF=
=BC=9A
>
> postgres=3D# select category from pg_settings where name=3D'server_encodi=
ng';
> -[ RECORD 1 ]------------------------------------------------
> category | Client Connection Defaults / Locale and Formatting
>
> postgres=3D#
>
> In the document
> https://www.postgresql.org/docs/current/runtime-config-client.html#RUNTIM=
E-CONFIG-CLIENT-FORMAT=EF=BC=8C
> there is no entry about parameter server_encoding.
>
> and in the document
> https://www.postgresql.org/docs/current/runtime-config-preset.html,there =
is
> a entry about parameter server_encoding.
>
> so, What is the parameter server_encoding's category?

Thanks for reporting. All the internal parameters that can't be set by
the users are under the "Preset Options" category. Likewise,
server_encoding, lc_collate and lc_ctype should also be listed under
the "Preset Options" category, even though there is a "Client
Connection Defaults / Locale and Formatting" category, which has user
configurable parameters. For instance, since the in_hot_standby is an
internal parameter, it is specified under the "Preset Options" even
though there is a "Replication / Standby Servers" category which
mentions all the user configurable parameters.

Therefore, I would say that the documentation is correct but the code
is not. Attached patch should fix this.

While on this, I also adjusted some of the wordings for the other
"Preset Options".

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

--000000000000b4141805c1bbef8c
Content-Type: application/octet-stream;
	name="v1-0001-Move-server_encoding-server_encoding-lc_ctype-to-.patch"
Content-Disposition: attachment;
	filename="v1-0001-Move-server_encoding-server_encoding-lc_ctype-to-.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_koe905ia0>
X-Attachment-Id: f_koe905ia0

RnJvbSBlYjRjY2IxNTBlODEzZTFlOTk1YjI0Y2Q0ZWZhMTExMDA5YTczYzg5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBCaGFyYXRoIFJ1cGlyZWRkeSA8YmhhcmF0aC5ydXBpcmVkZHlA
ZW50ZXJwcmlzZWRiLmNvbT4KRGF0ZTogRnJpLCA3IE1heSAyMDIxIDE3OjA2OjM2ICswNTMwClN1
YmplY3Q6IFtQQVRDSCB2MV0gTW92ZSBzZXJ2ZXJfZW5jb2Rpbmcsc2VydmVyX2VuY29kaW5nLGxj
X2N0eXBlIHRvIFByZXNldAogT3B0aW9ucwoKQWxsIHRoZSBpbnRlcm5hbCBwYXJhbWV0ZXJzIHRo
YXQgY2FuJ3QgYmUgc2V0IGJ5IHRoZSB1c2VycyBhcmUKdW5kZXIgdGhlICJQcmVzZXQgT3B0aW9u
cyIgY2F0ZWdvcnkuIExpa2V3aXNlLCBzZXJ2ZXJfZW5jb2RpbmcsCmxjX2NvbGxhdGUgYW5kIGxj
X2N0eXBlIHNob3VsZCBhbHNvIGJlIGxpc3RlZCB1bmRlciB0aGF0IGNhdGVnb3J5LApldmVuIHRo
b3VnaCB0aGVyZSBpcyBhICJDbGllbnQgQ29ubmVjdGlvbiBEZWZhdWx0cyAvIExvY2FsZSBhbmQg
Rm9ybWF0dGluZyIKY2F0ZWdvcnksIHdoaWNoIGlzIGZvciB1c2VyIGNvbmZpZ3VyYWJsZSBwYXJh
bWV0ZXJzLiBGb3IgaW5zdGFuY2UsCnNpbmNlIHRoZSBpbl9ob3Rfc3RhbmRieSBpcyBhbiBpbnRl
cm5hbCBwYXJhbWV0ZXIgaXQgaXMgc3BlY2lmaWVkCnVuZGVyIHRoZSAiUHJlc2V0IE9wdGlvbnMi
IGV2ZW4gdGhvdWdoIHRoZXJlIGlzIGEKIlJlcGxpY2F0aW9uIC8gU3RhbmRieSBTZXJ2ZXJzIiBj
YXRlZ29yeSB3aGljaCBvbmx5IG1lbnRpb25zIGFsbCB0aGUKdXNlciBjb25maWd1cmFibGUgcGFy
YW1ldGVycy4KCldoaWxlIG9uIHRoaXMsIGRlc2NyaXB0aW9ucyBmb3Igc29tZSBvZiB0aGUgIlBy
ZXNldCBPcHRpb25zIiBhcmUKcmV3b3JkZWQgdG8gYmUgbW9yZSBtZWFuaW5nZnVsLgotLS0KIHNy
Yy9iYWNrZW5kL3V0aWxzL21pc2MvZ3VjLmMgfCAxNCArKysrKysrLS0tLS0tLQogMSBmaWxlIGNo
YW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMv
YmFja2VuZC91dGlscy9taXNjL2d1Yy5jIGIvc3JjL2JhY2tlbmQvdXRpbHMvbWlzYy9ndWMuYwpp
bmRleCBmMmM3YzI0ODZiLi5lNmJkZDUzZjQ0IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC91dGls
cy9taXNjL2d1Yy5jCisrKyBiL3NyYy9iYWNrZW5kL3V0aWxzL21pc2MvZ3VjLmMKQEAgLTE4Njks
NyArMTg2OSw3IEBAIHN0YXRpYyBzdHJ1Y3QgY29uZmlnX2Jvb2wgQ29uZmlndXJlTmFtZXNCb29s
W10gPQogCiAJewogCQl7ImludGVnZXJfZGF0ZXRpbWVzIiwgUEdDX0lOVEVSTkFMLCBQUkVTRVRf
T1BUSU9OUywKLQkJCWdldHRleHRfbm9vcCgiRGF0ZXRpbWVzIGFyZSBpbnRlZ2VyIGJhc2VkLiIp
LAorCQkJZ2V0dGV4dF9ub29wKCJTaG93cyB3aGV0aGVyIFBvc3RncmVTUUwgc2VydmVyIHdhcyBi
dWlsdCB3aXRoIHN1cHBvcnQgZm9yIDY0LWJpdC1pbnRlZ2VyIGRhdGVzIGFuZCB0aW1lcy4iKSwK
IAkJCU5VTEwsCiAJCQlHVUNfUkVQT1JUIHwgR1VDX05PVF9JTl9TQU1QTEUgfCBHVUNfRElTQUxM
T1dfSU5fRklMRQogCQl9LApAQCAtMjQxNiw3ICsyNDE2LDcgQEAgc3RhdGljIHN0cnVjdCBjb25m
aWdfaW50IENvbmZpZ3VyZU5hbWVzSW50W10gPQogCiAJewogCQl7ImRhdGFfZGlyZWN0b3J5X21v
ZGUiLCBQR0NfSU5URVJOQUwsIFBSRVNFVF9PUFRJT05TLAotCQkJZ2V0dGV4dF9ub29wKCJNb2Rl
IG9mIHRoZSBkYXRhIGRpcmVjdG9yeS4iKSwKKwkJCWdldHRleHRfbm9vcCgiU2hvd3MgdGhlIHBl
cm1pc3Npb25zIG9mIHRoZSBkYXRhIGRpcmVjdG9yeSBoYWQgYXQgdGhlIFBvc3RncmVTUUwgc2Vy
dmVyIHN0YXJ0dXAuIiksCiAJCQlnZXR0ZXh0X25vb3AoIlRoZSBwYXJhbWV0ZXIgdmFsdWUgaXMg
YSBudW1lcmljIG1vZGUgc3BlY2lmaWNhdGlvbiAiCiAJCQkJCQkgImluIHRoZSBmb3JtIGFjY2Vw
dGVkIGJ5IHRoZSBjaG1vZCBhbmQgdW1hc2sgc3lzdGVtICIKIAkJCQkJCSAiY2FsbHMuIChUbyB1
c2UgdGhlIGN1c3RvbWFyeSBvY3RhbCBmb3JtYXQgdGhlIG51bWJlciAiCkBAIC00MTAyLDcgKzQx
MDIsNyBAQCBzdGF0aWMgc3RydWN0IGNvbmZpZ19zdHJpbmcgQ29uZmlndXJlTmFtZXNTdHJpbmdb
XSA9CiAJLyogU2VlIG1haW4uYyBhYm91dCB3aHkgZGVmYXVsdHMgZm9yIExDX2ZvbyBhcmUgbm90
IGFsbCBhbGlrZSAqLwogCiAJewotCQl7ImxjX2NvbGxhdGUiLCBQR0NfSU5URVJOQUwsIENMSUVO
VF9DT05OX0xPQ0FMRSwKKwkJeyJsY19jb2xsYXRlIiwgUEdDX0lOVEVSTkFMLCBQUkVTRVRfT1BU
SU9OUywKIAkJCWdldHRleHRfbm9vcCgiU2hvd3MgdGhlIGNvbGxhdGlvbiBvcmRlciBsb2NhbGUu
IiksCiAJCQlOVUxMLAogCQkJR1VDX05PVF9JTl9TQU1QTEUgfCBHVUNfRElTQUxMT1dfSU5fRklM
RQpAQCAtNDExMyw3ICs0MTEzLDcgQEAgc3RhdGljIHN0cnVjdCBjb25maWdfc3RyaW5nIENvbmZp
Z3VyZU5hbWVzU3RyaW5nW10gPQogCX0sCiAKIAl7Ci0JCXsibGNfY3R5cGUiLCBQR0NfSU5URVJO
QUwsIENMSUVOVF9DT05OX0xPQ0FMRSwKKwkJeyJsY19jdHlwZSIsIFBHQ19JTlRFUk5BTCwgUFJF
U0VUX09QVElPTlMsCiAJCQlnZXR0ZXh0X25vb3AoIlNob3dzIHRoZSBjaGFyYWN0ZXIgY2xhc3Np
ZmljYXRpb24gYW5kIGNhc2UgY29udmVyc2lvbiBsb2NhbGUuIiksCiAJCQlOVUxMLAogCQkJR1VD
X05PVF9JTl9TQU1QTEUgfCBHVUNfRElTQUxMT1dfSU5fRklMRQpAQCAtNDIwOSw4ICs0MjA5LDgg
QEAgc3RhdGljIHN0cnVjdCBjb25maWdfc3RyaW5nIENvbmZpZ3VyZU5hbWVzU3RyaW5nW10gPQog
CiAJewogCQkvKiBDYW4ndCBiZSBzZXQgaW4gcG9zdGdyZXNxbC5jb25mICovCi0JCXsic2VydmVy
X2VuY29kaW5nIiwgUEdDX0lOVEVSTkFMLCBDTElFTlRfQ09OTl9MT0NBTEUsCi0JCQlnZXR0ZXh0
X25vb3AoIlNldHMgdGhlIHNlcnZlciAoZGF0YWJhc2UpIGNoYXJhY3RlciBzZXQgZW5jb2Rpbmcu
IiksCisJCXsic2VydmVyX2VuY29kaW5nIiwgUEdDX0lOVEVSTkFMLCBQUkVTRVRfT1BUSU9OUywK
KwkJCWdldHRleHRfbm9vcCgiU2hvd3MgdGhlIFBvc3RncmVTUUwgc2VydmVyIGNoYXJhY3RlciBz
ZXQgZW5jb2RpbmcuIiksCiAJCQlOVUxMLAogCQkJR1VDX0lTX05BTUUgfCBHVUNfUkVQT1JUIHwg
R1VDX05PVF9JTl9TQU1QTEUgfCBHVUNfRElTQUxMT1dfSU5fRklMRQogCQl9LApAQCAtNDQyOSw3
ICs0NDI5LDcgQEAgc3RhdGljIHN0cnVjdCBjb25maWdfc3RyaW5nIENvbmZpZ3VyZU5hbWVzU3Ry
aW5nW10gPQogCiAJewogCQl7InNzbF9saWJyYXJ5IiwgUEdDX0lOVEVSTkFMLCBQUkVTRVRfT1BU
SU9OUywKLQkJCWdldHRleHRfbm9vcCgiTmFtZSBvZiB0aGUgU1NMIGxpYnJhcnkuIiksCisJCQln
ZXR0ZXh0X25vb3AoIlNob3dzIHRoZSBuYW1lIG9mIHRoZSBTU0wgbGlicmFyeSB0aGF0IHRoaXMg
UG9zdGdyZVNRTCBzZXJ2ZXIgd2FzIGJ1aWx0IHdpdGguIiksCiAJCQlOVUxMLAogCQkJR1VDX05P
VF9JTl9TQU1QTEUgfCBHVUNfRElTQUxMT1dfSU5fRklMRQogCQl9LAotLSAKMi4yNS4xCgo=
--000000000000b4141805c1bbef8c--