public inbox for [email protected]
help / color / mirror / Atom feedFrom: Virender Singla <[email protected]>
To: [email protected]
Cc: Aniket Jha <[email protected]>
Subject: Major Version Upgrade failure due to orphan roles entries in catalog
Date: Tue, 11 Feb 2025 15:32:42 +0530
Message-ID: <CAM6Zo8woa62ZFHtMKox6a4jb8qQ=w87R2L0K8347iE-juQL2EA@mail.gmail.com> (raw)
Hi,
We have identified an issue causing upgrade failures. The following steps
detail how to reproduce the issue:
*Create an orphan role entry*
/* Postgres version:: PostgreSQL 16.6 */
/* The same can be reproduced in version 17 as well */
create role my_group;
create role dropped_member;
begin;
grant my_group to dropped_member;
OTHER SESSION: drop role dropped_member;
BACK IN ORIGINAL SESSION:
commit;
*Upgrade to Postgres v17*
And the upgrade fails with an error :
*GRANT "my_group" TO "" WITH INHERIT TRUE GRANTED BY "postgres";ERROR:
zero-length delimited identifier at or near """"*
The issue seems to be coming from pg_dumpall for building grants during
pg_upgrade.
https://github.com/postgres/postgres/blob/master/src/bin/pg_dump/pg_dumpall.c#L992
-Virender
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Major Version Upgrade failure due to orphan roles entries in catalog
In-Reply-To: <CAM6Zo8woa62ZFHtMKox6a4jb8qQ=w87R2L0K8347iE-juQL2EA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox