MIME-Version: 1.0
From: Bill Kim <billkimjh@gmail.com>
Date: Sun, 28 Jun 2026 11:14:35 +0900
Message-ID: 
 <CAMQXxcgbtD2LXfX0tpgvOizxP-XxrCHV2ZDy4By_TZnJMsxXWQ@mail.gmail.com>
Subject: BUG #19524: NaN handling in btree_gist's float4/float8 opclasses
To: pgsql-bugs@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000e6e412065546e763"
Archived-At: 
 <https://www.postgresql.org/message-id/CAMQXxcgbtD2LXfX0tpgvOizxP-XxrCHV2ZDy4By_TZnJMsxXWQ%40mail.gmail.com>
Precedence: bulk

--000000000000e6e412065546e763
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

 Hi all,

  I have a patch for this and `make check` passes (core + all contrib, plus
  new btree_gist NaN cases covering the three scenarios in the report).
  Posting here first in case someone is already further along =E2=80=94 if =
not,
  I'll send it to pgsql-hackers and register it in the open CF in a couple
  of days.

  The fix swaps the five gbt_float{4,8}{gt,ge,eq,le,lt} comparators and
  gbt_float{4,8}key_cmp for the NaN-aware float{4,8}_* helpers and
  float{4,8}_cmp_internal() from utils/float.h =E2=80=94 same total order t=
he
  btree opclass already uses. No on-disk change.

  Bill

--000000000000e6e412065546e763
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">=C2=A0Hi all,<br><br>=C2=A0 I have a patch for this and `m=
ake check` passes (core + all contrib, plus<br>=C2=A0 new btree_gist NaN ca=
ses covering the three scenarios in the report).<br>=C2=A0 Posting here fir=
st in case someone is already further along =E2=80=94 if not,<br>=C2=A0 I&#=
39;ll send it to pgsql-hackers and register it in the open CF in a couple<b=
r>=C2=A0 of days.<br><br>=C2=A0 The fix swaps the five gbt_float{4,8}{gt,ge=
,eq,le,lt} comparators and<br>=C2=A0 gbt_float{4,8}key_cmp for the NaN-awar=
e float{4,8}_* helpers and<br>=C2=A0 float{4,8}_cmp_internal() from utils/f=
loat.h =E2=80=94 same total order the<br>=C2=A0 btree opclass already uses.=
 No on-disk change.<br><br>=C2=A0 Bill</div>

--000000000000e6e412065546e763--