MIME-Version: 1.0
References: <19460-5625143cef66012f@postgresql.org> <53936.1776633020@sss.pgh.pa.us>
 <CAMbWs48E2qqd4B6AdvJDyPBi685-_bDEvoe0aJnYzAPL1v30zg@mail.gmail.com>
 <81857.1776648374@sss.pgh.pa.us> <CAMbWs49PPxhrqBjHj3Wy4hK4=_DoHkJdAHL_q1mqpyyCk5MdMw@mail.gmail.com>
 <88899.1776652344@sss.pgh.pa.us> <CAMbWs4_nNfYktwQu4vNbienz+6oKXeE1Vzq9K_qH9F19MaJoMQ@mail.gmail.com>
 <418974.1776711680@sss.pgh.pa.us> <420865.1776712988@sss.pgh.pa.us> <458729.1776724816@sss.pgh.pa.us>
In-Reply-To: <458729.1776724816@sss.pgh.pa.us>
From: Richard Guo <guofenglinux@gmail.com>
Date: Tue, 21 Apr 2026 08:04:29 +0900
Message-ID: <CAMbWs4-GCupgqfKFX83UvPCBcV_kmZ8TzYrsi_qJUFovjEn1-A@mail.gmail.com>
Subject: Re: BUG #19460: FULL JOIN rewriting issue on empty queries
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-bugs@lists.postgresql.org, francois.jehl@pigment.com, 
	Robert Haas <robertmhaas@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAMbWs4-GCupgqfKFX83UvPCBcV_kmZ8TzYrsi_qJUFovjEn1-A%40mail.gmail.com>
Precedence: bulk

On Tue, Apr 21, 2026 at 7:40=E2=80=AFAM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Ah: equivclass.c doesn't mind letting em->em_relids be an alias
> for the left_relids or right_relids of some source RestrictInfo.
> That's not problematic as long as those are all constants after
> construction of the EquivalenceClass, but when remove_rel_from_eclass
> is trying to change things, it's a big problem.

ha, I just came to the same conclusion.

> This seems to do the trick to fix it, although I'm going to wait
> for a valgrind regression run to finish before deciding this
> is enough:

This seems safe enough to me.  LGTM.

- Richard