MIME-Version: 1.0
References: <1a96696c.9d3.187193989c3.Coremail.zhenmingyang@yeah.net>
In-Reply-To: <1a96696c.9d3.187193989c3.Coremail.zhenmingyang@yeah.net>
From: Richard Guo <guofenglinux@gmail.com>
Date: Mon, 27 Mar 2023 10:05:55 +0800
Message-ID: 
 <CAMbWs4817qLtBLNOM51VH=+tbkU42v4VaP_AgvMjurF_vO2-Cw@mail.gmail.com>
Subject: Re: A structure has changed but comment modifications maybe missed
To: =?UTF-8?B?55SE5piO5rSL?= <zhenmingyang@yeah.net>
Cc: pgsql-bugs@postgresql.org
Content-Type: multipart/alternative; boundary="000000000000947a1605f7d82f15"
Archived-At: 
 <https://www.postgresql.org/message-id/CAMbWs4817qLtBLNOM51VH%3D%2BtbkU42v4VaP_AgvMjurF_vO2-Cw%40mail.gmail.com>
Precedence: bulk

--000000000000947a1605f7d82f15
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 25, 2023 at 10:43=E2=80=AFPM =E7=94=84=E6=98=8E=E6=B4=8B <zhenm=
ingyang@yeah.net> wrote:

> Recently when I was reading the TupleTableSlot code, I noticed that the
> field "tts_tuple" mentioned in the comment has been removed in the higher
> version, but it still exists in the comment.
> location=EF=BC=9A
>
> https://github.com/postgres/postgres/blob/master/src/include/executor/tup=
table.h
> src/include/executor/tuptable.h=EF=BC=9A71
> src/include/executor/tuptable.h=EF=BC=9A271
>

Good catch.  This should be a minor oversight in 4da597ed, in which the
TupleTableSlot implementation has been splitted into different slot
types, and tts_tuple has been removed from TupleTableSlot struct.

Besides, at tuptable.h:71, I think TTS_SHOULDFREE should be
TTS_FLAG_SHOULDFREE.

Thanks
Richard

--000000000000947a1605f7d82f15
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=3D"gmail_quote"><div=
 dir=3D"ltr" class=3D"gmail_attr">On Sat, Mar 25, 2023 at 10:43=E2=80=AFPM =
=E7=94=84=E6=98=8E=E6=B4=8B &lt;<a href=3D"mailto:zhenmingyang@yeah.net">zh=
enmingyang@yeah.net</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex"><div style=3D"line-height:1.7;color:rgb(0,0,0);font-size=
:14px;font-family:Arial"><div style=3D"margin:0px">Recently when I was read=
ing the TupleTableSlot code, I noticed that the field &quot;tts_tuple&quot;=
 mentioned in the comment has been removed in the higher version, but it st=
ill exists in the comment.</div><div style=3D"margin:0px">location=EF=BC=9A=
</div><div style=3D"margin:0px"><a href=3D"https://github.com/postgres/post=
gres/blob/master/src/include/executor/tuptable.h" target=3D"_blank">https:/=
/github.com/postgres/postgres/blob/master/src/include/executor/tuptable.h</=
a></div><div style=3D"margin:0px"><span style=3D"color:rgb(110,119,129);fon=
t-family:ui-monospace,SFMono-Regular,&quot;SF Mono&quot;,Menlo,Consolas,&qu=
ot;Liberation Mono&quot;,monospace;font-size:12px;white-space:pre-wrap"> sr=
c/include/executor/tuptable.h=EF=BC=9A71</span></div><div style=3D"margin:0=
px"><span style=3D"color:rgb(110,119,129);font-family:ui-monospace,SFMono-R=
egular,&quot;SF Mono&quot;,Menlo,Consolas,&quot;Liberation Mono&quot;,monos=
pace;font-size:12px;white-space:pre-wrap"> src/include/executor/tuptable.h=
=EF=BC=9A271</span></div></div></blockquote><div>=C2=A0</div><div>Good catc=
h.=C2=A0 This should be a minor oversight in 4da597ed, in which the<br>Tupl=
eTableSlot implementation has been splitted into different slot<br>types, a=
nd tts_tuple has been removed from TupleTableSlot struct.<br><br>Besides, a=
t tuptable.h:71, I think TTS_SHOULDFREE should be<br>TTS_FLAG_SHOULDFREE.<b=
r><br>Thanks<br>Richard<br></div></div></div>

--000000000000947a1605f7d82f15--