MIME-Version: 1.0
References: <18589-70091cb81db1a3f1@postgresql.org>
 <CAMbWs4_nMJ8uXMxd8T7eUh3DbNa9DbNM9_CpuQN5Yk74SUaEEg@mail.gmail.com>
 <2906775.1724692311@sss.pgh.pa.us>
 <CAMbWs4_D7CVSxJVmQQA+5KWz9XxqOpEKgQvE9Pfoc8pXPwJNTw@mail.gmail.com>
 <3094457.1724769753@sss.pgh.pa.us> <3465444.1724871808@sss.pgh.pa.us>
In-Reply-To: <3465444.1724871808@sss.pgh.pa.us>
From: Richard Guo <guofenglinux@gmail.com>
Date: Thu, 29 Aug 2024 15:19:43 +0800
Message-ID: 
 <CAMbWs4_AP5Rrw8bc3N+E_fUVKc3_AWZexyWJRujRFyM-CcPyYg@mail.gmail.com>
Subject: Re: BUG #18589: pg_get_viewdef returns wrong query
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: tlhquynh@gmail.com, pgsql-bugs@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAMbWs4_AP5Rrw8bc3N%2BE_fUVKc3_AWZexyWJRujRFyM-CcPyYg%40mail.gmail.com>
Precedence: bulk

On Thu, Aug 29, 2024 at 3:03=E2=80=AFAM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I was just about to commit v2 when I realized that it's wrong, because
> what we need to be checking against is the output column name(s) that
> get_target_list() will print, and that's not necessarily tle->resname.
> You can in fact make v2 misbehave with ALTER VIEW RENAME COLUMN, as
> shown by the added test cases in attached v3.

Ah yes, we need to match the column name from the view's tuple
descriptor, which may differ from tle->resname after column RENAME.

+1 to v3.

Thanks
Richard