public inbox for [email protected]  

help / color / mirror / Atom feed
From: Nikita Malakhov <[email protected]>
To: Andrey Borodin <[email protected]>
Cc: Amit Langote <[email protected]>
Cc: Andrey Rachitskiy <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: BUG #19458: OOM killer in jsonb_path_exists_opr (@?) with malformed JSONPath containing non-existent variables
Date: Tue, 26 May 2026 14:17:45 +0300
Message-ID: <CAN-LCVPiBi9XXW__RorX=dH2_fANAMXhdbULmHFFg97F_0ubRw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAB8bMit1HvJsAasUYwmq+82Oa3zQhJyvsHNS4PGF_S_BCMnuVA@mail.gmail.com>
	<[email protected]>
	<CAN-LCVNh2z4EE+F21XPe7XRSWfPFtZx1WYAswpU5qs+RdR=jjg@mail.gmail.com>
	<[email protected]>

Hi!

Sorry for the late answer -  I missed this email.
No objections against backporting error throwing code, sorry if my
explanation
was not clear enough, of course OOM is very bad behavior and should be
corrected,
even if this would result in changes for some users (hopefully not).
My point in the previous message was only against silent mode.

Thanks!

On Thu, Apr 30, 2026 at 3:03 PM Andrey Borodin <[email protected]> wrote:

>
>
> > On 29 Apr 2026, at 01:19, Nikita Malakhov <[email protected]> wrote:
> >
> > According to the Jsonpath standard, malformed expression should return
> an error,
> > but not all cases of malformation are thoroughly described.
> >
> > When this functionality was developed (Jsonpath and SQL/JSON) the absence
> > of the variable was considered as malformation and was decided to throw
> an error
> > in threads long time ago. In case this behavior to be a subject for
> change it surely
> > should not be backported, but the error-throwing code has to.
>
> I think you just explained very well why we throw an error. Your arguments
> against
> silent mode are valid and we don't need to consider RETURN_ERROR any
> further.
>
> Current master behavior throws an error, in this thread author propose to
> backport it.
> This might be behavior change for some users. But it seems to me we have
> to backport,
> because
>
> SELECT '42'::jsonb @? '$"no_such_var"';
>
> should not return true. What do you think?
>
>
> Best regards, Andrey Borodin.



-- 
Regards,
Nikita Malakhov
Postgres Professional
The Russian Postgres Company
https://postgrespro.ru/


reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: BUG #19458: OOM killer in jsonb_path_exists_opr (@?) with malformed JSONPath containing non-existent variables
  In-Reply-To: <CAN-LCVPiBi9XXW__RorX=dH2_fANAMXhdbULmHFFg97F_0ubRw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox