MIME-Version: 1.0
References: <aSZ3RUjc7BVE6-9j@paquier.xyz> <CACTYHzjbVeKV289+TB1mg+tVmpnOJWrtezTvRjUwYoc875p1XA@mail.gmail.com>
 <CACTYHzjjssid_jtZiLh8BTYHAvnxbSLXceyGtxM3NB6Kfv510g@mail.gmail.com>
 <22D3D4EC-BCC3-4E52-B5A9-E1C6E363517B@yesql.se> <aTDWg-ezihyoelN3@paquier.xyz>
 <CACTYHzimf5+6gp6HzCerZpWh4o2_TW6-S3k3+2YK5mnoQa-+tg@mail.gmail.com>
 <aTIqMdS7QPdkcT29@paquier.xyz> <CACTYHzihgbTyYNQsEGcYmfkPd79r+_Jiz+PhN1xW+3NoJGEhyQ@mail.gmail.com>
 <aTeioHWzG2Wrwfcf@paquier.xyz> <4423e01f-1e52-4f47-a6ca-05cc8081c888@eisentraut.org>
 <aTfA-NG02qbk_uFD@paquier.xyz> <CACTYHzgb=1UXNoW08AjBBUB10dZPoAg4pptFm3K63V5xs=j=Jw@mail.gmail.com>
In-Reply-To: <CACTYHzgb=1UXNoW08AjBBUB10dZPoAg4pptFm3K63V5xs=j=Jw@mail.gmail.com>
From: Bilal Yavuz <byavuz81@gmail.com>
Date: Tue, 9 Dec 2025 15:47:13 +0300
Message-ID: <CAN55FZ03oW7zGiCgLfeiRxDQ5NLbyrppP1=mFpQ7QoDkbs84JA@mail.gmail.com>
Subject: Re: BUG #19095: Test if function exit() is used fail when linked static
To: VASUKI M <vasukim1992002@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Peter Eisentraut <peter@eisentraut.org>, 
	Daniel Gustafsson <daniel@yesql.se>, Tom Lane <tgl@sss.pgh.pa.us>, BharatDB <bharatdbpg@gmail.com>, 
	torsten.rupp@gmx.net, pgsql-bugs@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAN55FZ03oW7zGiCgLfeiRxDQ5NLbyrppP1%3DmFpQ7QoDkbs84JA%40mail.gmail.com>
Precedence: bulk

Hi,

On Tue, 9 Dec 2025 at 13:23, VASUKI M <vasukim1992002@gmail.com> wrote:
>
> Thanks Michael and Peter for the detailed reviews and for taking the time to refine and commit the updated version.
>
> Thanks for pointing out that pgperltidy may behave differently across environments.
>
> On Tue, 9 Dec 2025 at 11:56, Michael Paquier <michael@paquier.xyz> wrote:
>>
>> The attached takes care of the issue here.  Adding that to pgxs_bins
>> may look adapted at first glance, but I don't quite see the point in
>> exposing this information to PGXS, so pgxs_empty is a better fit?
>>
> Thanks for the clarification.Given that PGXS extensions don't appear to require NM ,IMO adding it to pgxs_empty makes sense to me.It resolves the Meson warning without exposing unnecessary variables to PGXS users.

I agree with both of you. We do the same thing for 'ZIC' binary, so I
think putting it to pgxs_empty is the correct fix.

-- 
Regards,
Nazir Bilal Yavuz
Microsoft