MIME-Version: 1.0
References: <aTDWg-ezihyoelN3@paquier.xyz> <CACTYHzimf5+6gp6HzCerZpWh4o2_TW6-S3k3+2YK5mnoQa-+tg@mail.gmail.com>
 <aTIqMdS7QPdkcT29@paquier.xyz> <CACTYHzihgbTyYNQsEGcYmfkPd79r+_Jiz+PhN1xW+3NoJGEhyQ@mail.gmail.com>
 <aTeioHWzG2Wrwfcf@paquier.xyz> <4423e01f-1e52-4f47-a6ca-05cc8081c888@eisentraut.org>
 <aTfA-NG02qbk_uFD@paquier.xyz> <CACTYHzgb=1UXNoW08AjBBUB10dZPoAg4pptFm3K63V5xs=j=Jw@mail.gmail.com>
 <CAN55FZ03oW7zGiCgLfeiRxDQ5NLbyrppP1=mFpQ7QoDkbs84JA@mail.gmail.com>
 <aTisqa86tuhsr8uP@paquier.xyz> <aTkBr1-x_vGRkbFj@paquier.xyz>
In-Reply-To: <aTkBr1-x_vGRkbFj@paquier.xyz>
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
Date: Tue, 17 Feb 2026 15:04:45 +0300
Message-ID: <CAN55FZ22rrN6gCn7urtmTR=_5z7ArZLUJu-TsMChdXwmRTaquA@mail.gmail.com>
Subject: Re: BUG #19095: Test if function exit() is used fail when linked static
To: Michael Paquier <michael@paquier.xyz>
Cc: VASUKI M <vasukim1992002@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, 
	Daniel Gustafsson <daniel@yesql.se>, Tom Lane <tgl@sss.pgh.pa.us>, BharatDB <bharatdbpg@gmail.com>, 
	torsten.rupp@gmx.net, pgsql-bugs@lists.postgresql.org
Content-Type: multipart/mixed; boundary="000000000000578bcf064b03e1e9"
Archived-At: <https://www.postgresql.org/message-id/CAN55FZ22rrN6gCn7urtmTR%3D_5z7ArZLUJu-TsMChdXwmRTaquA%40mail.gmail.com>
Precedence: bulk

--000000000000578bcf064b03e1e9
Content-Type: text/plain; charset="UTF-8"

Hi,

On Wed, 10 Dec 2025 at 08:14, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Dec 10, 2025 at 08:11:37AM +0900, Michael Paquier wrote:
> > On Tue, Dec 09, 2025 at 03:47:13PM +0300, Bilal Yavuz wrote:
> >> I agree with both of you. We do the same thing for 'ZIC' binary, so I
> >> think putting it to pgxs_empty is the correct fix.
> >
> > Thanks for double-checking.  I was not 100% sure if my analysis was
> > completely right as I was looking at this file for the first time.
>
> On top of the rest, I have double-checked the buildfarm and things
> seem fine with 4a8e6f43a6b5, so the last piece about pthread_exit() is
> now done with 8268e66ac64c.

In another thread [1], Andres pointed out that we need to create a
stamp file again although it exists. Otherwise, the stamp file will be
older than the inputs and it causes rebuilding. In Andres' own words
from [1]:

```
> +sub create_stamp_file
> +{
> +    # Avoid touching existing stamp file to prevent unnecessary rebuilds
> +    if (!(-f $stamp_file))
> +    {
> +        open my $fh, '>', $stamp_file
> +          or die "can't open $stamp_file: $!";
> +        close $fh;
> +    }
> +}

Won't that *cause* rebuilds? With a stamp file you normally want the stamp
file to be *newer* than the inputs. Which it won't be, if you don't touch it
here.

The only reason it doesn't cause quick rebuilds with meson is that ninja
remembers the timestamps of files an avoids rebuilds if they haven't changed.
```

Andres is right. We have the same problem on this libpq_check.pl,
attached fixes that.

[1] https://postgr.es/m/nxszznj6nkdj2vh5cxvwzpwodsbtui6mqluxnur2y4x7xtkirw%40fbvhy54mluzl

-- 
Regards,
Nazir Bilal Yavuz
Microsoft

--000000000000578bcf064b03e1e9
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="Fix-creating-stamp-file-in-the-libpq_check.pl.patch"
Content-Disposition: attachment; 
	filename="Fix-creating-stamp-file-in-the-libpq_check.pl.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mlqk1a4m0>
X-Attachment-Id: f_mlqk1a4m0

RnJvbSBhMmU0NmQyZGMxMGJkMzFkNjNjNmE2YmI0NDMzNGUwNjliMmE5NjA1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBOYXppciBCaWxhbCBZYXZ1eiA8YnlhdnV6ODFAZ21haWwuY29t
PgpEYXRlOiBUdWUsIDE3IEZlYiAyMDI2IDE0OjI3OjQzICswMzAwClN1YmplY3Q6IFtQQVRDSF0g
Rml4IGNyZWF0aW5nIHN0YW1wIGZpbGUgaW4gdGhlIGxpYnBxX2NoZWNrLnBsCgpXZSBkb24ndCBj
cmVhdGUgc3RhbXAgZmlsZXMgaWYgaXQgYWxyZWFkeSBleGlzdHMuIFRoaXMgaXMgd3JvbmcsIHN0
YW1wCmZpbGUgbmVlZHMgdG8gYmUgbmV3ZXIgdGhhbiB0aGUgaW5wdXRzLiBJZiB0aGUgc3RhbXAg
ZmlsZSBpcyBvbGRlciB0aGFuCnRoZSBpbnB1dHMsIGl0IHdpbGwgY2F1c2UgcmVidWlsZGluZy4K
ClJlcG9ydGVkLWJ5OiBBbmRyZXMgRnJldW5kIDxhbmRyZXNAYW5hcmF6ZWwuZGU+CkRpc2N1c3Np
b246IGh0dHBzOi8vcG9zdGdyLmVzL20vMTkwOTUtNmQ4MjU2ZDBjMzdkNGJlMkBwb3N0Z3Jlc3Fs
Lm9yZwotLS0KIHNyYy9pbnRlcmZhY2VzL2xpYnBxL2xpYnBxX2NoZWNrLnBsIHwgOSArKystLS0t
LS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZm
IC0tZ2l0IGEvc3JjL2ludGVyZmFjZXMvbGlicHEvbGlicHFfY2hlY2sucGwgYi9zcmMvaW50ZXJm
YWNlcy9saWJwcS9saWJwcV9jaGVjay5wbAppbmRleCA4YTJlMjliMmQ5YS4uODMzZjUzMTVjM2Mg
MTAwNzU1Ci0tLSBhL3NyYy9pbnRlcmZhY2VzL2xpYnBxL2xpYnBxX2NoZWNrLnBsCisrKyBiL3Ny
Yy9pbnRlcmZhY2VzL2xpYnBxL2xpYnBxX2NoZWNrLnBsCkBAIC0zMSwxMiArMzEsOSBAQCBkaWUg
IiQwOiAtLW5tIG11c3QgYmUgc3BlY2lmaWVkXG4iIHVubGVzcyBkZWZpbmVkICRubV9wYXRoIGFu
ZCAteCAkbm1fcGF0aDsKIAogc3ViIGNyZWF0ZV9zdGFtcF9maWxlCiB7Ci0JaWYgKCEoLWYgJHN0
YW1wX2ZpbGUpKQotCXsKLQkJb3BlbiBteSAkZmgsICc+JywgJHN0YW1wX2ZpbGUKLQkJICBvciBk
aWUgImNhbid0IG9wZW4gJHN0YW1wX2ZpbGU6ICQhIjsKLQkJY2xvc2UgJGZoOwotCX0KKwlvcGVu
IG15ICRmaCwgJz4nLCAkc3RhbXBfZmlsZQorCSAgb3IgZGllICJjYW4ndCBvcGVuICRzdGFtcF9m
aWxlOiAkISI7CisJY2xvc2UgJGZoOwogfQogCiAjIFNraXAgb24gV2luZG93cyBhbmQgU29sYXJp
cwotLSAKMi40Ny4zCgo=
--000000000000578bcf064b03e1e9--