MIME-Version: 1.0
References: <19533-413a1014e5d0e766@postgresql.org>
 <EC273387-5C73-4C9C-BF30-8BA260A90FFB@outlook.com>
 <CAMbWs4-6umOecRifmC88RW0SHWDAvb4c3-VD8XQ3NJufsUyUOQ@mail.gmail.com>
 <CAApHDvqHXZpF9pPStLqPp5O=G2gVpPD959bMTRRkLjdy4Tvx7g@mail.gmail.com>
 <CAApHDvoJ07GM6V2QWyJAgsJcM-dcFS+nwPq4Um=-NsXv5PmoCw@mail.gmail.com>
 <CANWCAZbiYQ+=CHAaftwp2x83Gy6tJCB8GUe15yO5DW-cpp0Mxg@mail.gmail.com>
 <CAApHDvrN-HL=dSBez=pme5RQKCiH7SrsMEFV-eQRJN3Vs94ZEQ@mail.gmail.com>
 <CANWCAZap+k7-E2f-XoC36Hk4izZjbN8w2c9OuomummGfZ5d20w@mail.gmail.com>
 <D1C82EBB-54F6-420E-9006-3A737B0E70A6@outlook.com>
 <CAApHDvpKHEZXVDsaAyJ9pAkX3KH34jC83spXPjJPyrtrsKk_HA@mail.gmail.com>
In-Reply-To: 
 <CAApHDvpKHEZXVDsaAyJ9pAkX3KH34jC83spXPjJPyrtrsKk_HA@mail.gmail.com>
From: John Naylor <johncnaylorls@gmail.com>
Date: Tue, 7 Jul 2026 12:11:01 +0700
Message-ID: 
 <CANWCAZYT8pusrf554FpM6NgjS3uWjEkaip9oXSRVc2iu2CEqgw@mail.gmail.com>
Subject: Re: BUG #19533: Wrong results from WindowAgg run-condition pushdown
 on count() with EXCLUDE CURRENT ROW
To: David Rowley <dgrowleyml@gmail.com>
Cc: Chengpeng Yan <chengpeng_yan@outlook.com>,
 Richard Guo <guofenglinux@gmail.com>,
	"imchifan@163.com" <imchifan@163.com>,
	"pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CANWCAZYT8pusrf554FpM6NgjS3uWjEkaip9oXSRVc2iu2CEqgw%40mail.gmail.com>
Precedence: bulk

On Mon, Jul 6, 2026 at 2:25=E2=80=AFPM David Rowley <dgrowleyml@gmail.com> =
wrote:
> Given how complex Claude's logic became to get all those cases
> correct, I now think the above is the best option. I've attached a
> patch for that.

Works for me. A tiny question on this comment change:

- /* No ORDER BY clause then all rows are peers */
...
+ /* No ORDER BY clause and RANGE mode means all rows are peers. */

Was the old comment wrong? Or are all rows still peers, but that's not
sufficient to show monotonicity?

--=20
John Naylor
Amazon Web Services