Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wA2F9-0020JX-0t for pgsql-bugs@arkaria.postgresql.org; Tue, 07 Apr 2026 08:57:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wA2F7-00Fz5H-2R for pgsql-bugs@arkaria.postgresql.org; Tue, 07 Apr 2026 08:57:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wA2F7-00Fz58-1d for pgsql-bugs@lists.postgresql.org; Tue, 07 Apr 2026 08:57:05 +0000 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wA2F6-000000010Eb-0n9e for pgsql-bugs@lists.postgresql.org; Tue, 07 Apr 2026 08:57:05 +0000 Received: by mail-qt1-x844.google.com with SMTP id d75a77b69052e-50d7c12e48eso28906671cf.1 for ; Tue, 07 Apr 2026 01:57:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775552223; cv=none; d=google.com; s=arc-20240605; b=SnSwgJROgfRMtHcnuv2FCIJZhCDXbs9L5+TY1KlQ53V7ETPOoYX5anYzbES1ax5ahB xBcIRaLx9z4P6GHedF4NGw03bO3RIFEoVryl8jRfxouzjtrL0Sa0Em0F5G0vbIFHkEsk jbNoB6vAKsz7AzJjKMpAcurJpLAmHJ175YRtJODC2D9M7pLIQmu3sR3mQ2z3lqsmYfhK /CZOZqtlynXKpYJKDnC821lWd+FhJ58FJl1OMMVcBf/LNX9xYIVYNwBvqFdINQaQ7GOn krP0CyLg2xsW56YsJm0l7qh74inLaRk5aYUneI90pz/C5kj3ntB9k2DZ2EAnNMoJAHI8 cPmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=2Hxo0cLGre5gZWDrpWYpgtCqOJe0fDPyStdpZ9e1pi8=; fh=ed2LJ6pc7GxjAmsmM6Rum/wCthhMxiCtKzJnZwNRM1o=; b=HLKslqLGc4OOcGnWHT+YvlU2n6GUpr3GxGLaYb0BvL7tRo3+i0O0DwGzNk4HMLjtZI WpShwwoVi6S07HCllAFrtk8OYg1qeS3MwxiG4nE8tupswCUgKyGUS3xna8vTFj9touPV tURk5Uwch62ALhDdpLKQeGyndb6LuPAZSPRkzD7xWEtHgNnXZTbtjhfjrFKpl+0Q8q4l ELlqhfdtu+0MtOAcxT8klkfdb/Cnb1WlfKYK5Co6l8orRp0430YjHesNED4Y9cxPnrBB YWLTl+Rq+vLmNG20FQa5W/z25YlYdYh/EbWgBOSuX/CB2HP4AJFzCBOuvab2x7UyCkxT LuTQ==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775552223; x=1776157023; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2Hxo0cLGre5gZWDrpWYpgtCqOJe0fDPyStdpZ9e1pi8=; b=OMtnUlFLbgNgRg2oLVgLgSuhap57OzVN8Zk5t2jt09GrFF2almV76Spr271dAZRC2f Eq25sQrKIefWkuW2ilInXlqKPvcKeu/KhIjpmUixVZgLXFjicucNuxb8ahblmg9Xuwic tEvadL4Km+cnySvKlaQuxjZdWRVBcovkGY64ND8pTGRi7bYjXrv7cjyAQW/lqpn5+nMs gjRGfZMhYZZrpuh7+IMlGV0iv9gXxm4eer6oRoTn0xs8Nx9UNPMHEV31TsExiyfa3ARR 8XZJRpJhqFYFz26VAPOlgcpK0VECip1D31xF2qgXqxzaChYy3e9mglSGilxdOI0vAf6Y Z8RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775552223; x=1776157023; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2Hxo0cLGre5gZWDrpWYpgtCqOJe0fDPyStdpZ9e1pi8=; b=b+Ye4l92AD6TSKwiwphC2selj2/9r76JHGXGnYrOb10j0y8e8KbGAE6FCyle0DG0rI oo8BPNlOOsiJz5pmsJaODsrmbx0xp7kNSKmh1NV73WbOV3IIilwnnSA3HFtQXkp7gKsd qUSmMJIH2KHHJK+8xcT1PrhwoLowVFD1RjOVd7LGdqcMOmfbpKC8piaxH2+14dB5TvO5 1Z7tAiwHAK6maPRzIoZhLVEXrABI6e9/MLHsD/vYAWXT2hL+KUuOjS6nTceW/3msdqSJ yeztHQYCH5T5f65xtHcICyKRBz9FUWNe9KM+4/xAWeH+kniE0VqrszhsDcfIYNXUeshG z/GQ== X-Forwarded-Encrypted: i=1; AJvYcCUxNL2lXOksHFUXCRAFnk+nyyqP+hc8iLmwF8CU8/I0xzFKv2sGvlXdP8G2AZ8Bq4LTT9jNL4hrhIqa@lists.postgresql.org X-Gm-Message-State: AOJu0YwIo77BXkfSkuizD2jJPgtGUDaGjSQmuB1UyUedM2/TEWczACzT IeEXl3FHNMoRf3uHzdrxscdTCUyJbWa93YNkpJODiDbokMa5bLUdjjqo7sfKTJUc3h0bbmnoQvm FG28j+fl40NmLHlBdJjvZ5E0PwrIy2Cc= X-Gm-Gg: AeBDievCfgX/FuxFmZjjwqOvT3/Wt3EsdbpezFIZ8Vk3XpzXDjUQIhaTuIVH8dPbRNU ogC8hY4nKOQMRh4R6ymt0DdNJb+VFvF8+rxmmPgTEZs/jxlNyjSCnBhNYUSwXI2EBUBDFf9gQhr 0bocegH/yWt11P5QY394KY3ENmHqbQNCKVTJrXSxsZeU5F2+8AwxZpJ2L4kczYG67SONcpuCCid shJKYQY51S6acUnts3Z3cmYEAM2GiAlTt/EffSPFSJhyrc3OwPL2gHh0Uo0AAZGzJUbmCF/M/HQ Lt4xE2KIE4PGSwAUcSXlx8/JYGPAro/gE9sp3neLk5GC2Y6lVercMdnWspaBTflo9eYFeu8LIOh 5BGslCQ7eIWhuevUUMXkbO1BNtP8= X-Received: by 2002:a05:622a:1788:b0:509:1657:a19d with SMTP id d75a77b69052e-50d4faa733amr240178841cf.15.1775552223468; Tue, 07 Apr 2026 01:57:03 -0700 (PDT) MIME-Version: 1.0 References: <19450-bb0612c50c6786e5@postgresql.org> <1197033.1775443854@sss.pgh.pa.us> <1199322.1775444878@sss.pgh.pa.us> In-Reply-To: <1199322.1775444878@sss.pgh.pa.us> From: John Naylor Date: Tue, 7 Apr 2026 15:56:51 +0700 X-Gm-Features: AQROBzA7vVsF9inDMTbsuWn8SHz405mkzegfI3h7XRTwqFOVi78s829M-VSP8jM Message-ID: Subject: Re: BUG #19450: Where is checksum_block.inc.c after master install? To: Tom Lane Cc: rekgrpth@gmail.com, pgsql-bugs@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Apr 6, 2026 at 10:07=E2=80=AFAM Tom Lane wrote: > > John Naylor writes: > > On Mon, Apr 6, 2026 at 9:50=E2=80=AFAM Tom Lane wro= te: > >> One could argue that the real bug is having put a .c file into > >> the include/ tree in the first place. Why was it done like that? > >> Couldn't it be a .h file? > > > That was the way it was first coded. I thought of this way to avoid > > adding an exception to headerscheck. I can reverse that decision > > easily, but I may not get to it today. > > Ah, the good ol' law of conservation of cruft. But on the whole > I think naming it .h not .c is less crufty. Agreed that there's > no great urgency about changing it. Okay, done that way as of commit 8c3e22a8f. --=20 John Naylor Amazon Web Services