Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w9a9z-001Yme-1h for pgsql-bugs@arkaria.postgresql.org; Mon, 06 Apr 2026 02:57:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w9a9y-006Cim-08 for pgsql-bugs@arkaria.postgresql.org; Mon, 06 Apr 2026 02:57:54 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w9a9x-006Cid-2Y for pgsql-bugs@lists.postgresql.org; Mon, 06 Apr 2026 02:57:54 +0000 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w9a9w-00000000mtF-0Nw8 for pgsql-bugs@lists.postgresql.org; Mon, 06 Apr 2026 02:57:53 +0000 Received: by mail-qt1-x844.google.com with SMTP id d75a77b69052e-50d6144877aso33100711cf.3 for ; Sun, 05 Apr 2026 19:57:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775444271; cv=none; d=google.com; s=arc-20240605; b=Lu4kkhcF4CMUicu+OCDniiDSsKiCgFIcvdWISABvA88nfclrN+mIV4ej6bBN1Zwg+1 qtklS7HEgHZKt6z886js0WSque3LluuVbp0PTUHhD7gFd6Ytu/4h848k/NNxGwgekIjG FemLtWIxAkmJYolnEJiSY1SwvW7Gw09JwpuVILPlHNAjFCZ9FgdN8g9V/ctFmkblTpj3 pwHFOWYBN/CPoxL/xNRXUwVKvMxztFovPlkpoqyqhj4QMkCWAJLNkfyYBSR/clOTE4Pc RmLYLVaaRmKuKVEx4UHouG84DPA1nIyjRHk6lSNw+sp2ffNN4zHTWMBqKKOINsg4ldUU Gc4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=EZxyTbDhnGK6XOUsK4BC1XxWK8x9sKOEc6EdNxMLOF4=; fh=NZjP94oeHSKov770yd9i5qGwOx33XmHjKQju3y5rk+U=; b=GmlsKCMUm9PcDHIMdRzABOjAXUE3+Tn3u6uqfFdM8/LH9IrEukglQiRBhnvmZyaH1Q rw11r6KFUUbeiWcXAQdW7Fo1Pkyx7TFTKQN0a3cAg2t2H+ef2djmf+5Jmymuy3EQcDUs PKaziasmS8tc2Lm1+dnrPmxVr9sH7HXb8r5/cX8+niSRZzREOxcAsxB5CIJR/kVc4B5U gJnm8nCtvGPy/O07yuCEqEuRNxj7v8qPRzfNiq0MkjyShmFnvHmWNjXVClqV0DioFV1V d3qGRzB/5wItCjUFAmphmTpjP3c+HtGqAxiAOMoZvOQHmWlo/jCOc3+sGN1tqIvajrtL ZEtQ==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775444271; x=1776049071; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EZxyTbDhnGK6XOUsK4BC1XxWK8x9sKOEc6EdNxMLOF4=; b=LJAVA0LEl8YGpO/GDSs+pUe7M6WirKUa1KZkxEv++gkyEKWZ750jKgAE18hIUjBCfC alllqGu0+DIM9MqOEiFZPIYUQBvBoHPElewciWGbHe6mmbegMaGgu9/avMaC8JHFWGAx azp+fAkeWsGu2UDd4deVjNOPb1S87GvHeF8/MGe5CG2e9x915Tz2GKDYTMshbyU/90/M Hw0R17LQOzpYNN6JGwy75VL0vKl3Wll4+2Qx1xisAIOaFezwPDCITXS8oQQKXR1p8Kwj N3OUk7dxmw4LOXfUT3DcfP64pTQe3ihiFH92Iv1a65jjemPAdmVsGoyx680uO66gUw5M OM4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775444271; x=1776049071; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EZxyTbDhnGK6XOUsK4BC1XxWK8x9sKOEc6EdNxMLOF4=; b=ahWytdjAIWNCcONC1iFIIFTyJlOj6aOD3N8aBmo9zRawMBU7JPkRdKXmVGTtP2+cyh QRKNlXYUSTu3H0iQ3EiLGH6UPcNlMd7WXl3J9By9so88v3JdMjz4er5MxFtzpW26lmeq 0RcPJZtnASAnO1n4V49Kg8GSGrdV7sOrupvbRovVUS+GYE98dT0VtBr5Tdmqiu6wnuiH V+KflX8JR8UWcavnTuQgPx2jKACRqORLHUV36FFg26eFYxRq25hd632ONbAGFEp39u0W R74nE5XVA067MxAo/I3MxzI+sBPVpUM5S9UNizhjVY5TJDa9DKznbx2WGr4ReVvzDsxh YFEQ== X-Forwarded-Encrypted: i=1; AJvYcCWWUbiFWYp4Cpg/gK0iSriTW64+D+Lbo/CaJbxj2Fot2iTaT5pgq1Mx+tlv9xKNFHOWfhLtG15qit7q@lists.postgresql.org X-Gm-Message-State: AOJu0Yy1G6HTCuWNitz3FqCyu7DwhaF7iOxYNelGGR6hW8LBHZAKhTqm XgHgdT6j6qlW2E85rsezTclTnoXvxp5h8vKcOCKM2+MWD1l+pW4NBPRAzqRDr6yAjB6le488z6H OXx9X/2EhtJDxniVWD5022Ce5yUwEbF0= X-Gm-Gg: AeBDies3+dL/XTKXxhsLayEvOxlsgy77XQzCX3h0tMc5OLPMC3uBggllv+tTCv4lXzl JHzWN4LhblH8I0WJV5fJmTUyv+sOJ5BgbGsu1uPG2MARgQZ7w36heG0Ibi1px7Z1z+Ns/+FnCIt sTJXdE3ztk/VgAyOqEtf/+WrjguAzxjFC7Bl6uqpI2qh1K7DweWCeR9r+pC77Alvk1d8fsQuSWB vYJxmvl7bv+qFygMPyG4RbbiemUsoBQRtQpRpdZg+Qirf/fMyLvf1lr6wNLh1+j6ekwoRvWYKaL Ve7307RqjaC/ZYv5fx3NhTIWVXYM+aclPshcGwUZoXnppRauK6dWe4Pcuh9wLGUrKZkE+v1zBAj s2tEZK2yK2OCp0OhXpTDCCb11Z1wRfDNqlrBU+w== X-Received: by 2002:a05:622a:aa4f:10b0:50b:4ccf:135e with SMTP id d75a77b69052e-50d62a6e291mr125981261cf.31.1775444271429; Sun, 05 Apr 2026 19:57:51 -0700 (PDT) MIME-Version: 1.0 References: <19450-bb0612c50c6786e5@postgresql.org> <1197033.1775443854@sss.pgh.pa.us> In-Reply-To: <1197033.1775443854@sss.pgh.pa.us> From: John Naylor Date: Mon, 6 Apr 2026 09:57:40 +0700 X-Gm-Features: AQROBzBcAqQCxg5OFTAjrWe-7x_DaQji47MOLQ06mXF_KzypBHKxcSkrXRSl4kg Message-ID: Subject: Re: BUG #19450: Where is checksum_block.inc.c after master install? To: Tom Lane Cc: rekgrpth@gmail.com, pgsql-bugs@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Apr 6, 2026 at 9:50=E2=80=AFAM Tom Lane wrote: > src/include/Makefile knows what it's supposed to install out > of that subtree, and it thinks storage/*.h is sufficient. > I didn't check to see if the meson system has the same oversight. > > One could argue that the real bug is having put a .c file into > the include/ tree in the first place. Why was it done like that? > Couldn't it be a .h file? That was the way it was first coded. I thought of this way to avoid adding an exception to headerscheck. I can reverse that decision easily, but I may not get to it today. --=20 John Naylor Amazon Web Services