MIME-Version: 1.0
References: <f7fe39b3-7e99-4939-8852-07350549161d@hrz.tu-chemnitz.de>
 <CAOYmi+=e9bQQa1jgLqZ18m5w-7KA44VeL9FON6i2gd8bi=d5Jw@mail.gmail.com>
 <CAOYmi+kac3wEE3iqxHfHCNd_n2i-Or=n+Qk8_G24UZn2uz3DyQ@mail.gmail.com> <1309665.1776885833@sss.pgh.pa.us>
In-Reply-To: <1309665.1776885833@sss.pgh.pa.us>
From: Jacob Champion <jacob.champion@enterprisedb.com>
Date: Wed, 22 Apr 2026 15:10:31 -0700
Message-ID: <CAOYmi+=ezP7DSyTKh9xy3ejTxydrVicBYBYeoVZOWgYvAyjDxA@mail.gmail.com>
Subject: Re: PostgreSQL 17: Bug in libpq when libpq is dlopened/closed
 multiple times
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, 
	Daniel Schreiber <daniel.schreiber@hrz.tu-chemnitz.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAOYmi%2B%3DezP7DSyTKh9xy3ejTxydrVicBYBYeoVZOWgYvAyjDxA%40mail.gmail.com>
Precedence: bulk

On Wed, Apr 22, 2026 at 12:23=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wrote=
:
> I agree that we have no real ability to guarantee that.
> Still, as far as the presented patch goes, it seems like a clear
> win so I'd vote for fix-and-backpatch.

Sounds good to me.

> Should we write the arguments as BIO_TYPE_NONE | BIO_TYPE_SOURCE_SINK
> rather than just BIO_TYPE_SOURCE_SINK?

Good question... Popularity-wise, the shorter spelling shows up across
quite a few projects on GitHub, but the only spelling of
`BIO_meth_new(BIO_TYPE_NONE | ...)` that I can find is a single place
inside OpenSSL's own test suite -- which also uses the shorter
alternative, in two places. So my vote is BIO_TYPE_SOURCE_SINK; we'll
be in good company.

Thanks,
--Jacob