MIME-Version: 1.0
References: <CAEcQ1bYR9s4eQLFDjzzJHU8fj-MTbmRpW-9J-r2gsCn+HEsynw@mail.gmail.com>
 <CAP53Pky1575W1euSUwj2Zc5b0kBFZqpNuvMOGCvU_bR1tmD7zA@mail.gmail.com>
 <178e0d90-26d9-4c3a-9448-2f64f0d35dc8@iki.fi> <56D5EAF1-1636-45EC-97FB-3A08260417D2@yesql.se>
 <2ca9a413-fe96-4c96-9781-2e85d876afd1@iki.fi>
In-Reply-To: <2ca9a413-fe96-4c96-9781-2e85d876afd1@iki.fi>
From: Lukas Fittl <lukas@fittl.com>
Date: Fri, 27 Mar 2026 08:25:47 -0700
Message-ID: <CAP53PkwciXaP2TQLjkjLGHD1+HEtBfCcpfd25xCnGbgQErpocA@mail.gmail.com>
Subject: Re: Memory leak in pg_stat_statements when qtext file contains
 invalid encoding
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Daniel Gustafsson <daniel@yesql.se>, Gaurav Singh <gaurav.singh@yugabyte.com>, 
	pgsql-bugs@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAP53PkwciXaP2TQLjkjLGHD1%2BHEtBfCcpfd25xCnGbgQErpocA%40mail.gmail.com>
Precedence: bulk

On Fri, Mar 27, 2026 at 4:13=E2=80=AFAM Heikki Linnakangas <hlinnaka@iki.fi=
> wrote:
>
> On 27/03/2026 11:05, Daniel Gustafsson wrote:
> >> On 27 Mar 2026, at 09:59, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> >
> >> Hmm, perhaps. But there's a simpler, less invasive fix. When that code=
 was written, we didn't have MCXT_ALLOC_HUGE nor MCXT_ALLOC_NO_OOM. Now tha=
t we do, we can just use palloc_extended(MCXT_ALLOC_HUGE | MCXT_ALLOC_NO_OO=
M) instead of raw malloc(). Per attached.
> >
> > LGTM.
>
> Committed, thanks!

Thanks for the quick fix!

TIL about MCXT_ALLOC_NO_OOM, that's useful to know about.

Thanks,
Lukas

--=20
Lukas Fittl