public inbox for [email protected]  

help / color / mirror / Atom feed

From: Lukas Fittl <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: Ayush Tiwari <[email protected]>
Cc: Sami Imseih <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Andres Freund <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Subject: Re: BUG #19520: PANIC when concurrently manipulating stored procedures with pg_stat_statements and track_functions =
Date: Sat, 20 Jun 2026 09:45:05 -0700
Message-ID: <CAP53PkyBPpzGeAukc2BSp8m+K1p7PB7QjhfkQtYPhyR5VsW64A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

On Sat, Jun 20, 2026 at 5:16 AM Michael Paquier <[email protected]> wrote:
>
> On Sat, Jun 20, 2026 at 01:09:59PM +0200, Alvaro Herrera wrote:
> > I think a better answer is to just not introduce the ABI change in
> > stable branches.  That is, I think we should add a shim function so that
> > the third-party extensions can continue to use the original ABI; and
> > only in master you clean that up with a different API, whereby the
> > extension will be forced to have an #ifdef block for the 19 version or
> > the older versions, but that's fine because the extension has to be
> > recompiled for the new major version anyway so the end-user won't be
> > affected on a minor upgrade.
>
> If you feel strongly about it, we could just do something like the
> attached in the v15-v18 range.  This introduces a new routine called
> pgstat_drop_entry_ext() that gains the new argument "missing_ok", and
> pgstat_drop_entry() would be an ABI-compatible wrapper calling it.
>
> What do you think?

As the developer of the extension in the picture, I was actually
surprised to see the commit making an ABI *and* API breaking change
(and I think with cumulative stats being pluggable in 18, we can
expect people to use public stats functions like pgstat_drop_entry in
extensions), precisely because of the issues Alvaro mentioned.

I think doing it with a new routine is what I would have expected to
happen to preserve API and ABI compatibility, and your follow-up patch
looks good to me.

Thanks,
Lukas


--
Lukas Fittl

view thread (17+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: BUG #19520: PANIC when concurrently manipulating stored procedures with pg_stat_statements and track_functions =
  In-Reply-To: <CAP53PkyBPpzGeAukc2BSp8m+K1p7PB7QjhfkQtYPhyR5VsW64A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox