MIME-Version: 1.0
References: <e3a78e44-ec6c-5924-7832-63de3aad3e9b@gmail.com>
 <CAPpHfdtZxhgjZTpaLd--dCxzUOL6tN+aAZPBeTsGKHLkMQAZpw@mail.gmail.com>
 <CAPpHfdu412Z+jh5Oyc1yzWFM0+52h0kSGQKV4=xQ0aT0UeY2BA@mail.gmail.com>
 <CAPpHfdspqdzVdEU2qHMibKn8OwVuLoZZYvKm-m5Ffqy2aMXgGQ@mail.gmail.com>
 <7ckc7oka4bvafkf5bwlqs6ygrhlsbhz25ppozfch7zbuxcx3rf@e4pr4oqenalc>
 <DA0695AB-4A40-4272-BE64-D22F81F7713B@yandex-team.ru>
 <c64tbgvkqu6v5y66lkitiy6dd32ksrwz3nysbclqnyztstx2lj@ymw4bqsf7zpv>
 <71E42FAF-FF92-4EE5-94A5-341EFB891281@yandex-team.ru>
 <CAPpHfdsoVkyAwTr4E6pt0O42Cchxy3JuCzBWesxv03KmxAyP4A@mail.gmail.com>
 <13F0EC76-00B9-41D7-8EC3-D1F07FF7C66B@yandex-team.ru>
 <af5smncUA1MzXNxa@paquier.xyz>
 <06434787-C6A1-4551-A2C3-F86DC892601B@yandex-team.ru>
In-Reply-To: <06434787-C6A1-4551-A2C3-F86DC892601B@yandex-team.ru>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Tue, 12 May 2026 13:22:59 +0300
Message-ID: 
 <CAPpHfdtBHt=BBaQX73D-cVhiKn4SUWF4fMLedqF0nEZzBNqL4w@mail.gmail.com>
Subject: Re: [BUG] false positive in bt_index_check in case of short 4B
 varlena datum
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>,
	Alexander Lakhin <exclusion@gmail.com>,
 Michael Zhilin <m.zhilin@postgrespro.ru>, pgsql-bugs@postgresql.org,
	Yura Sokolov <y.sokolov@postgrespro.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAPpHfdtBHt%3DBBaQX73D-cVhiKn4SUWF4fMLedqF0nEZzBNqL4w%40mail.gmail.com>
Precedence: bulk

On Tue, May 12, 2026 at 12:17=E2=80=AFPM Andrey Borodin <x4mmm@yandex-team.=
ru> wrote:
> > On 9 May 2026, at 04:07, Michael Paquier <michael@paquier.xyz> wrote:
> >
> > On Mon, May 04, 2026 at 10:20:04AM +0500, Andrey Borodin wrote:
> >> However, I'd like to note that (VARSIZE_1B() < TOAST_INDEX_TARGET) is
> >> constantly true for 8Kb+ pages.
> >
> > How much slower?  I cannot imagine that it matters much in this code
> > path, but you are getting me worried.
>
>
> I think there will be no performance difference.
>
> Change proposed by Alexander only prevents use of VARSIZE() against datum
> that is VARSIZE_1B. AFAICS no actual behavior would change.
>
> On some occasions we would have to normilize less tuples.

Any objections if I push and backpatch this?

------
Regards,
Alexander Korotkov
Supabase