Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Mon, 22 May 2023 12:04:58 -0500
Message-Id: <CSSYXFI3JCDF.1RO2ES99IT2GH@c3po>
To: "Alvaro Herrera" <alvherre@alvh.no-ip.org>, <dastapov@gmail.com>,
 <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17698: On SIGTERM, psql terminates, but leaves the
 statement running
From: "Tristan Partin" <tristan@neon.tech>
References: <17698-58a6ab8caec496b0@postgresql.org>
 <20230116151459.fzg6mlegkcrzch4i@alvherre.pgsql>
In-Reply-To: <20230116151459.fzg6mlegkcrzch4i@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/CSSYXFI3JCDF.1RO2ES99IT2GH%40c3po>
Precedence: bulk

On Mon Jan 16, 2023 at 9:14 AM CST, Alvaro Herrera wrote:
> On 2022-Nov-25, PG Bug reporting form wrote:
>
> > Reproduction: start psql, launch a query that will take a while (I
> > used 'select pg_sleep(1234)'), then from another terminal do
> > "kill -TERM <pid of psql>".  Psql would be terminated, but query would
> > not be, and will keep running until TCP timeout kicks in and kills the
> > stale connection.
> >=20
> > SIGINT, on the other hand, will cause psql will terminate the current
> > statement.
> >=20
> > Perhaps psql could have a SIGTERM handler that does roughly what
> > SIGINT handler does before terminating the whole process, and would
> > cancel the current statement (if any)?
>
> Sure.  I doubt we want to wait until a reply to the cancel request is
> obtained, but we could have the sigterm handler at least send it before
> terminating.

I am currently working on a patch for this.

--=20
Tristan Partin
Neon (https://neon.tech)