Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9loT-0001zP-Ar for pgsql-bugs@arkaria.postgresql.org; Thu, 15 Jun 2023 12:10:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q9loQ-0008Tl-L4 for pgsql-bugs@arkaria.postgresql.org; Thu, 15 Jun 2023 12:10:50 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9TZV-0007Ce-EY for pgsql-bugs@lists.postgresql.org; Wed, 14 Jun 2023 16:42:13 +0000 Received: from mail-oo1-xc2d.google.com ([2607:f8b0:4864:20::c2d]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1q9TZO-002BkT-98 for pgsql-bugs@lists.postgresql.org; Wed, 14 Jun 2023 16:42:12 +0000 Received: by mail-oo1-xc2d.google.com with SMTP id 006d021491bc7-559409cc490so747174eaf.3 for ; Wed, 14 Jun 2023 09:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon-tech.20221208.gappssmtp.com; s=20221208; t=1686760926; x=1689352926; h=in-reply-to:references:message-id:from:to:subject:cc:date :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ni2tPXKdGCkJd5wNbObIgOgzIWZJGm+SZMzB2rhRiZk=; b=3ZoJdK+/DU1WtlS6b0w8aj214/fQd+5pYsGALiZdCXpiURMz+G4pw+pwpVWso3WD89 qCtgHH9JxFqNL8SppB4GhjfNZzZbTmTBWSn9W9YgM+vz6HXnlxiA1dSzlMMRz9HPfegJ s/8B3lNAaHhON52T/qkFGtFLD61fzmd/zYVDSV4LydmaEei1eVdfUlktAZfTZEYMGFXc T/4olt+3B1kueanIqK2z0/Yw/ptHMtXNjTgQzQ64PfxZpsFQrF7gHp91m+VRi/Gjl894 pda8WfyabVSOBl1AQKbbcE9YZz5VsqOCKFr9EtbaWT07j5KhN81yxudcL+KVkWNULrTx xrbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686760926; x=1689352926; h=in-reply-to:references:message-id:from:to:subject:cc:date :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ni2tPXKdGCkJd5wNbObIgOgzIWZJGm+SZMzB2rhRiZk=; b=TuxzaEA8jpUPjCG+C99W/Mx7wgU/k6kaAEncLEq7Zr0Bi7N/y7xirMXbozPdA2t0hL kUO8pjGRie4Qx2P3/L2eMrwZJ20Ttkg5U8a53YbN+6CYlVrqhrcKpabKbjs5puwd9ive ApmfNAkASqDGsL/bQC1zWvg4gpazq4N/UeK9I41zPx2XzcRLvoGx5Hq1zfQeTQOKMHON Akvg0R5lIYwlW68N+CgUjOTlLdSxrsVJhCQlnzGWwXyQTH7K6cEZON83a9dETuPFdI6+ PAC35eEoTmQ8prdjZ8sOGBKijMMW68UoczAfRUHW825FAwf3aQPwRwKLGorrVJmZHNHW ZBHg== X-Gm-Message-State: AC+VfDzC4sK9MofvOx7YnZNcf9MqG7U7lOXjIJKbvC4kXWlGiZY/+HjJ SybLgw74fqUzkFpMDhefpXlBSQ== X-Google-Smtp-Source: ACHHUZ4HPZcgdgIK4ixM+lj5EHEyd70kGEq5s68PrFrfygDfkrUeaw87U4sS/zNuOUchfrrU2ddJrQ== X-Received: by 2002:a4a:ca15:0:b0:558:b793:f10c with SMTP id w21-20020a4aca15000000b00558b793f10cmr9628783ooq.3.1686760925680; Wed, 14 Jun 2023 09:42:05 -0700 (PDT) Received: from localhost ([2607:fb90:e696:c1dc:3996:e070:71ee:42fb]) by smtp.gmail.com with ESMTPSA id q15-20020a4ae64f000000b0055b05526722sm1446998oot.20.2023.06.14.09.42.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 09:42:04 -0700 (PDT) Content-Type: multipart/mixed; boundary=f062a10e3146b47fd58e9862ab36bc5c4e332ebd74b686190746d117b613 Mime-Version: 1.0 Date: Wed, 14 Jun 2023 11:42:03 -0500 Cc: , , "Tom Lane" , Subject: Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG To: "Heikki Linnakangas" , "Joe Conway" From: "Tristan Partin" Message-Id: X-Mailer: aerc 0.15.2-46-g263d8cbec504 References: <17946-3e84cb577e9551c3@postgresql.org> <1564676.1685043220@sss.pgh.pa.us> <555bb26e-c27c-ab65-028f-3fd5b82df9de@iki.fi> <5676b739-0854-f924-4b97-466e3504c692@joeconway.com> <665279.1686422574@sss.pgh.pa.us> <574a1afa-5c6e-829c-0fed-a9ff44719f9f@joeconway.com> <49dfcad8-90fa-8577-008f-d142e61af46b@iki.fi> In-Reply-To: <49dfcad8-90fa-8577-008f-d142e61af46b@iki.fi> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --f062a10e3146b47fd58e9862ab36bc5c4e332ebd74b686190746d117b613 Content-Type: multipart/alternative; boundary=4e43fc96176fb1f07cc1d757dc2e07ce9c06d449d46e9081a318ac5c3640 --4e43fc96176fb1f07cc1d757dc2e07ce9c06d449d46e9081a318ac5c3640 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Content-Type: text/plain; charset=UTF-8 On Mon Jun 12, 2023 at 4:13 AM CDT, Heikki Linnakangas wrote: > There are a few uselocale() calls in ecpg, and they are protected by=20 > HAVE_USELOCALE. Interestingly, the calls in pg_locale.c are not, but=20 > they are protected by HAVE_LOCALE_T. Seems a little inconsistent. Patch is attached. CC-ing hackers. --=20 Tristan Partin Neon (https://neon.tech) --4e43fc96176fb1f07cc1d757dc2e07ce9c06d449d46e9081a318ac5c3640-- --f062a10e3146b47fd58e9862ab36bc5c4e332ebd74b686190746d117b613 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=v1-0001-Make-uselocale-protection-more-consistent.patch Content-Type: text/x-patch; charset=utf-8; name=v1-0001-Make-uselocale-protection-more-consistent.patch RnJvbSAwMmEyY2RiODM0MDViNWFlY2FlYzJhZjAyZTM3OWE4MTE2MWY4MzcyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUcmlzdGFuIFBhcnRpbiA8dHJpc3RhbkBuZW9uLnRlY2g+CkRh dGU6IFdlZCwgMTQgSnVuIDIwMjMgMTE6MzY6MDAgLTA1MDAKU3ViamVjdDogW1BBVENIIHYxXSBN YWtlIHVzZWxvY2FsZSBwcm90ZWN0aW9uIG1vcmUgY29uc2lzdGVudAoKSW4gZWNwZywgdXNlbG9j YWxlIHVzZXMgYXJlIHByb3RlY3RlZCBieSBjaGVja2luZyBpZiBIQVZFX1VTRUxPQ0FMRSBpcwpk ZWZpbmVkLiBVc2UgdGhlIHNhbWUgY2hlY2sgaW4gcGdfbG9jYWxlLmMuIFNpbmNlIEhBVkVfVVNF TE9DQUxFIGltcGxpZXMKSEFWRV9MT0NBTEVfVCwgdGhlIGNvZGUgc2hvdWxkIGJlIHRoZSBzYW1l IG9uIF9hbGxfIHBsYXRmb3JtcyB0aGF0ClBvc3RncmVzIHN1cHBvcnRzLiBPdGhlcndpc2UsIEkg YW0gc3VyZSB0aGVyZSB3b3VsZCBoYXZlIGJlZW4gYSBidWcKcmVwb3J0IHdpdGggcGdfbG9jYWxl LmMgZmFpbGluZyB0byBidWlsZCBkdWUgdG8gdGhlIHN5c3RlbSBoYXZpbmcKbG9jYWxlX3QsIGJ1 dCBub3QgdXNlbG9jYWxlLgotLS0KIHNyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ19sb2NhbGUuYyB8 IDE2ICsrKysrKysrLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDgg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvdXRpbHMvYWR0L3BnX2xvY2Fs ZS5jIGIvc3JjL2JhY2tlbmQvdXRpbHMvYWR0L3BnX2xvY2FsZS5jCmluZGV4IDMxZTNiMTZhZTAu LjM1ODVhZmIyOTggMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ19sb2NhbGUu YworKysgYi9zcmMvYmFja2VuZC91dGlscy9hZHQvcGdfbG9jYWxlLmMKQEAgLTI5NzIsNyArMjk3 Miw3IEBAIHdjaGFyMmNoYXIoY2hhciAqdG8sIGNvbnN0IHdjaGFyX3QgKmZyb20sIHNpemVfdCB0 b2xlbiwgcGdfbG9jYWxlX3QgbG9jYWxlKQogCX0KIAllbHNlCiAJewotI2lmZGVmIEhBVkVfTE9D QUxFX1QKKyNpZmRlZiBIQVZFX1VTRUxPQ0FMRQogI2lmZGVmIEhBVkVfV0NTVE9NQlNfTAogCQkv KiBVc2Ugd2NzdG9tYnNfbCBmb3Igbm9uZGVmYXVsdCBsb2NhbGVzICovCiAJCXJlc3VsdCA9IHdj c3RvbWJzX2wodG8sIGZyb20sIHRvbGVuLCBsb2NhbGUtPmluZm8ubHQpOwpAQCAtMjk4NCwxMSAr Mjk4NCwxMSBAQCB3Y2hhcjJjaGFyKGNoYXIgKnRvLCBjb25zdCB3Y2hhcl90ICpmcm9tLCBzaXpl X3QgdG9sZW4sIHBnX2xvY2FsZV90IGxvY2FsZSkKIAogCQl1c2Vsb2NhbGUoc2F2ZV9sb2NhbGUp OwogI2VuZGlmCQkJCQkJCS8qIEhBVkVfV0NTVE9NQlNfTCAqLwotI2Vsc2UJCQkJCQkJLyogIUhB VkVfTE9DQUxFX1QgKi8KLQkJLyogQ2FuJ3QgaGF2ZSBsb2NhbGUgIT0gMCB3aXRob3V0IEhBVkVf TE9DQUxFX1QgKi8KKyNlbHNlCQkJCQkJCS8qICFIQVZFX1VTRUxPQ0FMRSAqLworCQkvKiBDYW4n dCBoYXZlIGxvY2FsZSAhPSAwIHdpdGhvdXQgSEFWRV9MT0NBTEVfVCwgd2hpY2ggSEFWRV9VU0VM T0NBTEUgaW1wbGllcyAqLwogCQllbG9nKEVSUk9SLCAid2NzdG9tYnNfbCBpcyBub3QgYXZhaWxh YmxlIik7CiAJCXJlc3VsdCA9IDA7CQkJCS8qIGtlZXAgY29tcGlsZXIgcXVpZXQgKi8KLSNlbmRp ZgkJCQkJCQkvKiBIQVZFX0xPQ0FMRV9UICovCisjZW5kaWYJCQkJCQkJLyogSEFWRV9VU0VMT0NB TEUgKi8KIAl9CiAKIAlyZXR1cm4gcmVzdWx0OwpAQCAtMzA0OSw3ICszMDQ5LDcgQEAgY2hhcjJ3 Y2hhcih3Y2hhcl90ICp0bywgc2l6ZV90IHRvbGVuLCBjb25zdCBjaGFyICpmcm9tLCBzaXplX3Qg ZnJvbWxlbiwKIAkJfQogCQllbHNlCiAJCXsKLSNpZmRlZiBIQVZFX0xPQ0FMRV9UCisjaWZkZWYg SEFWRV9VU0VMT0NBTEUKICNpZmRlZiBIQVZFX01CU1RPV0NTX0wKIAkJCS8qIFVzZSBtYnN0b3dj c19sIGZvciBub25kZWZhdWx0IGxvY2FsZXMgKi8KIAkJCXJlc3VsdCA9IG1ic3Rvd2NzX2wodG8s IHN0ciwgdG9sZW4sIGxvY2FsZS0+aW5mby5sdCk7CkBAIC0zMDYxLDExICszMDYxLDExIEBAIGNo YXIyd2NoYXIod2NoYXJfdCAqdG8sIHNpemVfdCB0b2xlbiwgY29uc3QgY2hhciAqZnJvbSwgc2l6 ZV90IGZyb21sZW4sCiAKIAkJCXVzZWxvY2FsZShzYXZlX2xvY2FsZSk7CiAjZW5kaWYJCQkJCQkJ LyogSEFWRV9NQlNUT1dDU19MICovCi0jZWxzZQkJCQkJCQkvKiAhSEFWRV9MT0NBTEVfVCAqLwot CQkJLyogQ2FuJ3QgaGF2ZSBsb2NhbGUgIT0gMCB3aXRob3V0IEhBVkVfTE9DQUxFX1QgKi8KKyNl bHNlCQkJCQkJCS8qICFIQVZFX1VTRUxPQ0FMRSAqLworCQkJLyogQ2FuJ3QgaGF2ZSBsb2NhbGUg IT0gMCB3aXRob3V0IEhBVkVfTE9DQUxFX1QsIHdoaWNoIEhBVkVfVVNFTE9DQUxFIGltcGxpZXMg Ki8KIAkJCWVsb2coRVJST1IsICJtYnN0b3djc19sIGlzIG5vdCBhdmFpbGFibGUiKTsKIAkJCXJl c3VsdCA9IDA7CQkJLyoga2VlcCBjb21waWxlciBxdWlldCAqLwotI2VuZGlmCQkJCQkJCS8qIEhB VkVfTE9DQUxFX1QgKi8KKyNlbmRpZgkJCQkJCQkvKiBIQVZFX1VTRUxPQ0FMRSAqLwogCQl9CiAK IAkJcGZyZWUoc3RyKTsKLS0gClRyaXN0YW4gUGFydGluCk5lb24gKGh0dHBzOi8vbmVvbi50ZWNo KQoK --f062a10e3146b47fd58e9862ab36bc5c4e332ebd74b686190746d117b613--