Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tyP9l-006GCX-Nv for pgsql-bugs@arkaria.postgresql.org; Sat, 29 Mar 2025 05:54:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tyP9j-005NKT-S7 for pgsql-bugs@arkaria.postgresql.org; Sat, 29 Mar 2025 05:54:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tyP9j-005NIP-FN for pgsql-bugs@lists.postgresql.org; Sat, 29 Mar 2025 05:54:55 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tyP9h-001kPq-2J for pgsql-bugs@lists.postgresql.org; Sat, 29 Mar 2025 05:54:54 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-223fd89d036so66805675ad.1 for ; Fri, 28 Mar 2025 22:54:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743227693; x=1743832493; darn=lists.postgresql.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :mime-version:sender:from:to:cc:subject:date:message-id:reply-to; bh=kYPtza7LkJqX+rQMdXp31FreeXkrVtmb7K/ljaMMr1w=; b=dfLL48DLakgQlzs93l+ciK6vcQxzE4afYTHTZZs1FzyEfg6f88jrHNakqgiThNBDXP 4Vq1s9QWGFpGBONF2j3NSl5QKmAdyUe6W1H7+z2q3dRsQnBr+S8kyWg2Q43P39FrqhtI KZ34OtEVpZ/47tOJVAEfgJfNiIwzYMpFc7rdahQDtxJsZd89ARWyE7q7ei3yesWGLm8V qdqdFjZlOyRuM3fCGgWloXZxgOqYuFURi/YWGOMtxwvdQ1C111fUp9VAIN+ISEMGarWX XasrNoT0w3XOkBk4hamjh+0P+gJcYBiHOTAmKaF/iKctxiHZ9+lmOXAkQaFwnsQMJx97 A64w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743227693; x=1743832493; h=in-reply-to:references:to:from:subject:cc:message-id:date :mime-version:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kYPtza7LkJqX+rQMdXp31FreeXkrVtmb7K/ljaMMr1w=; b=eyKJ8ELefUdNaWoz6fWyhPOnm5TndVOQS3iqU9qopinfRiCmvASnaecgiyXjoujC9h whEzCtkq9N9bG8mlTOj1VQw7oRA9q+Sd8nLMtBMvcWfmW0vElm0HjbnhbO2NGVK+ZUEZ b9L3zNWylmGKVe4UMJCTkR4RCLsVK8vvD5v12ISk3jYngsHTr+6UJ2O//Yxdpxnjm5q+ awDf9U1yNwOmat4avqJJKUe3+cMjc3zZHEaeQEDWrUmO77K2RoUSoOz69LMHIZCc1I2B nbPGk431tH9DfaQuymVz06MhXRM0umKnAJ9q+Lxw3JlOozoEz6ALb/1chHo7KDdtbPiZ Hi+Q== X-Forwarded-Encrypted: i=1; AJvYcCWaVWRF2nnbjBUSEHeX5fsfdsIHh6IRPa1fb/HpLZuJYEBg21ZJbsIE93YFFdQr6JWnqClYpuOuylvn@lists.postgresql.org X-Gm-Message-State: AOJu0YwBrcF5KCG91BSO4iELAd3ElWAJXqNgp5CIuRffaCYekvTBbqiU mf54RuiO8Ie8HyW238jknUGBFdQcbUEhS9Vr1hzLCJF8uvx9s7m0ApmoBw== X-Gm-Gg: ASbGnctqPLQP4kFFr4856hA73qpkP7DiwNv8b+4i+jlgaAYvqRl/9rzvdehD0kOGNpS LfZg9HvRtHHhwrdfQJEQZhDA3YKnP0d/bAXhDy1mZdqbYUn+LYjYr523dqTBcOpGu4biklbmuSi FT6QW5HJEyHebrue3Pf4Moxiioz12pGUOPsCVYMBalVN8TUcC/N3GBiVM8362KYkapqokIYDeLG ZDuZWNZ8nM5NGacyYq3I0g6YqZLWUpJlCgSAFgJscsXfF0cW7NOwLNS8G9vfZJmRc/f5W4Sz16s ljzf/LKql1J0FhWhyfQZxsUHQIoh2NUCY94o13K5z4YDaRSlPoixMNme X-Google-Smtp-Source: AGHT+IE0cIAV9biT9j86H70u5/uY1DLxXvshdD2dg3vVnFVBB/xvhByLjr6JvyVJY4hbl5Kev7IlcQ== X-Received: by 2002:a05:6a00:2451:b0:736:5dc6:a14b with SMTP id d2e1a72fcca58-7398038d624mr2830035b3a.13.1743227692475; Fri, 28 Mar 2025 22:54:52 -0700 (PDT) Received: from localhost ([2601:644:8000:ee20:c090:a7c:4bd8:1550]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73970e2b034sm2918341b3a.69.2025.03.28.22.54.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Mar 2025 22:54:51 -0700 (PDT) Sender: Gurjeet Singh Content-Type: multipart/mixed; boundary=5e86b7ee4bf88199981394e2d4b5334e1402aafb83904ce059ee7477fd8e Mime-Version: 1.0 Date: Fri, 28 Mar 2025 22:54:50 -0700 Message-Id: Cc: , Subject: Re: BUG #18871: Cross-partition MERGE fails with unclear internal error From: "Gurjeet Singh" To: "Tender Wang" , "Dean Rasheed" X-Mailer: aerc 0.20.1 References: <18871-b44e3c96de3bd2e8@postgresql.org> In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --5e86b7ee4bf88199981394e2d4b5334e1402aafb83904ce059ee7477fd8e Content-Type: multipart/alternative; boundary=e0ae857a8813deee1f49e93478c4e2ab4dfbdee646be485859e2b002e3c2 --e0ae857a8813deee1f49e93478c4e2ab4dfbdee646be485859e2b002e3c2 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Content-Type: text/plain; charset=UTF-8 On Fri Mar 28, 2025 at 7:39 PM PDT, Tender Wang wrote: > In ExecInitPartitionInfo(), it has comments like: > > * This duplicates much of the logic in ExecInitMerge(), so something > * changes there, look here too. > > ExecInitMerge() considers CMD_NOTHING operation. > I give the attached fix. I would've expecetd the comment to be in ExecInitMerge(), asking the reader to look at other places the logic is duplicated. Attached is a patch with an attempt at that; it includes the diff from your patch, too, so I named it v2. Best regards, Gurjeet http://Gurje.et --e0ae857a8813deee1f49e93478c4e2ab4dfbdee646be485859e2b002e3c2-- --5e86b7ee4bf88199981394e2d4b5334e1402aafb83904ce059ee7477fd8e Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0002-Fix-cross-partition-merge-fail.patch Content-Type: text/plain; charset=utf-8; name=0002-Fix-cross-partition-merge-fail.patch ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2V4ZWN1dG9yL2V4ZWNQYXJ0aXRpb24uYyBiL3NyYy9i YWNrZW5kL2V4ZWN1dG9yL2V4ZWNQYXJ0aXRpb24uYwppbmRleCA4NGNjZDdkNDU3ZC4uOGQxZTNj MDYyNGYgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2V4ZWN1dG9yL2V4ZWNQYXJ0aXRpb24uYwor KysgYi9zcmMvYmFja2VuZC9leGVjdXRvci9leGVjUGFydGl0aW9uLmMKQEAgLTk1Niw2ICs5NTYs NyBAQCBFeGVjSW5pdFBhcnRpdGlvbkluZm8oTW9kaWZ5VGFibGVTdGF0ZSAqbXRzdGF0ZSwgRVN0 YXRlICplc3RhdGUsCiAJCQkJCQkJCQkJCQkgIE5VTEwpOwogCQkJCQlicmVhazsKIAkJCQljYXNl IENNRF9ERUxFVEU6CisJCQkJY2FzZSBDTURfTk9USElORzoKIAkJCQkJYnJlYWs7CiAKIAkJCQlk ZWZhdWx0OgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvZXhlY3V0b3Ivbm9kZU1vZGlmeVRhYmxl LmMgYi9zcmMvYmFja2VuZC9leGVjdXRvci9ub2RlTW9kaWZ5VGFibGUuYwppbmRleCA4N2M4MjAy NzZhOC4uMzgxODQ3Y2ZkZjMgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2V4ZWN1dG9yL25vZGVN b2RpZnlUYWJsZS5jCisrKyBiL3NyYy9iYWNrZW5kL2V4ZWN1dG9yL25vZGVNb2RpZnlUYWJsZS5j CkBAIC0zNzEyLDYgKzM3MTIsMTAgQEAgRXhlY0luaXRNZXJnZShNb2RpZnlUYWJsZVN0YXRlICpt dHN0YXRlLCBFU3RhdGUgKmVzdGF0ZSkKIAkJCQlsYXBwZW5kKHJlc3VsdFJlbEluZm8tPnJpX01l cmdlQWN0aW9uc1thY3Rpb24tPm1hdGNoS2luZF0sCiAJCQkJCQlhY3Rpb25fc3RhdGUpOwogCisJ CQkvKgorCQkJICogRXhlY0luaXRQYXJ0aXRpb25JbmZvKCkgZHVwbGljYXRlcyBtdWNoIG9mIHRo ZSBsb2dpYyBoZXJlLCBzbyBpZgorCQkJICogeW91IGNoYW5nZSBzb21ldGhpbmcgaGVyZSwgbG9v ayB0aGVyZSwgdG9vLgorCQkJICovCiAJCQlzd2l0Y2ggKGFjdGlvbi0+Y29tbWFuZFR5cGUpCiAJ CQl7CiAJCQkJY2FzZSBDTURfSU5TRVJUOgpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9l eHBlY3RlZC9wYXJ0aXRpb25fcHJ1bmUub3V0IGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9w YXJ0aXRpb25fcHJ1bmUub3V0CmluZGV4IDBiZjM1MjYwYjQ2Li4yZjNlNWRiODI1MiAxMDA2NDQK LS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9wYXJ0aXRpb25fcHJ1bmUub3V0CisrKyBi L3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvcGFydGl0aW9uX3BydW5lLm91dApAQCAtNDY5NCw2 ICs0Njk0LDM0IEBAIHRhYmxlIHBhcnRfYWJjX3ZpZXc7CiAgMiB8IGMgfCB0CiAoMiByb3dzKQog Cityb2xsYmFjazsKKy0tIENyb3NzLXBhcnRpdGlvbiBtZXJnZQorYmVnaW47CitleHBsYWluIChj b3N0cyBvZmYpCittZXJnZSBpbnRvIHBhcnRfYWJjX3ZpZXcgcHQKK3VzaW5nIChzZWxlY3QgMyBh cyBhKSBhcyBxIG9uIHB0LmEgPSBxLmEKK1dIRU4gTk9UIE1BVENIRUQgVEhFTiBJTlNFUlQgVkFM VUVTICgxLCAyKQorV0hFTiBNQVRDSEVEIFRIRU4gRE8gTk9USElORzsKKyAgICAgICAgICAgICAg UVVFUlkgUExBTiAgICAgICAgICAgICAgCistLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQorIE1lcmdlIG9uIHBhcnRfYWJjCisgICAtPiAgTmVzdGVkIExvb3AgTGVmdCBKb2lu CisgICAgICAgICAtPiAgUmVzdWx0CisgICAgICAgICAtPiAgUmVzdWx0CisgICAgICAgICAgICAg ICBPbmUtVGltZSBGaWx0ZXI6IGZhbHNlCisoNSByb3dzKQorCittZXJnZSBpbnRvIHBhcnRfYWJj X3ZpZXcgcHQKK3VzaW5nIChzZWxlY3QgMyBhcyBhKSBhcyBxIG9uIHB0LmEgPSBxLmEKK1dIRU4g Tk9UIE1BVENIRUQgVEhFTiBJTlNFUlQgVkFMVUVTICgxLCAyKQorV0hFTiBNQVRDSEVEIFRIRU4g RE8gTk9USElORzsKK3RhYmxlIHBhcnRfYWJjX3ZpZXc7CisgYSB8IGIgfCBjIAorLS0tKy0tLSst LS0KKyAxIHwgMiB8IAorIDIgfCBjIHwgdAorKDIgcm93cykKKwogcm9sbGJhY2s7CiAtLSBBIGNh c2Ugd2l0aCBtdWx0aXBsZSBNb2RpZnlUYWJsZSBub2Rlcy4KIGJlZ2luOwpkaWZmIC0tZ2l0IGEv c3JjL3Rlc3QvcmVncmVzcy9zcWwvcGFydGl0aW9uX3BydW5lLnNxbCBiL3NyYy90ZXN0L3JlZ3Jl c3Mvc3FsL3BhcnRpdGlvbl9wcnVuZS5zcWwKaW5kZXggZjZkYjk0NzlmNTQuLjMzOWM4ZDlhNGU4 IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL3NxbC9wYXJ0aXRpb25fcHJ1bmUuc3FsCisr KyBiL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL3BhcnRpdGlvbl9wcnVuZS5zcWwKQEAgLTE0MTMsNiAr MTQxMywyMCBAQCB3aGVuIG5vdCBtYXRjaGVkIHRoZW4gaW5zZXJ0IHZhbHVlcyAoMSwgJ2QnLCBm YWxzZSkgcmV0dXJuaW5nIHB0LmE7CiB0YWJsZSBwYXJ0X2FiY192aWV3Owogcm9sbGJhY2s7CiAK Ky0tIENyb3NzLXBhcnRpdGlvbiBtZXJnZQorYmVnaW47CitleHBsYWluIChjb3N0cyBvZmYpCitt ZXJnZSBpbnRvIHBhcnRfYWJjX3ZpZXcgcHQKK3VzaW5nIChzZWxlY3QgMyBhcyBhKSBhcyBxIG9u IHB0LmEgPSBxLmEKK1dIRU4gTk9UIE1BVENIRUQgVEhFTiBJTlNFUlQgVkFMVUVTICgxLCAyKQor V0hFTiBNQVRDSEVEIFRIRU4gRE8gTk9USElORzsKK21lcmdlIGludG8gcGFydF9hYmNfdmlldyBw dAordXNpbmcgKHNlbGVjdCAzIGFzIGEpIGFzIHEgb24gcHQuYSA9IHEuYQorV0hFTiBOT1QgTUFU Q0hFRCBUSEVOIElOU0VSVCBWQUxVRVMgKDEsIDIpCitXSEVOIE1BVENIRUQgVEhFTiBETyBOT1RI SU5HOwordGFibGUgcGFydF9hYmNfdmlldzsKK3JvbGxiYWNrOworCiAtLSBBIGNhc2Ugd2l0aCBt dWx0aXBsZSBNb2RpZnlUYWJsZSBub2Rlcy4KIGJlZ2luOwogY3JlYXRlIHRhYmxlIHBhcnRfYWJj X2xvZyAoYWN0aW9uIHRleHQsIGEgaW50LCBiIHRleHQsIGMgYm9vbCk7Cg== --5e86b7ee4bf88199981394e2d4b5334e1402aafb83904ce059ee7477fd8e--