Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uZSz4-003z06-Br for pgsql-bugs@arkaria.postgresql.org; Wed, 09 Jul 2025 11:29:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uZSz2-00FbLM-EV for pgsql-bugs@arkaria.postgresql.org; Wed, 09 Jul 2025 11:29:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uZSz2-00FbL9-62 for pgsql-bugs@lists.postgresql.org; Wed, 09 Jul 2025 11:29:04 +0000 Received: from mx1.b1-systems.de ([159.69.135.40]) by makus.postgresql.org with smtp (Exim 4.96) (envelope-from ) id 1uZSz0-006O7f-2w for pgsql-bugs@lists.postgresql.org; Wed, 09 Jul 2025 11:29:03 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=b1-systems.de; s=default; t=1752060541; bh=1P/M/hxf0tGXT9r7XIzjQEBCkGv9ywhuz5nKBBHxW58=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=CS705SfEjQMvx/YnJ8LUM0s2OhAkx6jEqoDLCz0jl0kIT+ruNPl4vMMaIBQfIhcQU sABCqF24+cEi28EnywHKG9j2t+s72yeiqqGWf7WGBJ58QmelgppSQJKh9pbI3Prvbt I8jxE+/YbnzSrW/vCiw67DC5SZcG3tvr+V48AE1U= Content-Type: multipart/signed; boundary=d4acbc7fd4d20c90858174d792d72f6bccdfc45bbb30facc0755e3c22209; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Wed, 09 Jul 2025 11:28:58 +0000 Message-Id: Cc: "Jim Jones" , , Subject: Re: BUG #18943: Return value of a function 'xmlBufferCreate' is dereferenced at xpath.c:177 without checking for NUL From: "Robin Haberkorn" To: "Michael Paquier" , "Tom Lane" X-Mailer: aerc 0.20.1 References: <31f3480e-cd7d-4021-b392-87922572cc37@uni-muenster.de> <689495.1751981797@sss.pgh.pa.us> In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --d4acbc7fd4d20c90858174d792d72f6bccdfc45bbb30facc0755e3c22209 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Wed Jul 9, 2025 at 03:45:07 GMT +03, Michael Paquier wrote: > Yes, I don't see a huge advantage in doing the switch for this module. > If the gain in information in the error states grabbed from libxml2 > makes it a win, that may be a different argument (I am fine to be > proved wrong), but I cannot get excited about that without more > data to claim it so. > Once switching to PG_XML_STRICTNESS_ALL, we should also theoretically be able to receive warnings and notices, that would be silent otherwise. I believe that getting rid of PG_XML_STRICTNESS_LEGACY might also be desirable if we ever want to get xml2 into core. But I notice that you did already change lots of PG_XML_STRICTNESS_LEGACY into PG_XML_STRICTNESS_ALL. > I have quickly tested the change, and the xpath_string() path was one > area that immediately stood out, and we may report an incorrect error. You are right. The test suite fails or hangs at least. We are probably still missing some checks. So it wouldn't just be a matter of replacing all remaining PG_XML_STRICTNESS_LEGACY. --=20 Robin Haberkorn Software Engineer B1 Systems GmbH Osterfeldstra=C3=9Fe 7 / 85088 Vohburg / https://www.b1-systems.de GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt, HRB 3537 --d4acbc7fd4d20c90858174d792d72f6bccdfc45bbb30facc0755e3c22209 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iI4EABYKADYWIQQGZCeVtjBL5EoLBuoaPVJiid7GHgUCaG5SfRgcaGFiZXJrb3Ju QGIxLXN5c3RlbXMuZGUACgkQGj1SYonexh4rKAD8D7OgMxo5jM+uw16cmnkG4RFK Muv7qBt5cW5FSKlH45IBAPI2s+tEKIeuj1T/2ZQcJ4Za/7G5mlpjyBaCBFgEfDUA =AFcK -----END PGP SIGNATURE----- --d4acbc7fd4d20c90858174d792d72f6bccdfc45bbb30facc0755e3c22209--