Date: Thu, 03 Feb 2022 07:55:36 -0800
From: Andres Freund <andres@anarazel.de>
To: Daniel Gustafsson <daniel@yesql.se>, Tom Lane <tgl@sss.pgh.pa.us>
CC: Thomas Munro <thomas.munro@gmail.com>, byavuz81@gmail.com,
 PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
 Heikki Linnakangas <heikki.linnakangas@iki.fi>,
 Michael Paquier <michael@paquier.xyz>
Subject: =?US-ASCII?Q?Re=3A_BUG_=2317391=3A_While_using?=
 =?US-ASCII?Q?_--with-ssl=3Dopenssl_and_PG=5F?=
 =?US-ASCII?Q?TEST=5FEXTRA=3D=27ssl=27_options=2C_S?=
 =?US-ASCII?Q?SL_tests_fail_on_OpenBSD_7=2E0?=
User-Agent: K-9 Mail for Android
In-Reply-To: <E59CF4C1-18F4-4077-9421-99ECA799A8A6@yesql.se>
References: <17391-304f81bcf724b58b@postgresql.org>
 <20220202213900.h7paogmcge2rtls6@alap3.anarazel.de>
 <CA+hUKGJ4+Ug16QU-PYGEZwUe2O69hdnCuyzLhMHHF02_uA4C5w@mail.gmail.com>
 <131329.1643851912@sss.pgh.pa.us> <203742.1643866877@sss.pgh.pa.us>
 <C44CE9FB-B37E-47D3-924B-4AF808AE98B1@yesql.se>
 <E59CF4C1-18F4-4077-9421-99ECA799A8A6@yesql.se>
Message-ID: <DECBA99E-0085-4BCF-8640-3576E0BE4292@anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/DECBA99E-0085-4BCF-8640-3576E0BE4292%40anarazel.de>
Precedence: bulk

Hi,=20

On February 3, 2022 7:48:40 AM PST, Daniel Gustafsson <daniel@yesql=2Ese> =
wrote:
>Pouring over SSL test logs I was again red-herringed by the warning we ge=
t for
>using hex() on a large input value, before I remembered that it's benign =
and
>emerged from the rabbithole:
>
>  Hexadecimal number > 0xffffffff non-portable at t/001_ssltests=2Epl lin=
e 508=2E
>
>We could suppress it by turning off warnings for that line, since we know=
 it
>will work due to the 64-bit int test a few lines before:
>
>@@ -505,6 +505,7 @@ if ($? =3D=3D 0)
>        {
>                $serialno =3D~ s/^serial=3D//;
>                $serialno =3D~ s/\s+//g;
>+               local $SIG{'__WARN__'} =3D sub { };
>                $serialno =3D hex($serialno);
>        }
>        else
>
>Turning of warnings might be a bridge too far for some though? Thoughts?

Can't we just chop serialno into two 32bit numbers and call hex separately=
? Seems about as hard as adding a comment explaining what the warn bit is a=
bout=2E=2E=2E

Andres

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E