Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sCZDv-006TMn-Tl for pgsql-bugs@arkaria.postgresql.org; Thu, 30 May 2024 06:25:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sCZDv-001dJB-T9 for pgsql-bugs@arkaria.postgresql.org; Thu, 30 May 2024 06:25:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sCZDv-001dJ3-KU for pgsql-bugs@lists.postgresql.org; Thu, 30 May 2024 06:25:15 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sCZDt-002d1X-3B for pgsql-bugs@lists.postgresql.org; Thu, 30 May 2024 06:25:14 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id AECB8301CE9E for ; Thu, 30 May 2024 08:25:11 +0200 (CEST) Received: from s981.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 9EFBA2E27B17; Thu, 30 May 2024 08:25:11 +0200 (CEST) Received: from s470.loopia.se (unknown [172.22.191.5]) by s981.loopia.se (Postfix) with ESMTP id 9D49722B17D2; Thu, 30 May 2024 08:25:11 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s470.loopia.se (amavisd-new); dkim=pass (2048-bit key) header.d=yesql.se Received: from s934.loopia.se ([172.22.191.5]) by s470.loopia.se (s470.loopia.se [172.22.190.34]) (amavisd-new, port 10024) with LMTP id JbUOhs1WUtnh; Thu, 30 May 2024 08:25:11 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s934.loopia.se (Postfix) with ESMTPSA id 40D737CEA8F; Thu, 30 May 2024 08:25:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yesql.se; s=loopiadkim1707475645; t=1717050311; bh=zEsy7Oxq7dL99nnnTkK0Vb71gTraGzF0zpwpK1skvmM=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=gMdwtT8L2DMlQ5VYhrnqMfEZn743BrbtukpbzK7mXhJHaoNmResnk3r17drTpvwW0 e3OqEYU4rk2avqog2ebLbH1gugqZ6OIiudXucpEagCexWl1FNj6skszOl9N+A1LWBl K5v3bAJL+Hv6l0DiP12L0ARJ++pLkslVlad2LTKUjYxD/JriABzZIe2hgRlw3CqyNm PwZ8fpluQu+kPnYQbmbTzw/PFSkEOt1X3nXpz3vtTAYepDHWEAPbJ+GPfipUNpcAuK S5P/jL1mm0oImCxaSjsTbqNiqtqzIMIk/y56YF7nVno2xG4eA4TZmQTBam15QtD8qO BnpLnR6ZEjXVg== Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Subject: Re: BUG #18484: "Cannot enlarge string buffer" during parallel execution of prepared statement/partitioning From: Daniel Gustafsson In-Reply-To: Date: Thu, 30 May 2024 08:25:00 +0200 Cc: michael.banck@netapp.com, pgsql-bugs@lists.postgresql.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <18484-3e357ade5fe50e61@postgresql.org> To: David Rowley X-Mailer: Apple Mail (2.3774.500.171.1.1) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 30 May 2024, at 03:26, David Rowley wrote: > I think we should at least write a better error message. "out of > memory" is misleading. I've attached a patch with some proposed better > wording. >=20 > The above will become: > ERROR: string buffer exceeds maximum allowed length (1073741823) > DETAIL: Cannot enlarge string buffer containing 1073741812 bytes by = 32 more Should we use a more human readable unit than bytes in the errmsg as = well? -- Daniel Gustafsson