Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\))
Subject: Re: postgres crash on concurrent update of inheritance partitioned
 table
From: Oleksii Kliukin <alexk@hintbits.com>
In-Reply-To: <29583.1580250599@sss.pgh.pa.us>
Date: Wed, 29 Jan 2020 10:20:30 +0100
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>,
 Andres Freund <andres@anarazel.de>,
 pgsql-bugs@lists.postgresql.org,
 ildus@adjust.com,
 Chris Travers <chris.travers@adjust.com>,
 Nick Babadzhanian <nickb@adjust.com>,
 julian.schauder@gmx.de
Content-Transfer-Encoding: quoted-printable
Message-Id: <EDC3F2AC-53D1-407C-82AC-954A700FF059@hintbits.com>
References: <EEF05F66-2871-4786-992B-5F45C92FEE2E@hintbits.com>
 <20200128170755.bq3f27bfkjpt4d4b@development>
 <29583.1580250599@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Precedence: bulk

Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
>> On Tue, Jan 28, 2020 at 05:17:14PM +0100, Oleksii Kliukin wrote:
>>> We have experienced a few crashes a day since upgrading to pg 12.1 =
last
>>> week, during the process of updating an inheritance-partitioned =
table by
>>> several concurrent sessions.
>=20
>> Yeah, I can reproduce it too. If I had to guess, I'd say it's another
>> bug due to=20
>>     commit 3fb307bc4a76815f96fec28a0d1525ab3fbbcfb4
>>     Author: Andres Freund <andres@anarazel.de>
>>     Date:   Mon Sep 9 05:21:30 2019 -0700
>>     Reorder EPQ work, to fix rowmark related bugs and improve =
efficiency.
>> which introduced relsubs_done et al, and perhaps did not get the life
>> cycle / resetting right. Not sure.
>=20
> Yup, that's it exactly.  EvalPlanQualStart was expecting to reuse
> relsubs_rowmark and relsubs_done, but that storage will be recycled by
> EvalPlanQualEnd because it's in the query context of the =
recheckestate.
> AFAICS the re-use has no semantic value, so I just got rid of it.

Sounds good, thank you!

Regards,
Oleksii =E2=80=9CAlex=E2=80=9D Kliukin=