Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Subject: Re: BUG #17212: pg_amcheck fails on checking temporary relations
From: Mark Dilger <mark.dilger@enterprisedb.com>
In-Reply-To: 
 <CAH2-Wz=QtFGoSk=QWfvPt3g2npq0LKuehYQG6B_tncOag4DfwQ@mail.gmail.com>
Date: Wed, 6 Oct 2021 12:36:50 -0700
Cc: Robert Haas <robertmhaas@gmail.com>,
 Pavel Borisov <pashkin.elfe@gmail.com>,
 Alexander Lakhin <exclusion@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <EF64781F-37C2-470F-B71F-5ACA2F81FE16@enterprisedb.com>
References: <17212-34dd4a1d6bba98bf@postgresql.org>
 <CAH2-Wz=bw-Uk2yoOq7yevC9hyMGgZ2Ud34nd9YJJPXJ3pkVcrw@mail.gmail.com>
 <E85855BD-C063-4B24-9EAA-02DECC8F42B9@enterprisedb.com>
 <E283B45F-5745-49C9-BBC7-99876E2FABD1@enterprisedb.com>
 <f42de8ec-f219-0922-93b3-37a72bba1feb@gmail.com>
 <28B36E41-1E8F-4DC1-A924-711621BA4972@enterprisedb.com>
 <CAH2-Wz=v4py=c79J7wpdVmQMkd8rO7gj5Ur5Dp4E0y7aQUz6cg@mail.gmail.com>
 <386F66EE-DEFD-42EA-9DB2-102BF3414669@enterprisedb.com>
 <CAH2-Wzkwb+1GSONMrXByHhgkzD-N59A_kFcvsoA_+M9cNNHm5g@mail.gmail.com>
 <CA+TgmobJnZE6WMw1y+N9ts36nsbL_un0CYB_khieg8rOa86RBw@mail.gmail.com>
 <CAH2-Wzm02e=jAarpzeZGyK8JyXTvuHCfJ9KC5svosD72nROKrw@mail.gmail.com>
 <B2BDB87C-8288-436E-B3DC-8AEB92FEB8F1@enterprisedb.com>
 <CAH2-Wz=WYdmbc1k8Lr2P4eQeYkh1UYvyDigzrvukejcWc2jKOA@mail.gmail.com>
 <c422a1aa-81c0-0762-0971-9a026cf2aa79@gmail.com>
 <CAH2-WzndLb0-GZcshTJGw6u6SQrJ5puyFiFYh-DWR8ue2zQuvA@mail.gmail.com>
 <CALT9ZEGhuXiH54VgyVJ65V+ccGqPqHTduBM4saPWSD2mrD5C6Q@mail.gmail.com>
 <F824CD5F-C82F-451C-AE67-9AD31447424A@enterprisedb.com>
 <CAH2-WznaYWowxxFaGK6Hv=SUQYS2-r7dQZJFWyDT_W6GGtuCjA@mail.gmail.com>
 <63FF68F5-683D-423E-A667-9C00441101A5@enterprisedb.com>
 <CAH2-Wz=8RP6izkLF=P_bFUK-CyTsO09hQ1-ZsC9P4Qiz3CughQ@mail.gmail.com>
 <561CE3DB-5CBC-44BF-9A3E-1D7FAEB123E0@enterprisedb.com>
 <CA+TgmobtAq9sNa0Z4QNx0xiP4NAobuGOnOirTWdJajkTRFvXNw@mail.gmail.com>
 <CAH2-WzmJkVKFSqJd2_uy07jPg-LW0yCHh0fgA8rFkdyk6FZOnQ@mail.gmail.com>
 <CAH2-Wz=QtFGoSk=QWfvPt3g2npq0LKuehYQG6B_tncOag4DfwQ@mail.gmail.com>
To: Peter Geoghegan <pg@bowt.ie>
Archived-At: 
 <https://www.postgresql.org/message-id/EF64781F-37C2-470F-B71F-5ACA2F81FE16%40enterprisedb.com>
Precedence: bulk


> On Oct 6, 2021, at 12:28 PM, Peter Geoghegan <pg@bowt.ie> wrote:
>=20
> I think that what I've said boils down to this:
>=20
> * pg_amcheck shouldn't attempt to verify temp relations, on the
> grounds that this is fundamentally not useful, and not something that
> could ever be sensibly interpreted as "just doing what the user asked
> for".

Right.  I don't think there has been any disagreement on this.  There is =
a bug in pg_amcheck with respect to this issue, and we all agree on =
that.

> * pg_amcheck calls to bt_index_check()/bt_index_parent_check() must
> only be made with "i.indisready AND i.indisvalid" indexes, just like
> the old query from the docs. (Actually, the same query also filters
> out temp relations -- which is why I view this issue as almost
> identical to the first.)
>=20
> Why would the user ask for something that fundamentally doesn't make
> any sense?

The user may not know that the system has changed.

For example, if I see errors in the logs suggesting corruption in a =
relation named "mark" and run pg_amcheck --relation=3Dmark, I expect =
that to check the relation.  If that relation is a temporary table, I'd =
like to know that it's not going to be checked, not just have pg_amcheck =
report that everything is ok.

As another example, if I change my environment variables to connect to =
the standby rather than the primary, and forget that I did so, and then =
run pg_amcheck --relation=3Dunlogged_relation, I'd rather get a =
complaint that I can't check an unlogged relation on a standby than get =
nothing.  Sure, what I did doesn't make sense, but why should the =
application paper over that mistake?

=E2=80=94
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company